Re: [PATCH 3/8] CLI: replace some constructs with more uncrustify friendly ones

2019-06-17 Thread Daniel Kahn Gillmor
On Mon 2019-06-17 01:01:39 -0400, David Bremner wrote: > Yes, the C11 standard seems pretty clear here, 6.3.1.{1,2} Thanks for the reference. I'm fine with accepting these changes, and chalking this up as one more piece of programming arcana that i've learned from working on the notmuch project

Re: [PATCH 3/8] CLI: replace some constructs with more uncrustify friendly ones

2019-06-16 Thread David Bremner
Daniel Kahn Gillmor writes: > On Thu 2019-06-13 08:08:32 -0300, David Bremner wrote: >>- add parens in some ternery operators > > itym "ternary" yep. > >> @@ -120,13 +120,13 @@ _process_string_arg (const notmuch_opt_desc_t >> *arg_desc, char next, const char * >> static int

Re: [PATCH 3/8] CLI: replace some constructs with more uncrustify friendly ones

2019-06-16 Thread Daniel Kahn Gillmor
On Thu 2019-06-13 08:08:32 -0300, David Bremner wrote: >- add parens in some ternery operators itym "ternary" > @@ -120,13 +120,13 @@ _process_string_arg (const notmuch_opt_desc_t > *arg_desc, char next, const char * > static int _opt_set_count (const notmuch_opt_desc_t *opt_desc) > { >

[PATCH 3/8] CLI: replace some constructs with more uncrustify friendly ones

2019-06-13 Thread David Bremner
In particular - use (bool) instead of !! - cuddle the opening parens of function calls - add parens in some ternery operators --- command-line-arguments.c | 16 mime-node.c | 8 notmuch-search.c | 4 ++-- notmuch-show.c | 16