Quoth Dmitry Kurochkin on Dec 11 at 2:34 pm:
> Hi Austin.
>
> I enjoyed reviewing this patch. It is a pleasure to see how complex and
> confusing code becomes much smaller and cleaner.
>
> I still have some questions with the new code. It seems confusing to me
> that part_content is called fir
Quoth Dmitry Kurochkin on Dec 11 at 2:34 pm:
> Hi Austin.
>
> I enjoyed reviewing this patch. It is a pleasure to see how complex and
> confusing code becomes much smaller and cleaner.
>
> I still have some questions with the new code. It seems confusing to me
> that part_content is called fir
Hi Austin.
I enjoyed reviewing this patch. It is a pleasure to see how complex and
confusing code becomes much smaller and cleaner.
I still have some questions with the new code. It seems confusing to me
that part_content is called first and then go envelope headers. But I
this is just the fir
Hi Austin.
I enjoyed reviewing this patch. It is a pleasure to see how complex and
confusing code becomes much smaller and cleaner.
I still have some questions with the new code. It seems confusing to me
that part_content is called first and then go envelope headers. But I
this is just the fir
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
On Sun, 27 Nov 2011 21:21:11 -0500, Austin Clements wrote:
> Since this is a rewrite, the diff is not very enlightening. It's
> easier to look at the old code and the new code side-by-side.
Hi Austin, try the git format-patch --break-rewrites option. It works
nicely on patches like this. See bel
On Sun, 27 Nov 2011 21:21:11 -0500, Austin Clements wrote:
> Since this is a rewrite, the diff is not very enlightening. It's
> easier to look at the old code and the new code side-by-side.
Hi Austin, try the git format-patch --break-rewrites option. It works
nicely on patches like this. See bel
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
12 matches
Mail list logo
