[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-06 Thread Jani Nikula
On Mar 5, 2012 11:11 PM, "Dmitry Kurochkin" wrote: > > On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula wrote: > > On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > > wrote: > > > > > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe > > wrote: > > > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kur

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-06 Thread Dmitry Kurochkin
On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula wrote: > On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > wrote: > > > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe > wrote: > > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin < > dmitry.kurochkin at gmail.com> wrote: > > > > On Thu, 1

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-06 Thread Jani Nikula
On Mar 5, 2012 11:11 PM, "Dmitry Kurochkin" wrote: > > On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula wrote: > > On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > > wrote: > > > > > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe > > wrote: > > > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kur

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Jani Nikula
On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" wrote: > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin < dmitry.kurochkin at gmail.com> wrote: > > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > > > > notmuch-saved-s

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Daniel Schoepe
On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > I do not buy the argument that we should help users who implement their > own sorting functions but do not read documentation for functions they > use. Apparently, those who implemented the `sort' function had similar > ideas. And I do not think it is

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > > wrote: > > > notmuch-saved-search-sort-function might destructively modify its > > > input (`sort' does

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Tomi Ollila
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > > wrote: > > > notmuch-saved-search-sort-function might destructively modify its > > > input (`sort' does

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula wrote: > On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > wrote: > > > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe > wrote: > > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin < > dmitry.kuroch...@gmail.com> wrote: > > > > On Thu, 1 Mar

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Daniel Schoepe
On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" > I do not buy the argument that we should help users who implement their > own sorting functions but do not read documentation for functions they > use. Apparently, those who implemented the `sort' function had similar > ideas. And I do not think it is

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Jani Nikula
On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" wrote: > > On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin < dmitry.kuroch...@gmail.com> wrote: > > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > > > > notmuch-saved-sear

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Daniel Schoepe
On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin wrote: > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > wrote: > > notmuch-saved-search-sort-function might destructively modify its > > input (`sort' does that, for instance), so it should not be given > > notmuch-saved-searches directl

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin > wrote: > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > > wrote: > > > notmuch-saved-search-sort-function might destructively modify its > > > input (`sort' does that, for

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Tomi Ollila
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe wrote: > On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin > wrote: > > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe > > wrote: > > > notmuch-saved-search-sort-function might destructively modify its > > > input (`sort' does that, for

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. > --- -1 I think we should require `notmuch-saved-search-sort-func

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Daniel Schoepe
On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin wrote: > On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > > notmuch-saved-search-sort-function might destructively modify its > > input (`sort' does that, for instance), so it should not be given > > notmuch-saved-searches directly.

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-04 Thread Dmitry Kurochkin
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. > --- -1 I think we should require `notmuch-saved-search-sort-funct

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-03 Thread Jani Nikula
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. Hi Daniel, thanks for fixing this. Works for me. Full disclosure:

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-03 Thread Jani Nikula
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe wrote: > notmuch-saved-search-sort-function might destructively modify its > input (`sort' does that, for instance), so it should not be given > notmuch-saved-searches directly. Hi Daniel, thanks for fixing this. Works for me. Full disclosure: I

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-01 Thread Daniel Schoepe
notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- emacs/notmuch-hello.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emac

[PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-01 Thread Daniel Schoepe
notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- emacs/notmuch-hello.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emac