Re: [PATCH v3 04/15] crypto: move into libutil

2017-10-12 Thread David Bremner
Daniel Kahn Gillmor writes: > Hi Bremner-- > > Thanks for the review! > > On Thu 2017-10-12 07:54:33 -0300, David Bremner wrote: >> Daniel Kahn Gillmor writes: >> >>> This prepares us for using the crypto object in both the library and >>> the client. >> >> I think we could be more precise about

Re: [PATCH v3 04/15] crypto: move into libutil

2017-10-12 Thread Daniel Kahn Gillmor
Hi Bremner-- Thanks for the review! On Thu 2017-10-12 07:54:33 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> This prepares us for using the crypto object in both the library and >> the client. > > I think we could be more precise about names here, to help outsiders get > up to s

Re: [PATCH v3 04/15] crypto: move into libutil

2017-10-12 Thread David Bremner
Daniel Kahn Gillmor writes: > This prepares us for using the crypto object in both the library and > the client. I think we could be more precise about names here, to help outsiders get up to speed on the code. libutil was renamed to libnotmuch_util, and "the library" should probably be "libnotm

[PATCH v3 04/15] crypto: move into libutil

2017-10-09 Thread Daniel Kahn Gillmor
This prepares us for using the crypto object in both the library and the client. --- Makefile.local| 1 - notmuch-client.h | 22 +- util/Makefile.local | 2 +- crypto.c => util/crypto.c | 6 +- util/crypto.h | 28 +++