[notmuch] pull request [was Re: pull request]

2010-04-05 Thread Carl Worth
On Sun, 04 Apr 2010 09:08:34 +0100, David Edmondson wrote: > It's the 'for-cworth' branch of git://github.com/dme/notmuch.git. > > There's also a simple update to tell git to ignore notmuch-shared. Thanks. This is pushed. -Carl -- next part -- A non-text attachment was

Re: [notmuch] pull request [was Re: pull request]

2010-04-05 Thread Carl Worth
On Sun, 04 Apr 2010 09:08:34 +0100, David Edmondson d...@dme.org wrote: It's the 'for-cworth' branch of git://github.com/dme/notmuch.git. There's also a simple update to tell git to ignore notmuch-shared. Thanks. This is pushed. -Carl pgpRssLrxCuvt.pgp Description: PGP signature

[notmuch] pull request [was Re: pull request]

2010-04-04 Thread David Edmondson
On Sun, 04 Apr 2010 08:33:00 +0100, David Edmondson wrote: > I'll declare common variables and 'exported' functions in > 'notmuch-lib.el'. It may take a few days (I'm supposed to be on > holiday). It was quicker than expected. Using 'declare-function' in a file that is required didn't have the

[notmuch] pull request [was Re: pull request]

2010-04-04 Thread David Edmondson
On Sat, 03 Apr 2010 18:21:57 -0300, David Bremner wrote: > The warnings about unknown functions can be eliminated by use the > declare-function macro; if you have emacs lisp reference manual (it > required the package emacs23-common-non-dfsg on Debian) then you can > run: > > ESC ESC : (info

Re: [notmuch] pull request [was Re: pull request]

2010-04-04 Thread David Edmondson
On Sat, 03 Apr 2010 18:21:57 -0300, David Bremner brem...@unb.ca wrote: The warnings about unknown functions can be eliminated by use the declare-function macro; if you have emacs lisp reference manual (it required the package emacs23-common-non-dfsg on Debian) then you can run: ESC ESC :

Re: [notmuch] pull request [was Re: pull request]

2010-04-04 Thread David Edmondson
On Sun, 04 Apr 2010 08:33:00 +0100, David Edmondson d...@dme.org wrote: I'll declare common variables and 'exported' functions in 'notmuch-lib.el'. It may take a few days (I'm supposed to be on holiday). It was quicker than expected. Using 'declare-function' in a file that is required didn't

[notmuch] pull request [was Re: pull request]

2010-04-03 Thread David Bremner
On Sat, 03 Apr 2010 12:37:46 -0700, Carl Worth wrote: > > If I apply this patch as is, then when compiling the notmuch-show.el I > get the following warnings: > > In notmuch-show: > notmuch-show.el:969:34:Warning: reference to free variable `notmuch-command' > > In end of data: >

[notmuch] pull request

2010-04-03 Thread Carl Worth
On Sat, 03 Apr 2010 07:34:57 +0100, David Edmondson wrote: > As part of having more information about MIME structure in the JSON > output (multipart/alternative, for example), I think that we (I, if I > get to it first) will need to re-work the `show' implementation > somewhat. We should wait

[notmuch] pull request [was Re: pull request]

2010-04-03 Thread Carl Worth
On Sat, 03 Apr 2010 07:32:44 +0100, David Edmondson wrote: > * commit a9590dfb4efc2c05a35948ef4522c362eb788c10 > | Author: David Edmondson > | Date: Thu Apr 1 11:38:30 2010 +0100 > | > | Makefile: Add the emacs directory to load-path when compiling That's a nice one-line summary of the

[notmuch] pull request

2010-04-03 Thread David Edmondson
On Fri, 02 Apr 2010 15:53:34 -0700, Carl Worth wrote: > Having played with it a tiny bit, I do think that since the part command > always requires a --part option that we might as well just make it part > of notmuch show. That is: > > notmuch show --part=2 id:foo > > instead of: > >

[notmuch] pull request [was Re: pull request]

2010-04-03 Thread David Edmondson
On Fri, 02 Apr 2010 15:53:34 -0700, Carl Worth wrote: > On Fri, 02 Apr 2010 09:53:04 +0100, David Edmondson wrote: > > The updated changes are on the 'dme-for-cworth' branch now. > > Thanks for the quick update, David! > > I've pushed this now. Thanks. Here's another set to consider. They are

[notmuch] pull request [was Re: pull request]

2010-04-03 Thread David Edmondson
On Fri, 02 Apr 2010 15:53:34 -0700, Carl Worth cwo...@cworth.org wrote: On Fri, 02 Apr 2010 09:53:04 +0100, David Edmondson d...@dme.org wrote: The updated changes are on the 'dme-for-cworth' branch now. Thanks for the quick update, David! I've pushed this now. Thanks. Here's another set

Re: [notmuch] pull request [was Re: pull request]

2010-04-03 Thread Carl Worth
On Sat, 03 Apr 2010 07:32:44 +0100, David Edmondson d...@dme.org wrote: * commit a9590dfb4efc2c05a35948ef4522c362eb788c10 | Author: David Edmondson d...@dme.org | Date: Thu Apr 1 11:38:30 2010 +0100 | | Makefile: Add the emacs directory to load-path when compiling That's a nice

Re: [notmuch] pull request

2010-04-03 Thread Carl Worth
On Sat, 03 Apr 2010 07:34:57 +0100, David Edmondson d...@dme.org wrote: As part of having more information about MIME structure in the JSON output (multipart/alternative, for example), I think that we (I, if I get to it first) will need to re-work the `show' implementation somewhat. We should

[notmuch] pull request

2010-04-02 Thread David Edmondson
On Thu, 01 Apr 2010 14:09:57 -0700, Carl Worth wrote: > On Thu, 01 Apr 2010 15:41:03 +0100, David Edmondson wrote: > > Carl, a couple of patches that I'd like you to consider. They are the > > first two on the `dme' branch of git://github.com/dme/notmuch.git. The updated changes are on the

Re: [notmuch] pull request

2010-04-02 Thread David Edmondson
On Thu, 01 Apr 2010 14:09:57 -0700, Carl Worth cwo...@cworth.org wrote: On Thu, 01 Apr 2010 15:41:03 +0100, David Edmondson d...@dme.org wrote: Carl, a couple of patches that I'd like you to consider. They are the first two on the `dme' branch of git://github.com/dme/notmuch.git. The updated

Re: [notmuch] pull request

2010-04-02 Thread Carl Worth
On Fri, 02 Apr 2010 09:53:04 +0100, David Edmondson d...@dme.org wrote: The updated changes are on the 'dme-for-cworth' branch now. Thanks for the quick update, David! I've pushed this now. Having played with it a tiny bit, I do think that since the part command always requires a --part option

[notmuch] pull request

2010-04-01 Thread David Bremner
On Thu, 01 Apr 2010 14:09:57 -0700, Carl Worth wrote: > More significantly, this level of documentation needs to be put into the > "notmuch help" output (instead of the placeholder that's there in the > current patch). It also needs to be added to the man page in notmuch.1. Allow me to

[notmuch] pull request

2010-04-01 Thread David Edmondson
Carl, a couple of patches that I'd like you to consider. They are the first two on the `dme' branch of git://github.com/dme/notmuch.git. http://github.com/dme/notmuch/commit/f86254e4509ed02731aa3eaa8541df1f2d11e400 > notmuch-show: Add unix and pretty dates to the JSON output > > Include a

[notmuch] pull request

2010-04-01 Thread Carl Worth
On Thu, 01 Apr 2010 15:41:03 +0100, David Edmondson wrote: > Carl, a couple of patches that I'd like you to consider. They are the > first two on the `dme' branch of git://github.com/dme/notmuch.git. Thanks, David! I've got your branch fetched here and I plan to start playing with it. The

Re: [notmuch] pull request

2010-04-01 Thread David Bremner
On Thu, 01 Apr 2010 14:09:57 -0700, Carl Worth cwo...@cworth.org wrote: More significantly, this level of documentation needs to be put into the notmuch help output (instead of the placeholder that's there in the current patch). It also needs to be added to the man page in notmuch.1. Allow me