RE: [PATCH v3] VIM: Improve moving between messages in a thread

2015-02-02 Thread Bartosz Telenczuk
> I think the API should be clear and easy to understand, because people will > probably bind them to custom shortcuts. You should not have to think about > what that weird extra parameter (-1, false, ...) means and go read the docs. I agree. One might replace the parameter with a string like "p

RE: [PATCH v3] VIM: Improve moving between messages in a thread

2015-01-21 Thread Franz Fellner
Bartosz Telenczuk wrote: > Hi Ian, > > The patch looks good. I tested it on my system and it works fine. I just > have one suggestion regarding coding style. > > > +function! s:show_prev_msg() > > function! s:show_next_msg() > > Since these functions are almost the same, you could avoid code

RE: [PATCH v3] VIM: Improve moving between messages in a thread

2015-01-13 Thread Bartosz Telenczuk
Hi Ian, The patch looks good. I tested it on my system and it works fine. I just have one suggestion regarding coding style. > +function! s:show_prev_msg() > function! s:show_next_msg() Since these functions are almost the same, you could avoid code repetition by replacing them by a function