Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-02-01 Thread Dmitry Kurochkin
On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet wrote: > On Mon, 30 Jan 2012 09:23:40 +, David Edmondson wrote: > > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote:

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-02-01 Thread Pieter Praet
On Mon, 30 Jan 2012 23:34:12 -0400, David Bremner wrote: > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > > > --- > > Sorry, it conflicts with Jamie's patches that I just pushed. > Please don't apologize for doing the

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-02-01 Thread Pieter Praet
On Mon, 30 Jan 2012 09:59:32 +0200, Tomi Ollila wrote: > On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet wrote: > > On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner wrote: > > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > > > Less code, same results, without sacrificing readab

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-02-01 Thread Pieter Praet
On Mon, 30 Jan 2012 09:23:40 +, David Edmondson wrote: > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > > > > > Sometimes someone (Dmitry?) sent patches that separ

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread David Bremner
On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. > > --- Sorry, it conflicts with Jamie's patches that I just pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchm

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread David Edmondson
On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > > > Sometimes someone (Dmitry?) sent patches that separated a small functional > > change, and the big non-functional indenta

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-29 Thread Tomi Ollila
On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet wrote: > On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > > Less code, same results, without sacrificing readability. > > > > > > > This looks OK, although the re-indenting

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-29 Thread Pieter Praet
On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner wrote: > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > > > This looks OK, although the re-indenting makes these kind of changes > painful to review (not that I'm suggest

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-28 Thread David Bremner
On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > Sometimes someone (Dmitry?) sent patches that separated a small functional > change, and the big non-functional indentation change it caused, > separately. Would you prefer (or tolerate ;

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-28 Thread Jani Nikula
On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > > > This looks OK, although the re-indenting makes these kind of changes > painful to review (not that I'm suggesting we sh

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-28 Thread David Bremner
On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > Less code, same results, without sacrificing readability. > This looks OK, although the re-indenting makes these kind of changes painful to review (not that I'm suggesting we should re-indent, just some random complaining). d _