Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-17 Thread Dmitry Kurochkin
Hello. On Mon, 16 Jan 2012 12:21:20 +, Jani Nikula wrote: > On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin > wrote: > > On Mon, 16 Jan 2012 11:35:37 +, David Edmondson wrote: > > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > > wrote: > > > > Before the change, ther

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin wrote: > On Mon, 16 Jan 2012 11:35:37 +, David Edmondson wrote: > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > wrote: > > > Before the change, there were two ways to do search in Emacs UI: > > > search widget in notmuch-hel

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin wrote: > > Dmitry, if Daniel re-submits his patches to allow the construction of > > `notmuch-hello' buffers to be configured, it seems that this patchset > > would become unnecessary. Is that correct? > > Right. We will just need to fix the

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread Dmitry Kurochkin
On Mon, 16 Jan 2012 11:35:37 +, David Edmondson wrote: > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > wrote: > > Before the change, there were two ways to do search in Emacs UI: > > search widget in notmuch-hello buffer and `notmuch-search' > > function bound to "s". Internally, n

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread David Edmondson
On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin wrote: > Before the change, there were two ways to do search in Emacs UI: > search widget in notmuch-hello buffer and `notmuch-search' > function bound to "s". Internally, notmuch-hello search widget > uses `notmuch-search' function. But it u

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-03 Thread Xavier Maillard
On Mon, 02 Jan 2012 15:23:17 +0200, Tomi Ollila wrote: > On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote: > > On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote: > > > > > Personally I would like to be able to customize the hello screen to > > > remove the search box. I find it confu

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-02 Thread Tomi Ollila
On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote: > On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote: > > > Personally I would like to be able to customize the hello screen to > > remove the search box. I find it confusing that that 's' jumps to the > > search box there, and everywhe

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-31 Thread David Edmondson
On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote: > Would it be a suitable compromise to bind 's' to notmuch-search (the > mini-buffer search) also in notmuch-hello, while leaving the search > box there with a common history? > > I'm not sure moving the point to search box needs a keybinding

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-31 Thread David Bremner
On Sat, 31 Dec 2011 14:42:47 +0200, Jani Nikula wrote: > Would it be a suitable compromise to bind 's' to notmuch-search (the > mini-buffer search) also in notmuch-hello, while leaving the search box > there with a common history? That would be fine for me. But other people might find it weird I

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-31 Thread Jani Nikula
On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote: > On Fri, 30 Dec 2011 10:44:28 +, David Edmondson wrote: > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > > > Were there actual complaints about the usability of the current > > approach? > > > > I much preferred your al

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread Aaron Ecay
On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote: > Personally I would like to be able to customize the hello screen to > remove the search box. I find it confusing that that 's' jumps to the > search box there, and everywhere else brings up the mini-buffer. +1. I rarely use notmuch-hello

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread David Edmondson
On Fri, 30 Dec 2011 10:43:37 -0400, David Bremner wrote: > On Fri, 30 Dec 2011 10:44:28 +, David Edmondson wrote: > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > > > Were there actual complaints about the usability of the current > > approach? > > > > I much preferred your al

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread David Bremner
On Fri, 30 Dec 2011 10:44:28 +, David Edmondson wrote: > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > Were there actual complaints about the usability of the current > approach? > > I much preferred your alternative approach (merging the history while > leaving the UI alone).

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread David Edmondson
On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin wrote: > Before the change, there were two ways to do search in Emacs UI: > search widget in notmuch-hello buffer and `notmuch-search' function > bound to "s". Internally, notmuch-hello search widget uses > `notmuch-search' function. But it u