Re: STYLE and uncrustify

2019-06-11 Thread Tomi Ollila
tify thinks yes, STYLE >is silent, the codebase says mostly yes. I think update STYLE to >match uncrustify here. agreed. > 2) Should there be a space after '!'? Uncrustify says yes, STYLE is >silent, the codebase is inconsistent. Updating STYLE would be the >easy thing

Re: STYLE and uncrustify

2019-06-10 Thread Daniel Kahn Gillmor
crustify thinks yes, STYLE >is silent, the codebase says mostly yes. I think update STYLE to >match uncrustify here. > > 2) Should there be a space after '!'? Uncrustify says yes, STYLE is >silent, the codebase is inconsistent. Updating STYLE would be the >easy th

STYLE and uncrustify

2019-06-07 Thread David Bremner
I'm pondering running uncrustify on all/most of the notmuch codebase, but I noticed a few things that uncrustify does are either not documented in STYLE, or maybe contradicted. 1) Should block comments start with '*' ? Uncrustify thinks yes, STYLE is silent, the codebase says mostly yes. I