revised patch for gmime init, with test.

2012-01-14 Thread Pieter Praet
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner > wrote: > > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet > > wrote: > > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > > > wrote: > > > > > with differing hashes), this

revised patch for gmime init, with test.

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote: > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > > wrote: > > > with differing hashes), this has the potential of causing confusion > > and/or quite some extra work when

Re: revised patch for gmime init, with test.

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner da...@tethera.net wrote: On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet pie...@praet.org wrote: On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner da...@tethera.net wrote: with differing hashes), this has the potential of causing confusion

Re: revised patch for gmime init, with test.

2012-01-14 Thread Pieter Praet
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner da...@tethera.net wrote: On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner da...@tethera.net wrote: On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet pie...@praet.org wrote: On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner da...@tethera.net

revised patch for gmime init, with test.

2012-01-13 Thread David Bremner
On Fri, 13 Jan 2012 12:52:48 -0800, Jameson Graef Rollins wrote: > > Doesn't everything need to be merged into master eventually anyway? It > seems to me that unless it's a change that very narrowly targeting an > issue in a release branch that is not an issue in master, every patch > will

revised patch for gmime init, with test.

2012-01-13 Thread Jameson Graef Rollins
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner wrote: > I thought about this a bit more, and I agree that at least the release > candidates (basically anything tagged on branch release) ought to be > merged back to master. Since any series of bugfix patches seems to be > cause for a new

revised patch for gmime init, with test.

2012-01-13 Thread David Bremner
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote: > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > > wrote: > > > with differing hashes), this has the potential of causing confusion > > and/or quite some extra work when

Re: revised patch for gmime init, with test.

2012-01-13 Thread David Bremner
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner da...@tethera.net wrote: On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet pie...@praet.org wrote: On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner da...@tethera.net wrote: with differing hashes), this has the potential of causing confusion

Re: revised patch for gmime init, with test.

2012-01-13 Thread Jameson Graef Rollins
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner da...@tethera.net wrote: I thought about this a bit more, and I agree that at least the release candidates (basically anything tagged on branch release) ought to be merged back to master. Since any series of bugfix patches seems to be cause for

Re: revised patch for gmime init, with test.

2012-01-13 Thread David Bremner
On Fri, 13 Jan 2012 12:52:48 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Doesn't everything need to be merged into master eventually anyway? It seems to me that unless it's a change that very narrowly targeting an issue in a release branch that is not an issue in master,

revised patch for gmime init, with test.

2012-01-12 Thread David Bremner
On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote: > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner > wrote: > with differing hashes), this has the potential of causing confusion > and/or quite some extra work when debugging using git-bisect(1), so > I'd like to propose that bugfixes

revised patch for gmime init, with test.

2012-01-12 Thread Pieter Praet
On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner wrote: > It turns out that our existing (trivial) python test is enough to > catch this bug, but the corpus needs to be augmented. This > augmentation is a bit intrusive so I'm thinking of cherry-picking only > the actual fix to the release

Re: revised patch for gmime init, with test.

2012-01-12 Thread David Bremner
On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet pie...@praet.org wrote: On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner da...@tethera.net wrote: with differing hashes), this has the potential of causing confusion and/or quite some extra work when debugging using git-bisect(1), so I'd like

revised patch for gmime init, with test.

2012-01-01 Thread David Bremner
It turns out that our existing (trivial) python test is enough to catch this bug, but the corpus needs to be augmented. This augmentation is a bit intrusive so I'm thinking of cherry-picking only the actual fix to the release branch. Unfortunately the test message is 8 bit, so it may be encoded

revised patch for gmime init, with test.

2011-12-31 Thread David Bremner
It turns out that our existing (trivial) python test is enough to catch this bug, but the corpus needs to be augmented. This augmentation is a bit intrusive so I'm thinking of cherry-picking only the actual fix to the release branch. Unfortunately the test message is 8 bit, so it may be encoded