[Nouveau] [PATCH] Reflow logic to make it easier to follow

2010-07-29 Thread Tomas Carnecky
The control flow was: if (!y) { ppix = ... } if (y) { ... } else if (x) { use ppix for something } else { use ppix for something } Merge the if(!y) block with the two else branches. This avoids a false-positive in the clang static analyzer, it can't know that !y and x are mutually exclus

Re: [Nouveau] [patch] nouveau: unwind on load errors

2010-07-29 Thread Marcin Slusarz
On Thu, Jul 29, 2010 at 08:02:31PM +0200, Dan Carpenter wrote: > nouveau_load() just returned directly if there was an error instead of > releasing resources. > > Signed-off-by: Dan Carpenter Patch looks good, but could you base it on top of nouveau tree? git://anongit.freedesktop.org/nouveau/