NV_PRINTK is a macro that adds the "%s: ", nouveau_cli.name to
logging output.
Save a few KB by creating a specific function to add that name
and change the users of theh NV_PRINTK macros to use the new
logging function.
(size -t drivers/gpu/drm/nouveau/built-in.a x86/64 defconfig with nouveau)
Use a more common logging style and reduce object size by calling
the nouveau_cli_printk function.
(size -t drivers/gpu/drm/nouveau/built-in.a x86/64 defconfig with nouveau)
textdata bss dec hex filename
1736437 1084841048 1845969 1c2ad1 (TOTALS) (new)
1737254 108484
Reduces object size ~4kb
Joe Perches (2):
drm/nouveau: Add new logging function nv_cli_printk
drm/nouveau: Convert NV_PRINTK macros and uses to new nv_cli_ macros
drivers/gpu/drm/nouveau/nouveau_abi16.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_chan.c | 12 +++
On Thu, 2018-08-30 at 20:36 +0300, Ville Syrjälä wrote:
> On Thu, Aug 30, 2018 at 01:16:28PM -0400, Lyude Paul wrote:
> > It looks like that when we moved over to using
> > drm_connector_for_each_possible_encoder() in nouveau, that one rather
> > important part of this function got dropped by
On Thu, Aug 30, 2018 at 01:16:28PM -0400, Lyude Paul wrote:
> It looks like that when we moved over to using
> drm_connector_for_each_possible_encoder() in nouveau, that one rather
> important part of this function got dropped by accident:
>
> /* Right v here */
> for (i
It looks like that when we moved over to using
drm_connector_for_each_possible_encoder() in nouveau, that one rather
important part of this function got dropped by accident:
/* Right v here */
for (i = 0; nv_encoder = NULL, i < DRM_CONNECTOR_MAX_ENCODER; i++) {
Am 30.08.2018 um 08:45 schrieb Christian König:
[...]
>> or create their private instance.
>
> That doesn't sounds good. Drivers should not be allowed to create their
> own private instance of that.
OK, will be changed in the patchset.
Best regards
Thomas
>
> Thanks for doing this,
>
On Thu, Aug 30, 2018 at 03:41:43PM +0800, Daniel Drake wrote:
> On Tue, Aug 28, 2018 at 5:57 PM, Peter Wu wrote:
> > Just to be sure, after "sleep", do both devices report "suspended" in
> > /sys/bus/pci/devices/:00:1c.0/power/runtime_status
> >
On Tue, Aug 28, 2018 at 5:57 PM, Peter Wu wrote:
> Just to be sure, after "sleep", do both devices report "suspended" in
> /sys/bus/pci/devices/:00:1c.0/power/runtime_status
> /sys/bus/pci/devices/:01:00.0/power/runtime_status
>
> and was this reproduced with a recent mainline kernel with
Hi Lyude,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.19-rc1 next-20180828]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
There's no actual reason we pass the connector ID instead of a pointer
to the connector itself, and we're going to need the entire connector
(but only temporarily) in order to name MST debugfs folders properly
since connector IDs can't be looked up until the driver has been
registered with
This is the next version of my patch series for teaching DRM how to
automatically create debugfs nodes for drivers with MST topologies. This
was originally intended just for nouveau, but has since been expanded to
all DRM drivers.
Changes since previous version:
- Fix documentation error that
There's no actual reason we pass the connector ID instead of a pointer
to the connector itself, and we're going to need the entire connector
(but only temporarily) in order to name MST debugfs folders properly
since connector IDs can't be looked up until the driver has been
registered with
Hi Christian,
I just wanted to ask if there's something else required to get this
patch set reviewed and landed.
On top of these two patches, I have a patch set that replaces the
driver-specific global-bo-and-mem combos with a single struct ttm_global
structure. It further merges struct
Hello,
I'm new here, and I hope I can get any help. At first I thought this is
a support mailing list, but it looks more like one for developers.
I'm using Nouveau in ubuntu bionic. My problem is, when I connect a
second Monitor to my Laptop on DVI-D connector, the monitor is not
detected,
Hi Thomas,
Am 30.08.2018 um 08:34 schrieb Thomas Zimmermann:
Hi Christian,
I just wanted to ask if there's something else required to get this
patch set reviewed and landed.
I just need to find some time to review them.
On top of these two patches, I have a patch set that replaces the
This is the next version of my patch series for teaching DRM how to
automatically create debugfs nodes for drivers with MST topologies. This
was originally intended just for nouveau, but has since been expanded to
all DRM drivers.
Cc: Maarten Lankhorst
Cc: Daniel Stone
Lyude Paul (4):
17 matches
Mail list logo