Re: [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

2019-06-14 Thread John Hubbard
On 6/13/19 2:43 AM, Christoph Hellwig wrote: > Keep the physical address allocation that hmm_add_device does with the > rest of the resource code, and allow future reuse of it without the hmm > wrapper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/ioport.h | 2 ++ > kernel/resourc

Re: [Nouveau] dev_pagemap related cleanups

2019-06-14 Thread Dan Williams
On Thu, Jun 13, 2019 at 11:14 PM Christoph Hellwig wrote: > > On Thu, Jun 13, 2019 at 11:27:39AM -0700, Dan Williams wrote: > > It also turns out the nvdimm unit tests crash with this signature on > > that branch where base v5.2-rc3 passes: > > How do you run that test? This is the unit test suit

Re: [PATCH 06/59] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-14 Thread Sam Ravnborg
Hi Daniel. Minor nitpick.. > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 65d599065709..4fd09a9ad67a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -3193,7 +3193,7 @@ static struct drm_driver driver = { >

[Nouveau] [Bug 110830] [nouveau] GeForce GTX 1660 Ti (mobile) not supported (NV168/TU116)

2019-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110830 --- Comment #13 from Ilia Mirkin --- (In reply to Marcin Zajaczkowski from comment #12) > [1]. Is it just needed to add a new entry for my GTX 1660 in nv_driver.c? Mmmmaybe. You'd have to kill Accel for it too, since none of the other functions

[Nouveau] [Bug 110830] [nouveau] GeForce GTX 1660 Ti (mobile) not supported (NV168/TU116)

2019-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110830 --- Comment #12 from Marcin Zajaczkowski --- Thanks for your explanations. In the meantime, I've tried (recommended) KWin with LXQT (both XRender nad OpenGL), but with no effects. I will try to explore it at the Xorg/Window Manager side (or sti

[Nouveau] [PATCH 52/59] drm/nouveau: Fill out gem_object->resv

2019-06-14 Thread Daniel Vetter
That way we can ditch our gem_prime_res_obj implementation. Since ttm absolutely needs the right reservation object all the boilerplate is already there and we just have to wire it up correctly. Note that gem/prime doesn't care when we do this, as long as we do it before the bo is registered and s

[Nouveau] [PATCH 23/59] drm/nouveau: Drop drm_gem_prime_export/import

2019-06-14 Thread Daniel Vetter
They're the default. Aside: Would be really nice to switch the others over to drm_gem_object_funcs. Signed-off-by: Daniel Vetter Cc: Ben Skeggs Cc: nouveau@lists.freedesktop.org --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouve

[PATCH 06/59] drm/prime: Actually remove DRIVER_PRIME everywhere

2019-06-14 Thread Daniel Vetter
Split out to make the functional changes stick out more. v2: amdgpu gained DRIVER_SYNCOBJ_TIMELINE. v3: amdgpu lost DRIVER_SYNCOBJ_TIMELINE. Signed-off-by: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc: etna...@lists.freedesktop.org Cc: freedr...@lists.freedesktop.org Cc: intel-...@lists.f

[PATCH v2] drm/nouveau/dmem: missing mutex_lock in error path

2019-06-14 Thread Ralph Campbell
In nouveau_dmem_pages_alloc(), the drm->dmem->mutex is unlocked before calling nouveau_dmem_chunk_alloc() as shown when CONFIG_PROVE_LOCKING is enabled: [ 1294.871933] = [ 1294.876656] WARNING: bad unlock balance detected! [ 1294.881375] 5.2.0-rc3+ #5 Not tainte

Re: [Nouveau] [PATCH] drm/nouveau/dmem: missing mutex_lock in error path

2019-06-14 Thread John Hubbard
On 6/14/19 10:39 AM, Ralph Campbell wrote: > On 6/13/19 5:49 PM, John Hubbard wrote: >> On 6/13/19 5:11 PM, Ralph Campbell wrote: ... >> Actually, the pre-existing code is a little concerning. Your change preserves >> the behavior, but it seems questionable to be doing a "return 0" (whether >> via

Re: [PATCH] drm/nouveau/dmem: missing mutex_lock in error path

2019-06-14 Thread Ralph Campbell
On 6/13/19 5:49 PM, John Hubbard wrote: On 6/13/19 5:11 PM, Ralph Campbell wrote: In nouveau_dmem_pages_alloc(), the drm->dmem->mutex is unlocked before calling nouveau_dmem_chunk_alloc(). Reacquire the lock before continuing to the next page. Signed-off-by: Ralph Campbell --- I found this

[Nouveau] [Bug 110830] [nouveau] GeForce GTX 1660 Ti (mobile) not supported (NV168/TU116)

2019-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110830 --- Comment #11 from Ilia Mirkin --- (In reply to Marcin Zajaczkowski from comment #10) > (In reply to Ilia Mirkin from comment #9) > > xrandr --setprovideroutputsource 1 0 > > > > which should allow you to drive on your NVIDIA GPU's outputs by

[Nouveau] [Bug 110830] [nouveau] GeForce GTX 1660 Ti (mobile) not supported (NV168/TU116)

2019-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110830 --- Comment #10 from Marcin Zajaczkowski --- (In reply to Ilia Mirkin from comment #9) > (In reply to Marcin Zajaczkowski from comment #7) > > > Providers: number : 2 > > > Provider 0: id: 0x6b cap: 0xf, Source Output, Sink Output, Source > > >

[Nouveau] [PATCH] drm: don't set the pci power state if the pci subsystem handles the ACPI bits

2019-06-14 Thread Karol Herbst
When looking into the runpm issues, the first workaround I came up with was setting the PCIe link speed to whatever it was before running devinit on the GPU. As I was playing around with my patches today, it seems like that just reworking the runpm bits itself fixed it on my machine as well. Hopef