[Nouveau] [PATCH v2] drm/nouveau/kms/nv50-: Correct size checks for cursors

2021-03-18 Thread Lyude Paul
Found this while trying to make some changes to the kms_cursor_crc test. curs507a_acquire checks that the width and height of the cursor framebuffer are equal (asyw->image.{w,h}). This isn't entirely correct though, as the height of the cursor can be larger than the size of the cursor, as long as

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: Check plane size for cursors, not fb size

2021-03-18 Thread Lyude Paul
On Thu, 2021-03-18 at 18:13 -0400, Ilia Mirkin wrote: > On Thu, Mar 18, 2021 at 5:56 PM Lyude Paul wrote: > > > > Found this while trying to make some changes to the kms_cursor_crc test. > > curs507a_acquire checks that the width and height of the cursor framebuffer > > are equal

[Nouveau] [PATCH i-g-t v2 0/2] tests/kms_cursor_crc: Test 32x32 cursors

2021-03-18 Thread Lyude
From: Lyude Paul Older nvidia hardware only has 32x32 and 64x64 cursors, so we want to make sure to test 32x32 cursors. Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline Lyude Paul (2): tests/kms_cursor_crc: Probe kernel for cursor size support tests/kms_cursor_crc: Test 32x32 cursors

[Nouveau] [PATCH i-g-t v2 2/2] tests/kms_cursor_crc: Test 32x32 cursors

2021-03-18 Thread Lyude
From: Lyude Paul Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at least test both of them. Signed-off-by: Lyude Paul Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline --- tests/kms_cursor_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Nouveau] [PATCH i-g-t v2 1/2] tests/kms_cursor_crc: Probe kernel for cursor size support

2021-03-18 Thread Lyude
From: Lyude Paul Currently we just assume that every cursor size up to data->cursor_max_w/h will be supported by the driver, and check for support of nonsquare cursors by checking if we're running on u815 and if so, which variant of intel hardware we're running on. This isn't really ideal as

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: Check plane size for cursors, not fb size

2021-03-18 Thread Ilia Mirkin
On Thu, Mar 18, 2021 at 5:56 PM Lyude Paul wrote: > > Found this while trying to make some changes to the kms_cursor_crc test. > curs507a_acquire checks that the width and height of the cursor framebuffer > are equal (asyw->image.{w,h}). This is actually wrong though, as we only > want to be

[Nouveau] [PATCH] drm/nouveau/kms/nv50-: Check plane size for cursors, not fb size

2021-03-18 Thread Lyude Paul
Found this while trying to make some changes to the kms_cursor_crc test. curs507a_acquire checks that the width and height of the cursor framebuffer are equal (asyw->image.{w,h}). This is actually wrong though, as we only want to be concerned that the actual width/height of the plane are the same.

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

2021-03-18 Thread Lyude Paul
On Thu, 2021-03-18 at 14:39 +0200, Ville Syrjälä wrote: > On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote: > > On 18/03/2021 00:45, Lyude wrote: > > > From: Lyude Paul > > > > > > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at > > > least test both of them.

Re: [Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library

2021-03-18 Thread Lyude Paul
On Thu, 2021-03-18 at 11:15 +0200, Petri Latvala wrote: > On Thu, Mar 18, 2021 at 09:06:29AM +0200, Martin Peres wrote: > > On 18/03/2021 00:38, Lyude wrote: > > > diff --git a/include/drm-uapi/drm_fourcc.h b/include/drm-uapi/drm_fourcc.h > > > index a7bc058c..87c87485 100644 > > > ---

Re: [Nouveau] [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-18 Thread Daniel Vetter
On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > > > On Thu, 11 Mar 2021, Daniel Vetter wrote: > > > > > > > On Mon, Mar 08, 2021 at 09:19:32AM +, Lee Jones wrote: > > > > > On Fri,

Re: [Nouveau] [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb

2021-03-18 Thread Ville Syrjälä
On Wed, Mar 17, 2021 at 06:49:46PM -0400, Lyude wrote: > From: Lyude Paul > > It doesn't look like that this is used by i915 for anything these days, so > let's just remove this while we're at it. I wa scurious why this is here so dug around a bit. It was added in commit 18d0b1efb875

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

2021-03-18 Thread Ville Syrjälä
On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote: > On 18/03/2021 00:45, Lyude wrote: > > From: Lyude Paul > > > > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at > > least test both of them. > > This adds 36 subtests, which take about 1s in average. So the

Re: [Nouveau] [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work

2021-03-18 Thread Petri Latvala
On Wed, Mar 17, 2021 at 06:49:42PM -0400, Lyude wrote: > From: Lyude Paul > > These are just a couple of small fixes that didn't seem important > enough to stick in their own patch series, but were various issues with > igt that I found along the way during my recent nouveau igt work. > > Cc:

Re: [Nouveau] [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die()

2021-03-18 Thread Petri Latvala
On Wed, Mar 17, 2021 at 06:49:43PM -0400, Lyude wrote: > From: Lyude Paul > > Noticed this while working on some nouveau tests, if we use igt_assert_eq() > here we'll output both the expected and returned value instead of just the > expected value. igt_assert_eq stuffs x into an int so there's

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

2021-03-18 Thread Petri Latvala
On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote: > On 18/03/2021 00:45, Lyude wrote: > > From: Lyude Paul > > > > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at > > least test both of them. > > This adds 36 subtests, which take about 1s in average. So the

Re: [Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library

2021-03-18 Thread Petri Latvala
On Wed, Mar 17, 2021 at 06:38:27PM -0400, Lyude wrote: > From: Lyude Paul > > This introduces the igt_nouveau library, which enables support for tiling > formats on nouveau, along with accelerated clears for allocated bos in VRAM > using the dma-copy engine present on Nvidia hardware since

Re: [Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library

2021-03-18 Thread Petri Latvala
On Thu, Mar 18, 2021 at 09:06:29AM +0200, Martin Peres wrote: > On 18/03/2021 00:38, Lyude wrote: > > diff --git a/include/drm-uapi/drm_fourcc.h b/include/drm-uapi/drm_fourcc.h > > index a7bc058c..87c87485 100644 > > --- a/include/drm-uapi/drm_fourcc.h > > +++ b/include/drm-uapi/drm_fourcc.h > >

Re: [Nouveau] [igt-dev] [PATCH i-g-t 0/3] tests/kms_color: Fixup for nouveau

2021-03-18 Thread Martin Peres
On 18/03/2021 00:42, Lyude wrote: From: Lyude Paul This patch series just introduces a small drive-by cleanup for kms_color, and fixes the kms_color test so that it works correctly on nouveau. Note that the invalid LUT/gamma tests will likely currently fail, but I'm going to be submitting some

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes

2021-03-18 Thread Martin Peres
On 18/03/2021 00:44, Lyude wrote: From: Lyude Paul Currently, nouveau doesn't support having a CRTC without a primary FB set. We won't reject such configurations, but the behavior is undefined which will cause CRCs to become undefined. So, avoid clearing the primary FB while we're testing

Re: [Nouveau] [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work

2021-03-18 Thread Martin Peres
On 18/03/2021 00:49, Lyude wrote: From: Lyude Paul These are just a couple of small fixes that didn't seem important enough to stick in their own patch series, but were various issues with igt that I found along the way during my recent nouveau igt work. Cc: Martin Peres Cc: Jeremy Cline

Re: [Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library

2021-03-18 Thread Martin Peres
On 18/03/2021 00:38, Lyude wrote: From: Lyude Paul This introduces the igt_nouveau library, which enables support for tiling formats on nouveau, along with accelerated clears for allocated bos in VRAM using the dma-copy engine present on Nvidia hardware since Tesla. Typically the latter would

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

2021-03-18 Thread Martin Peres
On 18/03/2021 00:45, Lyude wrote: From: Lyude Paul Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at least test both of them. This adds 36 subtests, which take about 1s in average. So the runtime is not significantly increased on the Intel side. It also seems that