Re: [Nouveau] [PATCH] drm: nouveau: fix nouveau_backlight compiling error

This needs a fixes tag: Fixes: 6eca310e8924 ("drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau") with that fixed: Reviewed-by: Lyude Paul On Tue, 2021-06-15 at 11:16 +0800, Chen Jiahao wrote: > There is a compiling error in disp.c while not selecting > CONFIG_DRM_NO

Re: [Nouveau] [PATCH v10 07/10] mm: Device exclusive memory access

On Saturday, 12 June 2021 1:01:42 AM AEST Peter Xu wrote: > On Fri, Jun 11, 2021 at 01:43:20PM +1000, Alistair Popple wrote: > > On Friday, 11 June 2021 11:00:34 AM AEST Peter Xu wrote: > > > On Fri, Jun 11, 2021 at 09:17:14AM +1000, Alistair Popple wrote: > > > > On Friday, 11 June 2021 9:04:19 AM

Re: [Nouveau] [PATCH] drm/nouveau: fix dma_address check for CPU/GPU sync

On Monday 14 June 2021 13:05:17 Christian König wrote: > AGP for example doesn't have a dma_address array. > > Signed-off-by: Christian König Fixes NULL pointer dereference in nouveau_bo_sync_for_device on AGP cards. Tested-by: Ondrej Zary > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-

Re: [Nouveau] nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device

Am 11.06.21 um 20:23 schrieb Ondrej Zary: On Friday 11 June 2021 14:38:18 Christian König wrote: Am 10.06.21 um 19:59 schrieb Christian König: Am 10.06.21 um 19:50 schrieb Ondrej Zary: [SNIP] I can't see how this is called from the nouveau code, only possibility I see is that it is maybe ca

Re: [Nouveau] [PATCH] drm/nouveau/core/object: fix double free on error in nvkm_ioctl_new()

On Mon, Jun 14, 2021 at 01:43:27PM +0300, Dan Carpenter wrote: > If nvkm_object_init() fails then we should not call nvkm_object_fini() > because it results in calling object->func->fini(object, suspend) twice. > Once inside the nvkm_object_init() function and once inside the > nvkm_object_fini() f

[Nouveau] [PATCH] drm/nouveau: fix dma_address check for CPU/GPU sync

AGP for example doesn't have a dma_address array. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 3e09df0472ce..170ab

[Nouveau] [PATCH] drm/nouveau/core/object: fix double free on error in nvkm_ioctl_new()

If nvkm_object_init() fails then we should not call nvkm_object_fini() because it results in calling object->func->fini(object, suspend) twice. Once inside the nvkm_object_init() function and once inside the nvkm_object_fini() function. Fixes: fbd58ebda9c8 ("drm/nouveau/object: merge with handle")