Re: [Nouveau] [PATCH v10 07/10] mm: Device exclusive memory access

2021-06-15 Thread Alistair Popple
On Wednesday, 16 June 2021 2:25:09 AM AEST Peter Xu wrote: > On Tue, Jun 15, 2021 at 01:08:11PM +1000, Alistair Popple wrote: > > On Saturday, 12 June 2021 1:01:42 AM AEST Peter Xu wrote: > > > On Fri, Jun 11, 2021 at 01:43:20PM +1000, Alistair Popple wrote: [...] > > > Do you think we can

[Nouveau] [PATCH] drm/nouveau: fix double free in nouveau_gem_new()

2021-06-15 Thread Dan Carpenter
The ttm_bo_init_reserved() function calls ttm_bo_put(bo) which calls nouveau_bo_del_ttm() which frees the "nvbo.bo" so the nouveau_bo_ref() call leads to a double free. Fixes: 019cbd4a4feb ("drm/nouveau: Initialize GEM object before TTM object") Signed-off-by: Dan Carpenter --- This fix is

Re: [Nouveau] [PATCH -next] drm/nouveau: Remove set but not used variable 'dev'

2021-06-15 Thread Christian König
Am 25.05.21 um 10:25 schrieb Baokun Li: Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/nouveau/nouveau_bo.c: In function 'nouveau_ttm_tt_populate': drivers/gpu/drm/nouveau/nouveau_bo.c:1258:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable]