Re: [Nouveau] [PATCH] dispnv50: atom: fix an incorrect NULL check on list iterator

2022-04-02 Thread Xiaomeng Tong
on Sun, 27 Mar 2022 16:59:28 +0100, Emil Velikov wrote: > On Sun, 27 Mar 2022 at 08:39, Xiaomeng Tong wrote: > > > > The bug is here: > > return encoder; > > > > The list iterator value 'encoder' will *always* be set and non-NULL > > by drm_for_each_encoder_mask(), so it is incorrect to

[Nouveau] [PATCH] clk: base: fix an incorrect NULL check on list iterator

2022-04-02 Thread Xiaomeng Tong
The bug is here: if (nvkm_cstate_valid(clk, cstate, max_volt, clk->temp)) return cstate; The list iterator value 'cstate' will *always* be set and non-NULL by list_for_each_entry_from_reverse(), so it is incorrect to assume that the iterator value will be unchanged if the

Re: [Nouveau] [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit

2022-04-02 Thread Martin K. Petersen
Randy, > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, or > an initcall_debug log. Applied to 5.18/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering