Re: [Nouveau] [PATCH] drm/nouveau/mmu: Fix a typo

2022-06-21 Thread Joe Perches
On Wed, 2022-06-22 at 09:52 +0800, Zhang Jiaming wrote: > There is a typo in comments. Change 'neeed' to 'need'. [] > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c [] > @@ -280,7 +280,7 @@ nvkm_vmm_unref_ptes(struct nvkm_vmm_iter *it,

Re: [Nouveau] [PATCH] drm/nouveau/Kconfig: Drop duplicate "select ACPI_VIDEO"

2022-06-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Also, you have my permission to push this to drm-misc-next. On Mon, 2022-06-20 at 11:46 +0200, Hans de Goede wrote: > Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" > statements: > > select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE &&

Re: [Nouveau] [PATCH] drm/nouveau/mmu: drop unexpected word "the" in the comments

2022-06-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a moment On Tue, 2022-06-21 at 21:39 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > line: 1051 >  * have the the

Re: [Nouveau] [PATCH 01/14] ACPI: video: Add a native function parameter to acpi_video_get_backlight_type()

2022-06-21 Thread Hans de Goede
Hi, On 5/19/22 11:02, Jani Nikula wrote: > On Wed, 18 May 2022, Hans de Goede wrote: >> Hi, >> >> On 5/18/22 10:55, Jani Nikula wrote: >>> On Tue, 17 May 2022, Hans de Goede wrote: ATM on x86 laptops where we want userspace to use the acpi_video backlight device we often register both