Re: [PATCH] nouveau: fix devinit paths to only handle display on GSP.

2024-04-08 Thread Dave Airlie
On Mon, 8 Apr 2024 at 23:05, Timur Tabi wrote: > > On Mon, 2024-04-08 at 16:42 +1000, Dave Airlie wrote: > > This reverts: > > nouveau/gsp: don't check devinit disable on GSP. > > and applies a further fix. > > > > It turns out the open gpu driver, checks this register, but only for > > display.

[PATCH] nouveau: fix instmem race condition around ptr stores

2024-04-08 Thread Dave Airlie
From: Dave Airlie Running a lot of VK CTS in parallel against nouveau, once every few hours you might see something like this crash. BUG: kernel NULL pointer dereference, address: 0008 PGD 800114e6e067 P4D 800114e6e067 PUD 109046067 PMD 0 Oops: [#1] PREEMPT SMP PTI CPU:

Re: [PATCH 1/2] drm/nouveau/kms/nv50-: Disable AUX bus for disconnected DP ports

2024-04-08 Thread Dave Airlie
On Fri, 5 Apr 2024 at 09:37, Lyude Paul wrote: > > GSP has its own state for keeping track of whether or not a given display > connector is plugged in or not, and enforces this state on the driver. In > particular, AUX transactions on a DisplayPort connector which GSP says is > disconnected can

Re: [PATCH 4/5] drm/nouveau: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2024-04-08 at 22:06 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: nouveau@lists.freedesktop.org > Signed-off-by:

[PATCH 4/5] drm/nouveau: Use drm_crtc_vblank_crtc()

2024-04-08 Thread Ville Syrjala
From: Ville Syrjälä Replace the open coded drm_crtc_vblank_crtc() with the real thing. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouveau@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- 1 file changed, 1 insertion(+), 1

[linux-next:master] BUILD REGRESSION 11cb68ad52ac78c81e33b806b531f097e68edfa2

2024-04-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 11cb68ad52ac78c81e33b806b531f097e68edfa2 Add linux-next specific files for 20240408 Error/Warning: (recently discovered and may have been fixed) drivers/gpu/drm/drm_mm.c:152:1: error: unused

Re: [PATCH] drm: nv04: Add check to avoid out of bounds access

2024-04-08 Thread Danilo Krummrich
On 4/5/24 22:05, Lyude Paul wrote: On Fri, 2024-04-05 at 17:53 +0200, Danilo Krummrich wrote: On 3/31/24 08:45, Mikhail Kobuk wrote: Output Resource (dcb->or) value is not guaranteed to be non-zero (i.e. in drivers/gpu/drm/nouveau/nouveau_bios.c, in 'fabricate_dcb_encoder_table()' 'dcb->or' is

Re: [PATCH] nouveau: fix devinit paths to only handle display on GSP.

2024-04-08 Thread Timur Tabi
On Mon, 2024-04-08 at 16:42 +1000, Dave Airlie wrote: > This reverts: > nouveau/gsp: don't check devinit disable on GSP. > and applies a further fix. > > It turns out the open gpu driver, checks this register, but only for > display. > > Match that behaviour and only disable displays on turings.

Re: [PATCH] nouveau: fix devinit paths to only handle display on GSP.

2024-04-08 Thread Danilo Krummrich
On 4/8/24 08:42, Dave Airlie wrote: This reverts: nouveau/gsp: don't check devinit disable on GSP. and applies a further fix. It turns out the open gpu driver, checks this register, but only for display. Match that behaviour and only disable displays on turings. Fixes: 5d4e8ae6e57b

Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-08 Thread Hans Verkuil
On 05/04/2024 12:18, Wolfram Sang wrote: > Hello Easwar, > > On Fri, Mar 29, 2024 at 05:00:24PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix

[PATCH] nouveau: fix devinit paths to only handle display on GSP.

2024-04-08 Thread Dave Airlie
This reverts: nouveau/gsp: don't check devinit disable on GSP. and applies a further fix. It turns out the open gpu driver, checks this register, but only for display. Match that behaviour and only disable displays on turings. Fixes: 5d4e8ae6e57b ("nouveau/gsp: don't check devinit disable on