Re: MODULE_DESCRIPTION() patches with no maintainer action

2024-07-19 Thread Arnd Bergmann
On Sun, Jul 14, 2024, at 23:46, Jeff Johnson wrote: > Andrew & Greg, > > I hate to bother you with such mundane patches, but the following have been > posted for a while without any maintainer or reviewer comment or action, and > they have not yet landed in linux-next. > > What is the path forward

Re: nouveau: r535.c:1266:3: error: label at end of compound statement default: with gcc-8

2024-04-29 Thread Arnd Bergmann
On Mon, Apr 29, 2024, at 19:08, Timur Tabi wrote: > On Mon, 2024-04-29 at 17:30 +0200, Linux regression tracking (Thorsten > Leemhuis) wrote: >> TWIMC, there is another report about this in this thread (sadly some of >> its post did not make it to lore): >> >>

[PATCH] [v2] nouveau: fix function cast warning

2024-04-04 Thread Arnd Bergmann
From: Arnd Bergmann Calling a function through an incompatible pointer type causes breaks kcfi, so clang warns about the assignment: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c:73:10: error: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function

Re: [PATCH 06/12] nouveau: fix function cast warning

2024-03-26 Thread Arnd Bergmann
On Tue, Mar 26, 2024, at 16:20, Timur Tabi wrote: > On Tue, 2024-03-26 at 15:51 +0100, Arnd Bergmann wrote: >> Calling a function through an incompatible pointer type causes breaks >> kcfi, so clang warns about the assignment: >> > > ... > >> +static void of_f

[PATCH 06/12] nouveau: fix function cast warning

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann Calling a function through an incompatible pointer type causes breaks kcfi, so clang warns about the assignment: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c:73:10: error: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function

[PATCH 00/12] kbuild: enable some -Wextra warnings by default

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann This is a follow-up on a couple of patch series I sent in the past, enabling -Wextra (aside from stuff that is explicitly disabled), -Wcast-function-pointer-strict and -Wrestrict. I have tested these on 'defconfig' and 'allmodconfig' builds across all architectures, as well

[PATCH] nouveau: fix function cast warnings

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann clang-16 warns about casting between incompatible function types: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c:161:10: error: cast from 'void (*)(const struct firmware *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type

[PATCH] nouveau/svm: fix kvcalloc() argument order

2024-02-12 Thread Arnd Bergmann
From: Arnd Bergmann The conversion to kvcalloc() mixed up the object size and count arguments, causing a warning: drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_svm_fault_buffer_ctor': drivers/gpu/drm/nouveau/nouveau_svm.c:1010:40: error: 'kvcalloc' sizes specified with 'sizeof

[Nouveau] [PATCH] drm/nouveau/kms/nv50: hide unused variables

2023-09-25 Thread Arnd Bergmann
From: Arnd Bergmann After a recent change, two variables are only used in an #ifdef: drivers/gpu/drm/nouveau/dispnv50/disp.c: In function 'nv50_sor_atomic_disable': drivers/gpu/drm/nouveau/dispnv50/disp.c:1569:13: error: unused variable 'ret' [-Werror=unused-variable] 1569 | int ret

[Nouveau] [PATCH] [RESEND] drm/nouveau: remove unused tu102_gr_load() function

2023-08-03 Thread Arnd Bergmann
From: Arnd Bergmann tu102_gr_load() is completely unused and can be removed to address this warning: drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create' Another patch was sent in the meantime to mark the function static but that would just

[Nouveau] [PATCH] drm/nouveau: dispnv50: fix missing-prototypes warning

2023-05-04 Thread Arnd Bergmann
From: Arnd Bergmann nv50_display_create() is declared in another header, along with a couple of declarations that are now outdated: drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create' Fixes: ba801ef068c1 ("drm/nouveau/kms: display de

[Nouveau] [PATCH] drm/nouveau: remove unused tu102_gr_load() function

2023-05-04 Thread Arnd Bergmann
From: Arnd Bergmann tu102_gr_load() is completely unused and can be removed to address this warning: drivers/gpu/drm/nouveau/dispnv50/disp.c:2517:1: error: no previous prototype for 'nv50_display_create' Fixes: 1cd97b5490c8 ("drm/nouveau/gr/tu102-: use sw_veid_bundle_init from fir

[Nouveau] [PATCH] nouveau: fix nv50_wndw_new_() prototype

2023-05-04 Thread Arnd Bergmann
From: Arnd Bergmann gcc-13 complains about a mismatched function declaration: drivers/gpu/drm/nouveau/dispnv50/wndw.c:696:1: error: conflicting types for 'nv50_wndw_new_' due to enum/integer mismatch; have 'int(const struct nv50_wndw_func *, struct drm_device *, enum drm_plane_type, const

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-08-09 Thread Arnd Bergmann
On Mon, Aug 9, 2021 at 3:20 PM Jani Nikula wrote: > > On Sat, 24 Jul 2021, Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: > >> > >> we use the MXM_WMI in code. We also have to keep arm in mind and not > >> break stuff there.

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-08 Thread Arnd Bergmann
On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > playing around a

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-08 Thread Arnd Bergmann
On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > playing around a little bit with this, I think the original "select > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > drivers selecting and others depending on it. We could of course convert > everything over to

Re: [Nouveau] [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

2021-08-08 Thread Arnd Bergmann
On Thu, Aug 5, 2021 at 12:01 AM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 11:10 PM Arnd Bergmann wrote: > > > > On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > > > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > > > On Wed, Aug

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > In the past this only led to compilation issues. Also the small amount of > extra .text shouldn't really matter compared to the entire nouveau driver > anyway. > > select DRM_TTM_HELPER > - select BACKLIGHT_CLASS_DEVICE if

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: > > we use the MXM_WMI in code. We also have to keep arm in mind and not > break stuff there. So I will try to play around with your changes and > see how that goes. Ok, should find any randconfig build failures for arm, arm64 or x86 over the

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > >

Re: [Nouveau] [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > > > In the past this only led to compilation issues. Also the small amount o

[Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Arnd Bergmann
From: Arnd Bergmann When the backlight support is disabled, the driver fails to build: drivers/gpu/drm/nouveau/dispnv50/disp.c: In function 'nv50_sor_atomic_disable': drivers/gpu/drm/nouveau/dispnv50/disp.c:1665:59: error: 'struct nouveau_connector' has no member named 'backlight' 1665

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Arnd Bergmann
On Fri, Jul 23, 2021 at 11:25 AM Daniel Vetter wrote: > > On Fri, Jul 23, 2021 at 11:15 AM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > When the backlight support is disabled, the driver fails to build: > > > > drivers/gp

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Arnd Bergmann
On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap > > > wrote: > > > > > > what's actually the use case of compiling with > > >

[Nouveau] [PATCH] drm/nouveau/pci: rework AGP dependency

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann I noticed a warning from 'nm' when CONFIG_TRIM_UNUSED_KSYMS is set and IS_REACHABLE(CONFIG_AGP) is false: drivers/gpu/drm/nouveau/nvkm/subdev/pci/agp.o: no symbols I later found this is completely harmless and we should find a way to suppress the warning, but at that point

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-28 Thread Arnd Bergmann
On Thu, May 28, 2020 at 7:37 AM Dave Airlie wrote: > > On Thu, 28 May 2020 at 00:36, Arnd Bergmann wrote: > > > > On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > > > > > Isn't this already fixed by > > > > >

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > Isn't this already fixed by > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 Ok, I see that fixes the link error, but I when I created my fix, that did not seem like the correct solution because it

[Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
' The change seems to have been intentional, so add an explicit dependency here but allow it to still be compiled if FBDEV is completely disabled. Fixes: 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()") Signed-off-by: Arnd Bergmann --- d

Re: [Nouveau] [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Arnd Bergmann
On Fri, May 8, 2020 at 9:04 PM Jason Gunthorpe wrote: > > On Fri, May 08, 2020 at 05:05:03PM +0200, Arnd Bergmann wrote: > > On Fri, May 8, 2020 at 5:00 PM Jason Gunthorpe wrote: > > > > > > On Fri, May 08, 2020 at 04:40:09PM +0200, Arnd Bergmann wrote: > &

Re: [Nouveau] [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Arnd Bergmann
On Fri, May 8, 2020 at 5:00 PM Jason Gunthorpe wrote: > > On Fri, May 08, 2020 at 04:40:09PM +0200, Arnd Bergmann wrote: > > CONFIG_DEVICE_PRIVATE cannot be selected in configurations > > without ZONE_DEVICE: > > It is kind of unfortunate to lift dependencies from DEVICE_

[Nouveau] [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE

2020-05-08 Thread Arnd Bergmann
dependency for Nouveau to avoid broken randconfig builds. Fixes: d2c63df2242e ("mm/hmm: make CONFIG_DEVICE_PRIVATE into a select") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/nouveau/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/Kconfig b/dr

Re: [Nouveau] [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-11 Thread Arnd Bergmann
On Wed, Jan 8, 2020 at 10:15 AM Krzysztof Kozlowski wrote: > > The __force-cast that removes the __iomem here also means that > > the 'volatile' keyword could be dropped from the argument list, > > as it has no real effect any more, but then there are a few drivers > > that mark their iomem

Re: [Nouveau] [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-11 Thread Arnd Bergmann
On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be

Re: [Nouveau] [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-11 Thread Arnd Bergmann
On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be

Re: [Nouveau] [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-11 Thread Arnd Bergmann
On Wed, Jan 8, 2020 at 9:36 AM Christophe Leroy wrote: > Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : > > On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven > > wrote: > > I'll add to this one also changes to ioreadX_rep() and add another > > patch for volatile for reads and writes. I

Re: [Nouveau] [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-11 Thread Arnd Bergmann
y the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven Thanks for getting this done! R

[Nouveau] [PATCH] drm: nouveau: use larger buffer in nvif_vmm_map

2018-02-02 Thread Arnd Bergmann
ion). Fixes: 920d2b5ef215 ("drm/nouveau/mmu: define user interfaces to mmu vmm opertaions") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- Cc: Martin Sebor <mse...@gcc.gnu.org> Martin: this one is interesting, I think it qualifies as a false-positive warning that gcc

[Nouveau] [PATCH] [RESEND v2] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2018-01-16 Thread Arnd Bergmann
Adding a temporary variable to contain the divisor helps make it clear what is going on and avoids that warning. Fixes: 7632b30e4b8b ("drm/nouveau/clk: namespace + nvidia gpu names (no binary change)") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- Originally submitted on July

[Nouveau] [PATCH] drm: nouveau: use correct string length

2017-12-04 Thread Arnd Bergmann
string. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c index dde89a

[Nouveau] [PATCH] [v2] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-09-06 Thread Arnd Bergmann
Adding a temporary variable to contain the divisor helps make it clear what is going on and avoids that warning. Fixes: 7632b30e4b8b ("drm/nouveau/clk: namespace + nvidia gpu names (no binary change)") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- Originally submitted

Re: [Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-09-06 Thread Arnd Bergmann
On Wed, Sep 6, 2017 at 10:15 PM, Karol Herbst <karolher...@gmail.com> wrote: > On Wed, Sep 6, 2017 at 10:11 PM, Arnd Bergmann <a...@arndb.de> wrote: >>> but with a better name for "denominator". >> >> I don't know what M and P actually are in this

Re: [Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-09-06 Thread Arnd Bergmann
On Wed, Sep 6, 2017 at 4:20 PM, Karol Herbst wrote: >> In this instance, I think using multiplication is more intuitive >> than '&&', so I'm adding a comparison to zero instead to shut up >> the warning. To further improve readability, I also make the >> error case indented

[Nouveau] [PATCH] [RESEND] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-09-06 Thread Arnd Bergmann
"drm/nouveau/clk: namespace + nvidia gpu names (no binary change)") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- Originally submitted on July 14, but no reply. This is the same patch again. The warning is currently disabled in mainline, but I think we can turn it back on in

[Nouveau] [PATCH 1/3] backlight: always select BACKLIGHT_LCD_SUPPORT for BACKLIGHT_CLASS_DEVICE

2017-07-31 Thread Arnd Bergmann
all users of BACKLIGHT_CLASS_DEVICE also select BACKLIGHT_LCD_SUPPORT, but not all of them do. This makes the remaining ones behave like the others. It would probably be best to rework the way those two options related entirely, but for now this takes the simpler and safer approach to fix the warni

[Nouveau] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

2017-07-31 Thread Arnd Bergmann
on LCD_CLASS_DEVICE', that would clean it up some more, but it is also a more invasive change that we can do separately at some point. Arnd Arnd Bergmann (3): backlight: always select BACKLIGHT_LCD_SUPPORT for BACKLIGHT_CLASS_DEVICE ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies

[Nouveau] [PATCH 3/3] drm/etnaviv: add thermal dependency

2017-07-31 Thread Arnd Bergmann
selects 'THERMAL'. Turning this into a 'depends on' addresses the problem. For completeness, I'm also removing the redundant 'select THERMAL' from INTEL_MENLOW, so no other driver uses that statement. Fixes: bcdfb5e56dc5 ("drm/etnaviv: add etnaviv cooling device") Signed-off-by: Arn

[Nouveau] [PATCH 12/14] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2017-07-14 Thread Arnd Bergmann
"drm/nouveau/clk: namespace + nvidia gpu names (no binary change)") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt

[Nouveau] [PATCH] drm/nouveau: use proper prototype in nouveau_pmops_runtime() definition

2017-06-09 Thread Arnd Bergmann
: error: old-style function definition [-Werror=old-style-definition] Fixes: 321f5c5f2c49 ("drm/nouveau: replace multiple open-coded runpm support checks with function") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1

Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 Thread Arnd Bergmann
On Tuesday, November 8, 2016 5:07:01 PM CET Lukas Wunner wrote: > On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: > > The underlying problem is that we already have a number of other > > symbols that either have "depends on LEDS_CLASS" or > > "

Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 Thread Arnd Bergmann
On Tuesday, November 8, 2016 10:46:07 AM CET Ilia Mirkin wrote: > > diff --git a/drivers/gpu/drm/nouveau/Kconfig > > b/drivers/gpu/drm/nouveau/Kconfig > > index 78631fb61adf..715cd6f4dc31 100644 > > --- a/drivers/gpu/drm/nouveau/Kconfig > > +++ b/drivers/gpu/drm/nouveau/Kconfig > > @@ -46,6

[Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 Thread Arnd Bergmann
: add a LED driver for the NVIDIA logo") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/nouveau/Kbuild| 2 +- drivers/gpu/drm/nouveau/Kconfig | 8 drivers/gpu/drm/nouveau/nouveau_led.h | 2 +- 3 files changed, 10 insertions(+), 2 deletion

[Nouveau] [PATCH] nouveau: hide gcc-4.9 -Wmaybe-uninitialized

2016-10-24 Thread Arnd Bergmann
is correct even if the caller changed, and it avoids the warning on gcc-4.9 as well. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/g

Re: [Nouveau] [PATCH] fix:overlay: add missing header dependencies

2016-08-31 Thread Arnd Bergmann
d in disp.h, so this patch > add missing header dependencies > > Signed-off-by: Baoyou Xie <baoyou@linaro.org> > Acked-by: Arnd Bergmann <a...@arndb.de> a few general notes: - please use my a...@arndb.de address on patch submissions, not the linaro address. - f

Re: [Nouveau] [PATCH] drm/nouveau: silence warnings reported during builds with W=1

2016-08-30 Thread Arnd Bergmann
are less picky than I am though, so if they want to apply the patch as-is Acked-by: Arnd Bergmann <a...@arndb.de> Otherwise please split and resend in a few days, in case there are other comments that need to be addressed. Arnd ___ Nouveau ma

Re: [Nouveau] [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static

2016-08-30 Thread Arnd Bergmann
On Tuesday 30 August 2016, Baoyou Xie wrote: > On 30 August 2016 at 00:01, Sean Paul wrote: > > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie wrote: > > > We get 1 warning when build kernel with W=1: > > >

[Nouveau] [PATCH 4/5] drm: exynos: mark pm functions as __maybe_unused

2016-05-21 Thread Arnd Bergmann
, but some functions they call are not. This patch removes the #ifdef and instead marks the PM functions as __maybe_unused, which is a more reliable way to get it right. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: 9be7e9898444 ("drm/exynos/hdmi: clock code re-factoring")

[Nouveau] [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency

2016-05-21 Thread Arnd Bergmann
reference to `of_find_device_by_node' This adds an explicit Kconfig dependency. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 545973

[Nouveau] [PATCH 5/5] drm: remove unused dev variables

2016-05-21 Thread Arnd Bergmann
/radeon_cs.c: In function 'radeon_cs_parser_relocs': drm/radeon/radeon_cs.c:77:21: error: unused variable 'ddev' [-Werror=unused-variable] This fixes all the instances I found with ARM randconfig builds so far. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: a8ad0bd84f98 ("drm: Re

[Nouveau] [PATCH 0/5] drm: fixes for merge-window regressions

2016-05-21 Thread Arnd Bergmann
they make it into mainline. It's likely that some of these have already been fixed since this morning's linux-next, so just ignore the ones are no longer needed. Arnd Bergmann (5): headers_check: don't warn about c++ guards drm: mediatek: add CONFIG_OF dependency drm: mediatek: fixup

[Nouveau] [PATCH 1/5] headers_check: don't warn about c++ guards

2016-05-21 Thread Arnd Bergmann
10_drm.h:7: userspace cannot reference function or variable defined in the kernel This changes the headers_check.pl script to not warn about this. I'm listing the merge commit as introducing the problem, because there are several patches in this branch that each do this for one file. Signed-of

[Nouveau] [PATCH 0/5] drm: fixes for merge-window regressions

2016-05-21 Thread Arnd Bergmann
they make it into mainline. It's likely that some of these have already been fixed since this morning's linux-next, so just ignore the ones are no longer needed. [resending because of missing Cc list for the actual patches, sorry about that] Arnd Bergmann (5): headers_check: don't warn about c

[Nouveau] [PATCH 3/5] drm: mediatek: fixup drm_gem_object_lookup API change

2016-05-21 Thread Arnd Bergmann
' from incompatible pointer type [-Werror=incompatible-pointer-types] obj = drm_gem_object_lookup(dev, file_priv, handle); This fixes the new caller as well. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: a8ad0bd84f98 ("drm: Remove unused drm_device from drm_gem_object_lookup()&quo