Re: [Nouveau] Logo Nouveau

2014-11-17 Thread Christian Costa
Hi Valeria, Very nice logo! Nice job! I like the ideas and the font. :) Just few remarks about the visual appearance: - A horizontally centered penguin would be better as the left part of the n appears thiner than the right one - The bottom line of the e appears a little short to me Thanks

[Nouveau] [PATCH envytools] nvbios: Add missing null byte to string read from file.

2014-08-31 Thread Christian Costa
--- nvbios/nvbios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nvbios/nvbios.c b/nvbios/nvbios.c index f7aafe3..28e62ad 100644 --- a/nvbios/nvbios.c +++ b/nvbios/nvbios.c @@ -774,11 +774,12 @@ int set_strap_from_string(const char* strap_s) int

[Nouveau] [PATCH envytools] nvamemtiming: Handle target initial case when iterating values

2014-08-31 Thread Christian Costa
Otherwise some values are not tested at all. --- nva/set_timings.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nva/set_timings.c b/nva/set_timings.c index 6cd831c..7a8f845 100644 --- a/nva/set_timings.c +++ b/nva/set_timings.c @@ -408,7 +408,7 @@ static void

[Nouveau] [PATCH envytools] nvamemtiming: Update usage.

2014-08-31 Thread Christian Costa
--- nva/nvamemtiming.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/nva/nvamemtiming.c b/nva/nvamemtiming.c index 4468f81..75c6e49 100644 --- a/nva/nvamemtiming.c +++ b/nva/nvamemtiming.c @@ -51,6 +51,8 @@ void usage(int argc, char **argv) fprintf(stderr, \t-e: Only modify the

Re: [Nouveau] [PATCH envytools] nvamemtiming: Handle target initial case when iterating values

2014-08-31 Thread Christian Costa
Le 31/08/2014 15:12, Martin Peres a écrit : On 31/08/2014 15:00, Christian Costa wrote: Otherwise some values are not tested at all. I would rather have a warning than the program doing stuff behind my back. This is a dev tool, dumb == good ;) But why didn't you call it Dumb mode rather

Re: [Nouveau] [PATCH envytools] nvamemtiming: Handle target initial case when iterating values

2014-08-31 Thread Christian Costa
Le 31/08/2014 16:23, Martin Peres a écrit : On 31/08/2014 16:19, Christian Costa wrote: Le 31/08/2014 16:11, Martin Peres a écrit : On 31/08/2014 16:01, Christian Costa wrote: Le 31/08/2014 15:12, Martin Peres a écrit : On 31/08/2014 15:00, Christian Costa wrote: Otherwise some values

Re: [Nouveau] [PATCH envytools] nvamemtiming: Handle target initial case when iterating values

2014-08-31 Thread Christian Costa
Le 31/08/2014 17:18, Christian Costa a écrit : Le 31/08/2014 16:23, Martin Peres a écrit : On 31/08/2014 16:19, Christian Costa wrote: Le 31/08/2014 16:11, Martin Peres a écrit : On 31/08/2014 16:01, Christian Costa wrote: Le 31/08/2014 15:12, Martin Peres a écrit : On 31/08/2014 15:00

[Nouveau] [PATCH envytools] nvamemtiming: Make deep mode take range into account and treat range end as included

2014-08-30 Thread Christian Costa
--- nva/set_timings.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/nva/set_timings.c b/nva/set_timings.c index 7376486..6cd831c 100644 --- a/nva/set_timings.c +++ b/nva/set_timings.c @@ -448,14 +448,14 @@ deep_dump(struct nvamemtiming_conf *conf) if

[Nouveau] [PATCH envytools] nvbios: Truncate nb of entries to avoid displaying garbage

2014-08-30 Thread Christian Costa
We return an error but this does not prevent the display so just make sure only valid data are printed. --- nvbios/mem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nvbios/mem.c b/nvbios/mem.c index e4797e3..00f5cd5 100644 --- a/nvbios/mem.c +++ b/nvbios/mem.c @@ -112,6 +112,7 @@

Re: [Nouveau] [PATCH envytools] Fix range end to the last value of timing table.

2014-08-28 Thread Christian Costa
Le 28/08/2014 10:27, Martin Peres a écrit : On 25/08/2014 21:00, Christian Costa wrote: --- nva/set_timings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nva/set_timings.c b/nva/set_timings.c index 7376486..985a707 100644 --- a/nva/set_timings.c +++ b/nva

[Nouveau] [PATCH envytools] nva: Clean up nva tools doc

2014-08-27 Thread Christian Costa
- Sort commands by name for easier update - Make more readable - Remove no more existing commands --- nva/README | 81 +- 1 file changed, 43 insertions(+), 38 deletions(-) diff --git a/nva/README b/nva/README index 625ea7c..cbe6ae3

[Nouveau] [PATCH envytools] Don't try to use bios-parts if NULL (parse_pcir function has probably failed).

2014-08-27 Thread Christian Costa
--- nvbios/info.c | 4 1 file changed, 4 insertions(+) diff --git a/nvbios/info.c b/nvbios/info.c index 87a33d8..acc40d8 100644 --- a/nvbios/info.c +++ b/nvbios/info.c @@ -119,6 +119,10 @@ int envy_bios_parse_bit_i (struct envy_bios *bios, struct envy_bios_bit_entry *b

[Nouveau] [PATCH envytools] docs: Fix some spelling and remove some trailing spaces.

2014-08-25 Thread Christian Costa
--- docs/hw/fifo/intro.rst | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/docs/hw/fifo/intro.rst b/docs/hw/fifo/intro.rst index 8b1d69d..0e023bf 100644 --- a/docs/hw/fifo/intro.rst +++ b/docs/hw/fifo/intro.rst @@ -10,7 +10,7 @@ FIFO overview

[Nouveau] [PATCH envytools] nva: Clean up nva tools doc

2014-08-25 Thread Christian Costa
- Sort commands by name for easier update - Make more readable - Remove no more existing commands --- nva/README | 83 +- 1 file changed, 44 insertions(+), 39 deletions(-) diff --git a/nva/README b/nva/README index 625ea7c..d4347c5

[Nouveau] [PATCH envytools] nvbios: Return an error if mem train subentries is above the limit to avoid stack corruption.

2014-08-25 Thread Christian Costa
--- nvbios/mem.c | 4 1 file changed, 4 insertions(+) diff --git a/nvbios/mem.c b/nvbios/mem.c index 911ce5c..2c8a929 100644 --- a/nvbios/mem.c +++ b/nvbios/mem.c @@ -111,6 +111,10 @@ envy_bios_parse_mem_train (struct envy_bios *bios) { struct envy_bios_mem_train_entry

[Nouveau] [PATCH envytools] nvbios: Check if HWEA entry length == -1.

2014-08-25 Thread Christian Costa
--- nvbios/bios.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/nvbios/bios.c b/nvbios/bios.c index fac3840..ca8c54e 100644 --- a/nvbios/bios.c +++ b/nvbios/bios.c @@ -276,9 +276,14 @@ int envy_bios_parse (struct envy_bios *bios) {

[Nouveau] [PATCH envytools] nvbios: Write missing null terminating byte.

2014-08-25 Thread Christian Costa
--- nvbios/nvbios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nvbios/nvbios.c b/nvbios/nvbios.c index 4fc667b..7bb768a 100644 --- a/nvbios/nvbios.c +++ b/nvbios/nvbios.c @@ -797,9 +797,9 @@ void find_strap(char *filename) { path = (char*) malloc(base_length

[Nouveau] [PATCH envytools] demmio: Add decoding of some MEM_TIMINGS registers for NVC0.

2014-08-25 Thread Christian Costa
--- rnndb/memory/nvc0_pbfb.xml | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/rnndb/memory/nvc0_pbfb.xml b/rnndb/memory/nvc0_pbfb.xml index 500cea9..e006dbe 100644 --- a/rnndb/memory/nvc0_pbfb.xml +++ b/rnndb/memory/nvc0_pbfb.xml @@

[Nouveau] [PATCH envytools] Don't try to use bios-pars if NULL (parse_pcir function has probably failed).

2014-08-25 Thread Christian Costa
--- nvbios/info.c | 4 1 file changed, 4 insertions(+) diff --git a/nvbios/info.c b/nvbios/info.c index 87a33d8..6b8d209 100644 --- a/nvbios/info.c +++ b/nvbios/info.c @@ -119,6 +119,10 @@ int envy_bios_parse_bit_i (struct envy_bios *bios, struct envy_bios_bit_entry *b

[Nouveau] [PATCH envytools] Fix range end to the last value of timing table.

2014-08-25 Thread Christian Costa
--- nva/set_timings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nva/set_timings.c b/nva/set_timings.c index 7376486..985a707 100644 --- a/nva/set_timings.c +++ b/nva/set_timings.c @@ -506,7 +506,7 @@ shallow_dump(struct nvamemtiming_conf *conf) if

Re: [Nouveau] [PATCH envytools] demmio: Add decoding of some MEM_TIMINGS registers for NVC0.

2014-08-25 Thread Christian Costa
Le 26/08/2014 00:30, Martin Peres a écrit : On 25/08/2014 20:58, Christian Costa wrote: --- rnndb/memory/nvc0_pbfb.xml | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/rnndb/memory/nvc0_pbfb.xml b/rnndb/memory/nvc0_pbfb.xml index

Re: [Nouveau] [PATCH envytools] nva: Clean up nva tools doc

2014-08-25 Thread Christian Costa
Le 26/08/2014 00:55, Ilia Mirkin a écrit : On Mon, Aug 25, 2014 at 6:35 PM, Martin Peres martin.pe...@free.fr wrote: On 25/08/2014 20:58, Christian Costa wrote: - Sort commands by name for easier update - Make more readable - Remove no more existing commands --- nva/README | 83

Re: [Nouveau] [PATCH 1/3] subdev: add a pfuse subdev

2014-08-24 Thread Christian Costa
Hi Martin, I'm not very familiar with the function naming scheme but shouldn't nouveau_fuse_rd32 use the same prefix as _fuse_ctor instead of nouveau? Christian Le 24/08/2014 23:15, Martin Peres a écrit : We will use this subdev to disable temperature reading on cards that did not get a