Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()

2024-07-23 Thread Christophe JAILLET
was transformed by using the Coccinelle software. Suggested-by: Christophe Jaillet Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau

[PATCH] drm/nouveau: Constify struct nouveau_job_ops

2024-06-14 Thread Christophe JAILLET
166e drivers/gpu/drm/nouveau/nouveau_exec.o Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/nouveau/nouveau_exec.c | 2 +- drivers/gpu/drm/nouveau/nouveau_sched.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

Re: [PATCH] drm/nouveau/nvif: Avoid build error due to potential integer overflows

2024-05-18 Thread Christophe JAILLET
(adding linux-harden...@vger.kernel.org) Le 18/05/2024 à 16:37, Guenter Roeck a écrit : Trying to build parisc:allmodconfig with gcc 12.x or later results in the following build error. drivers/gpu/drm/nouveau/nvif/object.c: In function 'nvif_object_mthd': drivers/gpu/drm/nouveau/nvif/object.c:

[Nouveau] [PATCH] drm/nouveau: Fix a potential theorical leak in nouveau_get_backlight_name()

2022-02-08 Thread Christophe JAILLET
ixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") Signed-off-by: Christophe JAILLET --- This patch is more a clean-up than a fix. It is unlikely than >= 100 backlight devices will be registered, and the over allocation would occur even much later when the und

[Nouveau] [PATCH v2] drm/nouveau/secboot: plug memory leak in ls_ucode_img_load_gr() error path

2017-05-08 Thread Christophe JAILLET
The last goto looks spurious because it releases less resources than the previous one. Also free 'img->sig' if 'ls_ucode_img_build()' fails. Fixes: 9d896f3e41a6 ("drm/nouveau/secboot: abstract LS firmware loading functions") Signed-off-by: Christophe JAILLET -

[Nouveau] [PATCH] drm/nouveau/secboot: fix some error handling in 'ls_ucode_img_load_gr'

2017-05-08 Thread Christophe JAILLET
The last goto looks spurious because it releases less resources than the previous one. Add a new label in order to free the memory allocated by the 'kmemdup' call. Fixes: 9d896f3e41a6 ("drm/nouveau/secboot: abstract LS firmware loading functions") Signed-off-by: Christophe J

[Nouveau] [PATCH] drm/nouveau/tegra: Fix error handling

2016-10-30 Thread Christophe JAILLET
'iommu_domain_alloc()' returns NULL in case of error, not an error pointer. So test it accordingly. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/n

[Nouveau] [PATCH] drm/nouveau/secboot/gm20b: Fix return value in case of error

2016-09-23 Thread Christophe JAILLET
If 'ioremap()' returns 0, 'gm20b_tegra_read_wpr()' will return 0 as well, which means success. Return -ENOMEM instead Signed-off-by: Christophe JAILLET --- Not sure that -ENOMEM is the best value. I've taken it because it is often used in such a case. --- drivers/gp

[Nouveau] Error handling in drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c

2016-07-13 Thread Christophe JAILLET
Hi, in file 'drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c', error handling in 'gm20b_tegra_read_wpr()' seams to be broken. The code used is: mc = ioremap(TEGRA_MC_BASE, 0xd00); if (!mc) { nvkm_error(&sb->subdev, "..."); return PTR_ERR(mc); } so we always re