Re: [Nouveau] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-09-09 Thread Javier Martinez Canillas
...] > drm/shmobile: Convert to platform remove callback returning void Pushed these to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH] Revert "drm/fb-helper: improve DRM fbdev emulation device names"

2021-10-21 Thread Javier Martinez Canillas
... > Sure, I'll do that and send a v2. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat

Re: [Nouveau] [RESEND PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem

2021-11-05 Thread Javier Martinez Canillas
ange, and break the connection to CONFIG_VGA_CONSOLE > altogether, also in the header? > > (Maybe we'll also need a proxy drm kconfig option to only have > drm_modeset.o builtin when CONFIG_DRM != n.) > See my other email. I believe the issue is drivers/gpu/drm always being

Re: [Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-05 Thread Javier Martinez Canillas
i915_vma.h" >> >> +static const struct drm_driver driver; >> + > > No, this makes absolutely no sense, and will also oops on nomodeset. > Ups, sorry about that. For some reason I thought that it was defined in the same compilation unit, but I noticed now that it is

Re: [Nouveau] [RESEND PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem

2021-11-05 Thread Javier Martinez Canillas
Hello Thomas, On 11/3/21 13:41, Thomas Zimmermann wrote: > Hi > > Am 03.11.21 um 13:28 schrieb Javier Martinez Canillas: >> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver >> but the exported vgacon_text_force() symbol is only used by D

Re: [Nouveau] [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem

2021-11-05 Thread Javier Martinez Canillas
_VGA_CONSOLE guard in the header. > We want to make this work on ARM systems. I even have a request to > replace offb on Power architecture by simpledrm. So the final config has > to be system agnostic. > Same, since we want to drop the fbdev drivers in Fedora, for all arches. > Best regards > Thomas > Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat

Re: [Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-05 Thread Javier Martinez Canillas
On 11/5/21 11:04, Jani Nikula wrote: > On Fri, 05 Nov 2021, Javier Martinez Canillas wrote: [snip] >> >> Do you envision other condition that could be added later to disable a >> DRM driver ? Or do you think that just from a code readability point of >> view makes wo

[Nouveau] [RESEND PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem

2021-11-05 Thread Javier Martinez Canillas
. Suggested-by: Daniel Vetter Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile| 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +-- drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/drm_nomodeset.c | 26 +

Re: [Nouveau] [RESEND PATCH 3/5] drm: Rename vgacon_text_force() function to drm_modeset_disabled()

2021-11-05 Thread Javier Martinez Canillas
tion to drm_check_modeset() and have it > return a negative errno code on failure. This gives maximum flexibility > and reduces errors in drivers. Right now the drivers return something > like -EINVAL, which seems wrong. Returning -ENODEV seems more appropriate. > Good idea. I'll do it in v2 as well. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat

Re: [Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-05 Thread Javier Martinez Canillas
Hello Jani, On 11/4/21 20:57, Jani Nikula wrote: > On Thu, 04 Nov 2021, Javier Martinez Canillas wrote: >> +/** >> + * drm_drv_enabled - Checks if a DRM driver can be enabled >> + * @driver: DRM driver to check >> + * >> + * Checks whether a DRM driver can be ena

Re: [Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-05 Thread Javier Martinez Canillas
Hello Thomas, On 11/5/21 09:43, Thomas Zimmermann wrote: > Hi > > Am 04.11.21 um 21:09 schrieb Javier Martinez Canillas: >> Hello Jani, >> >> On 11/4/21 20:57, Jani Nikula wrote: >>> On Thu, 04 Nov 2021, Javier Martinez Canillas wrote: >>>> +/** &

[Nouveau] [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem

2021-11-05 Thread Javier Martinez Canillas
acon_text_force() function and related logic to the DRM subsystem. While doing that, rename the function to drm_check_modeset() which better reflects what the function is really used to test for. Suggested-by: Daniel Vetter Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Cond

Re: [Nouveau] [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic

2021-11-05 Thread Javier Martinez Canillas
Hello Thomas, On 11/3/21 14:01, Thomas Zimmermann wrote: [snip] >> >> >> Javier Martinez Canillas (5): >>drm/i915: Fix comment about modeset parameters >>drm: Move nomodeset kernel parameter handler to the DRM subsystem >>drm: Re

[Nouveau] [PATCH v2 0/2] Cleanups for the nomodeset kernel command line parameter logic

2021-11-05 Thread Javier Martinez Canillas
make it return -ENODEV. Javier Martinez Canillas (2): drm: Add a drm_drv_enabled() to check if drivers should be enabled drm: Move nomodeset kernel parameter to the DRM subsystem drivers/gpu/drm/Makefile| 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 +++- driv

[Nouveau] [RESEND PATCH 3/5] drm: Rename vgacon_text_force() function to drm_modeset_disabled()

2021-11-05 Thread Javier Martinez Canillas
that it is part of the DRM subsystem. Also, vgacon_text_force() is guarded by #ifdef CONFIG_VGA_CONSOLE already so there is no need to do the same when calling the function. Suggested-by: Suggested-by: Daniel Vetter Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/amd/amdgpu/amdgpu_

[Nouveau] [RESEND PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic

2021-11-05 Thread Javier Martinez Canillas
o check this instead of just checking if nomodeset has been set. Javier Martinez Canillas (5): drm/i915: Fix comment about modeset parameters drm: Move nomodeset kernel parameter handler to the DRM subsystem drm: Rename vgacon_text_force() function to drm_modeset_disabled() drm: Add a drm_

Re: [Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-05 Thread Javier Martinez Canillas
Hello Sam, On 11/4/21 18:57, Jani Nikula wrote: > On Thu, 04 Nov 2021, Sam Ravnborg wrote: >> Hi Javier, >> >> On Thu, Nov 04, 2021 at 05:07:06PM +0100, Javier Martinez Canillas wrote: >>> Some DRM drivers check the vgacon_text_force() function return value as an

Re: [Nouveau] [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem

2021-11-05 Thread Javier Martinez Canillas
pu/drm/i915/i915_module.c >> b/drivers/gpu/drm/i915/i915_module.c >> index 45cb3e540eff..c890c1ca20c4 100644 >> --- a/drivers/gpu/drm/i915/i915_module.c >> +++ b/drivers/gpu/drm/i915/i915_module.c >> @@ -4,8 +4,6 @@ >>* Copyright © 2021 Intel Corporation >>

[Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-05 Thread Javier Martinez Canillas
;s no need for callers to do it. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Squash patch to add drm_drv_enabled() and make drivers use it. - Make the drivers changes before moving nomodeset logic to DRM. - Make drm_drv_enabled() return an errno and

Re: [Nouveau] [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module

2022-01-12 Thread Javier Martinez Canillas
On Wed, Dec 15, 2021 at 12:12 PM Thomas Zimmermann wrote: > > Hi > > Am 15.12.21 um 12:04 schrieb Jani Nikula: > > On Wed, 15 Dec 2021, Thomas Zimmermann wrote: > >> * move DP helper code into dp/ (Jani) > > > > I suggested adding the subdirectory, but I'm going to bikeshed the name, > > whi

Re: [Nouveau] [PATCH 3/4] drm/plane-helper: Warn if atomic drivers call non-atomic helpers

2022-09-20 Thread Javier Martinez Canillas
On 9/9/22 12:59, Thomas Zimmermann wrote: > The plane update and disable helpers are only useful for non-atomic > drivers. Print a warning if an atomic driver calls them. > > Suggested-by: Daniel Vetter > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez C

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-20 Thread Javier Martinez Canillas
drmm_*_alloc() managed interfaces should use the drmm_k{z,m}alloc() helpers, so that the memory is automatically freed on the last drm_dev_put() call ? Other than those two nits, the patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH 2/4] drm/plane: Allocate planes with drm_universal_plane_alloc()

2022-09-20 Thread Javier Martinez Canillas
ent's question on that topic. > Ah, never mind. I misread the function name definition and thought that you had a drmm_ suffix but, now on second read I see that is only drm_ so just ignore my comment about using managed memory alloc / release. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH 1/4] drm/plane: Remove drm_plane_init()

2022-09-20 Thread Javier Martinez Canillas
DRM_PLANE_TYPE_OVERLAY, NULL); Not only drm_plane_init() doesn't add much value but makes the code harder to read. Since by calling drm_universal_plane_init() instead, it's explicit whether the initialized plane is primary or an overlay. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH 4/4] drm/plane-helper: Provide DRM_PLANE_NON_ATOMIC_FUNCS initializer macro

2022-09-20 Thread Javier Martinez Canillas
ned-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Javier Martinez Canillas
rn drm_connector_pick_cmdline_mode(connector) > } > EXPORT_SYMBOL(drm_connector_pick_cmdline_mode_kunit) > #endif > > The wrapper's declaration can be located in the kunit test file. > But that's also not nice since we are artificially exposing these only to allow the static functions to be called from unit tests. And would be a different approach than the one used by all other subsystems... -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Javier Martinez Canillas
files. also includes quite a few of Linux > header files. > > IMHO the current convention (if any) is far from optimal and we should > consider breaking it. > Yes, I agree with that. But probably we should be explicit about the wrapper export symbols to access static functions pattern in the KUnit docs so other subsystems could do the same and it becomes a convention ? > Best regards > Thomas > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 01/21] drm/komeda: Don't set struct drm_driver.lastclose

2022-10-31 Thread Javier Martinez Canillas
ore() in drm_lastclose(). > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 02/21] drm/mcde: Don't set struct drm_driver.lastclose

2022-10-31 Thread Javier Martinez Canillas
ore() in drm_lastclose(). > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 03/21] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-10-31 Thread Javier Martinez Canillas
lient_dev_restore() in drm_lastclose(). > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

2022-10-31 Thread Javier Martinez Canillas
s_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Do you think that the fbdev helpers k

Re: [Nouveau] [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

2022-10-31 Thread Javier Martinez Canillas
s_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 05/21] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed

2022-10-31 Thread Javier Martinez Canillas
s_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 06/21] drm/ingenic: Don't set struct drm_driver.output_poll_changed

2022-10-31 Thread Javier Martinez Canillas
s_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian, Sergey) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 07/21] drm/logicvc: Don't set struct drm_driver.output_poll_changed

2022-10-31 Thread Javier Martinez Canillas
s_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 08/21] drm/rockchip: Don't set struct drm_driver.output_poll_changed

2022-10-31 Thread Javier Martinez Canillas
s_helper_hotplug_event() and > drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. > > v2: > * fix commit description (Christian) > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 09/21] drm/panel-ili9341: Include

2022-10-31 Thread Javier Martinez Canillas
On 10/24/22 13:19, Thomas Zimmermann wrote: > Include for devm_of_find_backlight(). > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 10/21] drm/tve200: Include

2022-10-31 Thread Javier Martinez Canillas
On 10/24/22 13:19, Thomas Zimmermann wrote: > Include for of_match_ptr(). > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 11/21] drm/fb-helper: Cleanup include statements in header file

2022-10-31 Thread Javier Martinez Canillas
On 10/24/22 13:19, Thomas Zimmermann wrote: > Only include what we have to. > > Signed-off-by: Thomas Zimmermann > --- Nice cleanup. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-10-31 Thread Javier Martinez Canillas
es. > > Signed-off-by: Thomas Zimmermann > --- Agreed. I got confused by this naming in the past. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-10-31 Thread Javier Martinez Canillas
On 10/24/22 13:19, Thomas Zimmermann wrote: > Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as > part of unifying the naming within fbdev helpers. Adapt drivers. No > functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez C

Re: [Nouveau] [PATCH v2 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-10-31 Thread Javier Martinez Canillas
On 10/24/22 13:19, Thomas Zimmermann wrote: > Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() > as part of unifying the naming within fbdev helpers. Adapt drivers. No > functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier

Re: [Nouveau] [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic

2022-11-02 Thread Javier Martinez Canillas
m_fb_helper, > damage_work); This line is an unrelated code style change. But I guess it's OK. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 16/21] drm/fb-helper: Call fb_sync in I/O functions

2022-11-02 Thread Javier Martinez Canillas
same in DRM implementations will allow us to use > them throughout DRM drivers. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-11-02 Thread Javier Martinez Canillas
store and return the errno value. [...] > +static ssize_t fb_write_screen_base(struct fb_info *info, const char __user > *buf, size_t count, > + loff_t pos) > +{ > + char __iomem *dst = info->screen_base + pos; > + size_t alloc_size = min_t(size_t, count, PAGE_SIZE); > + ssize_t ret = 0; > + int err = 0; Same here. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead

2022-11-02 Thread Javier Martinez Canillas
an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++--- > 1 file changed, 60 insertions(+), 30 deletions(-) &

Re: [Nouveau] [PATCH v2 19/21] drm/fb-helper: Always initialize generic fbdev emulation

2022-11-02 Thread Javier Martinez Canillas
t; will initialize after hotplugging the connector. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-11-02 Thread Javier Martinez Canillas
omas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v2 21/21] drm/fb-helper: Remove unnecessary include statements

2022-11-02 Thread Javier Martinez Canillas
On 10/24/22 13:19, Thomas Zimmermann wrote: > Remove include statements for where it is not > required (i.e., most of them). In a few places include other header > files that are required by the source code. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier

Re: [Nouveau] [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-11-02 Thread Javier Martinez Canillas
happen that some userspace program hits to error, but still > relies on the output and position being updated. IIRC I even added > validation of this behavior to the IGT fbdev tests. I agree that this > is somewhat bogus behavior, but changing it would change long-standing > userspace semantics. > Thanks for the explanation, feel free then to also add to this patch: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses

2022-11-04 Thread Javier Martinez Canillas
helper.c. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed

2022-11-04 Thread Javier Martinez Canillas
-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2022-12-19 Thread Javier Martinez Canillas
> next cleanup patch. Still prepare this already by also selecting I2C for > the individual drivers. > > Signed-off-by: Uwe Kleine-König > --- Thanks for sending a v3 of this. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [Nouveau] [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2023-01-10 Thread Javier Martinez Canillas
On 12/19/22 09:49, Javier Martinez Canillas wrote: > Hello Uwe, > > On 12/19/22 09:36, Uwe Kleine-König wrote: >> While working on a drm driver that doesn't need the i2c algobit stuff I >> noticed that DRM selects this code even though only 8 drivers actually use &

Re: [Nouveau] [PATCH v2] drm/nouveau: Remove file nouveau_fbcon.c

2023-01-10 Thread Javier Martinez Canillas
nongit.freedesktop.org/drm/drm-misc into drm-next") I believe the fixes tag should be before the S-o-B ? At least that is the case in most commits and Documentation/process/maintainer-tip.rst example. But you could fix it just before applying. The patch looks good to me. Reviewed-by: Javi

Re: [PATCH 57/86] drm/ofdrm: Use DRM default client setup

2024-08-19 Thread Javier Martinez Canillas
immermann > Cc: Javier Martinez Canillas > --- > drivers/gpu/drm/tiny/ofdrm.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 58/86] drm/simpledrm: Run DRM default client setup

2024-08-19 Thread Javier Martinez Canillas
> Cc: Javier Martinez Canillas > --- > drivers/gpu/drm/tiny/simpledrm.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 59/86] drm/solomon: Run DRM default client setup

2024-08-19 Thread Javier Martinez Canillas
> is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Javier Martinez Canillas > --- > drivers/gpu/drm/solomon/ssd130x.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Javier Martinez C

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Javier Martinez Canillas
function semantics should be changed, then I think that the kernel-doc needs to be updated: - * @fb_helper: driver-allocated fbdev helper, can be NULL + * @fb_helper: driver-allocated fbdev helper, must not be NULL Other than that, the patch looks good to me: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 79/81] drm/tegra: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
-- > 3 files changed, 19 insertions(+), 96 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 75/81] drm/exynos-drm: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
nos_drm_fbdev.c > @@ -22,9 +22,6 @@ > #include "exynos_drm_fb.h" > #include "exynos_drm_fbdev.h" > > -#define MAX_CONNECTOR4 I see this constant was unused. Is an unrelated cleanup but I guess is OK too. Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 76/81] drm/gma500: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
- > drivers/gpu/drm/gma500/psb_drv.c | 4 +- > drivers/gpu/drm/gma500/psb_drv.h | 12 +++- > 3 files changed, 19 insertions(+), 97 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 77/81] drm/msm: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
m_fbdev.c | 144 ++-- > 3 files changed, 38 insertions(+), 123 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 80/81] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-03 Thread Javier Martinez Canillas
4c7217b35f6b..d903568fd8cc 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.h > +++ b/drivers/gpu/drm/omapdrm/omap_drv.h > @@ -32,6 +32,7 @@ > #define MODULE_NAME "omapdrm" > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 81/81] drm/omapdrm: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
8 insertions(+), 102 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
struct fb_ops drm_fbdev_dma_fb_ops = { > > static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper, >struct drm_fb_helper_surface_size > *sizes) > +{ static inline for this wrapper maybe ? > + return drm_fbdev_dma_driver_fbdev_probe(fb

Re: [PATCH v3 06/81] drm/arcgpu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; > Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 49/81] drm/fbdev-dma: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
drm_fbdev_dma.c | 120 +--- > include/drm/drm_fbdev_dma.h | 7 -- > 2 files changed, 1 insertion(+), 126 deletions(-) > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 50/81] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
static inline too but I guess is just a transition change and will be removed by a later patch, as was the case for the fbdev-dma setup function. So it doesn't really matter that much... Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 03/81] drm/fbdev: Add memory-agnostic fbdev client

2024-09-03 Thread Javier Martinez Canillas
red_depth for default format > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 12/81] drm/fsl-dcu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
gner > Cc: Alison Wang > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier > > Am 03.09.24 um 12:18 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas, >> >>> Call vga_switcheroo_client_fb_set() with the PCI device from the >>> instance of st

Re: [PATCH v3 14/81] drm/hx8357d: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
ny/hx8357d.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 15/81] drm/ili9163: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
ny/ili9163.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 10/81] drm/aspeed: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
ged, 3 insertions(+), 1 deletion(-) Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 18/81] drm/ili9486: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
gt; --- > drivers/gpu/drm/tiny/ili9486.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 17/81] drm/ili9341: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
ny/ili9341.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 19/81] drm/imx/dcss: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
s/dcss-kms.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 20/81] drm/imx/ipuv3: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Zabel > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > --- > drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 21/81] drm/imx/lcdc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
a Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > --- > drivers/gpu/drm/imx/lcdc/imx-lcdc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 23/81] drm/kmb: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
nthus > Cc: Edmund Dea > --- > drivers/gpu/drm/kmb/kmb_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 24/81] drm/logicvc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 25/81] drm/mcde: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Linus Walleij > Acked-by: Linus Walleij > --- > drivers/gpu/drm/mcde/mcde_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javie

Re: [PATCH v3 30/81] drm/mxsfb: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
gutronix Kernel Team > Cc: Fabio Estevam > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 29/81] drm/mxsfb/lcdif: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
/lcdif_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 33/81] drm/pl111: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
gt; drivers/gpu/drm/pl111/pl111_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 39/81] drm/sti: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Alain Volmat > --- > drivers/gpu/drm/sti/sti_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regar

Re: [PATCH v3 41/81] drm/sun4i: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
ons(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 42/81] drm/tidss: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/tidss/tidss_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martine

Re: [PATCH v3 43/81] drm/tilcdc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; > Signed-off-by: Thomas Zimmermann > Cc: Jyri Sarha > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 52/81] drm/cirrus: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
pu/drm/tiny/cirrus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 60/81] drm/udl: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
c: Sean Paul > Cc: Thomas Zimmermann > --- > drivers/gpu/drm/udl/udl_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 61/81] drm/virtgpu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
5 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 62/81] drm/vkms: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
> Cc: Melissa Wen > Cc: "Maíra Canal" > Cc: Haneen Mohammed > --- > drivers/gpu/drm/vkms/vkms_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 53/81] drm/gm12u320: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
-- > drivers/gpu/drm/tiny/gm12u320.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 63/81] drm/fbdev-shmem: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
m_fbdev_shmem.c | 120 +- > include/drm/drm_fbdev_shmem.h | 6 -- > 2 files changed, 1 insertion(+), 125 deletions(-) > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 64/81] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
+), 65 deletions(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 67/81] drm/hisilicon/hibmc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH v3 66/81] drm/bochs: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Gerd Hoffmann > --- > drivers/gpu/drm/tiny/bochs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martinez Canillas -- Best regar

Re: [PATCH v3 70/81] drm/qxl: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
t; is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Dave Airlie > Cc: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Javier Martine

  1   2   >