Re: [Nouveau] [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-24 Thread Michal Hocko
On Wed 24-07-19 20:56:17, Michal Hocko wrote: > On Wed 24-07-19 15:08:37, Jason Gunthorpe wrote: > > On Wed, Jul 24, 2019 at 07:58:58PM +0200, Michal Hocko wrote: > [...] > > > Maybe new users have started relying on a new semantic in the meantime, > > > back then,

Re: [Nouveau] [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-24 Thread Michal Hocko
On Wed 24-07-19 15:08:37, Jason Gunthorpe wrote: > On Wed, Jul 24, 2019 at 07:58:58PM +0200, Michal Hocko wrote: [...] > > Maybe new users have started relying on a new semantic in the meantime, > > back then, none of the notifier has even started any action in blocking >

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-24 Thread Michal Hocko
ing events? The only place > where mmu_notifier_invalidate_range_start_nonblock is called is the oom > killer, which means the process is about to die and the pagetable will > get torn down ASAP. Should we just skip them unconditionally? How do you tell whether they are going to block or

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-24 Thread Michal Hocko
r becomes unable to get to 0. > > Below is the best idea I've had so far.. > > Michal, what do you think? IIRC we have discussed this with Jerome back then when I've introduced this code and unless I misremember he said the current code was OK. Maybe new users have started relying on

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-27 Thread Michal Hocko
On Wed 26-06-19 09:14:32, Dan Williams wrote: > On Tue, Jun 25, 2019 at 10:46 PM Michal Hocko wrote: > > > > On Tue 25-06-19 12:52:18, Dan Williams wrote: > > [...] > > > > Documentation/process/stable-api-nonsense.rst > > > > > > That d

Re: [Nouveau] [PATCH 06/25] mm: export alloc_pages_vma

2019-06-26 Thread Michal Hocko
On Wed 26-06-19 14:27:05, Christoph Hellwig wrote: > nouveau is currently using this through an odd hmm wrapper, and I plan > to switch it to the real thing later in this series. > > Signed-off-by: Christoph Hellwig > Reviewed-by: John Hubbard Acked-by: Michal Hocko Thank

Re: [Nouveau] [PATCH 05/22] mm: export alloc_pages_vma

2019-06-25 Thread Michal Hocko
xported regardless of that document. Can you point me to any specific example where this would be the case for the core kernel symbols please? -- Michal Hocko SUSE Labs ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.or

Re: [Nouveau] [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken

2019-06-25 Thread Michal Hocko
to use it. So it really > does seem safe to remove, although of course it's good to start with > BROKEN and see if anyone pops up and complains. Well, I do not really see much of a difference. Preserving an unused code which doesn't have any user in sight just adds a maintenance burde

Re: [Nouveau] [PATCH 05/22] mm: export alloc_pages_vma

2019-06-25 Thread Michal Hocko
On Tue 25-06-19 11:03:53, Dan Williams wrote: > On Tue, Jun 25, 2019 at 8:01 AM Michal Hocko wrote: > > > > On Tue 25-06-19 09:23:17, Christoph Hellwig wrote: > > > On Mon, Jun 24, 2019 at 11:24:48AM -0700, Dan Williams wrote: > > > > I asked for thi

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-25 Thread Michal Hocko
uld go with consistency and export the same way we do with other functions. Also we do not want people to reinvent this API and screw that like we have seen in other cases when external modules try reimplement core functionality themselves. Thanks! -- Michal Hocko SUSE Labs

Re: [Nouveau] [PATCH 04/22] mm: don't clear ->mapping in hmm_devmem_free

2019-06-20 Thread Michal Hocko
data; > > - page->mapping = NULL; > - > devmem->ops->free(devmem, page); > } > > -- > 2.20.1 -- Michal Hocko SUSE Labs ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH 03/22] mm: remove hmm_devmem_add_resource

2019-06-20 Thread Michal Hocko
directly now that we've simplified the API for it. > > Signed-off-by: Christoph Hellwig Acked-by: Michal Hocko > --- > include/linux/hmm.h | 3 --- > mm/hmm.c| 54 - > 2 files changed, 57 deletions(-) > > diff --git a

Re: [Nouveau] [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken

2019-06-20 Thread Michal Hocko
emove all the DEVICE_PUBLIC code. > Signed-off-by: Christoph Hellwig Anyway Acked-by: Michal Hocko > --- > mm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 0d2ba7e1f43e..406fa45e9ecc 100644 > --- a/mm/Kconfig > +++ b/mm/

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-20 Thread Michal Hocko
> } > +EXPORT_SYMBOL_GPL(alloc_pages_vma); All allocator exported symbols are EXPORT_SYMBOL, what is a reason to have this one special? -- Michal Hocko SUSE Labs

Re: [Nouveau] nouveau driver locks up with 4.11 kernel

2017-08-14 Thread Michal Hocko
On Mon 14-08-17 15:27:20, Ilia Mirkin wrote: > On Mon, Aug 14, 2017 at 3:18 PM, Michal Hocko <mho...@kernel.org> wrote: [...] > > nouveau :03:00.0: fifo: channel 6 [mpv/vo[3535]] kick timeout > > nouveau: mpv/vo[3535]::906f: detach gr failed, -110 &

[Nouveau] nouveau driver locks up with 4.11 kernel

2017-08-14 Thread Michal Hocko
_ERROR 13 [] 1 nouveau :03:00.0: fifo: runlist update timeout 4249 nouveau :03:00.0: fifo: SCHED_ERROR 13 [] -- Michal Hocko SUSE Labs ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] system death under oom - 3.7.9

2013-03-29 Thread Michal Hocko
at http://www.tux.org/lkml/ -- Michal Hocko SUSE Labs ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau