Re: Rework TTMs busy handling

2024-01-10 Thread Michel Dänzer
't immediately think of something better, though. > > Yeah, I was wondering about that as well. Especially since I wanted to add > some more flags in the future when for example a bandwidth quota how much > memory can be moved in/out is exceeded. > > Something like phase1, phase2, pha

Re: [Nouveau] [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-28 Thread Michel Dänzer
merge? One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI. -- Earthling Mich

Re: [Nouveau] [PATCH] Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-03 Thread Michel Dänzer
no shift instead of <<, shouldn't it? Multiplying a value in bytes by the page size doesn't make sense. I didn't check the rest of the patch in detail, but it's easy introduce subtle regressions with this kind of change. It'll require a lot of review & testing scrutiny. -- Earthling Michel Dänzer| https://redhat.com Libre software enthusiast | Mesa and Xwayland developer

Re: [Nouveau] [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Michel Dänzer
On 2020-05-22 12:40 p.m., Christian König wrote: > Am 20.05.20 um 18:25 schrieb Michel Dänzer: >> On 2020-05-20 4:43 p.m., Christian König wrote: >>> Am 13.05.20 um 13:03 schrieb Christian König: >>>> Unfortunately AGP is still to widely used as we could just drop &

Re: [Nouveau] [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-20 Thread Michel Dänzer
or this is not the better TLB performance, but > the lack of USWC support for the PCIe GART in radeon. I suspect the main reason it's only 5% is that PCIe GART page tables are stored in VRAM, so they don't need to be fetched across the PCIe link (and presumably it has more than one TLB entr

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-13 Thread Michel Dänzer
switch didn't had any noticeable effect at all. > > But I didn't do more than playing around with the desktop effects and > playing a video. Yeah, that's not enough to see a difference. Try an OpenGL game, or even just glxgears. -- Earthling Michel Dänzer |

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Michel Dänzer
e > reliable. Due to its unreliability, AGP support has been disabled on > PowerPC for years already so there is no change on PowerPC." There's a difference between something being disabled by default or not being available at all. We may decide it's worth it an

Re: [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-14 Thread Michel Dänzer
>>> >>> Lukas >> >> I would say fixes, it doesn't look particularly scary. :) > > Agreed. If it's good enough for stable, it's good enough for -fixes! It's not that simple, is it? Fast-tracking patches (some of wh

Re: [Nouveau] nouveau. swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152

2017-12-19 Thread Michel Dänzer
On 2017-12-19 11:37 AM, Michel Dänzer wrote: > On 2017-12-18 08:01 PM, Tobias Klausmann wrote: >> On 12/18/17 7:06 PM, Mike Galbraith wrote: >>> Greetings, >>> >>> Kernel bound workloads seem to trigger the below for whatever reason. >>>   I only see t

Re: [Nouveau] nouveau. swiotlb: coherent allocation failed for device 0000:01:00.0 size=2097152

2017-12-19 Thread Michel Dänzer
König <christian.koe...@amd.com> Date: Thu Jul 6 09:59:43 2017 +0200 drm/ttm: add transparent huge page support for DMA allocations v2 Try to allocate huge pages when it makes sense. v2: fix comment and use ifdef -- Earthling Michel Dänzer

Re: [Nouveau] [PATCH xf86-video-amdgpu] Adapt to PixmapDirtyUpdateRec::src being a DrawablePtr

2017-07-14 Thread Michel Dänzer
On 14/07/17 11:24 AM, Ilia Mirkin wrote: > On Thu, Jul 13, 2017 at 10:14 PM, Michel Dänzer <mic...@daenzer.net> wrote: >> On 13/07/17 09:31 PM, Ilia Mirkin wrote: >>> On Thu, Jul 13, 2017 at 4:27 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>>>

Re: [Nouveau] [PATCH xf86-video-amdgpu] Adapt to PixmapDirtyUpdateRec::src being a DrawablePtr

2017-07-13 Thread Michel Dänzer
On 13/07/17 09:31 PM, Ilia Mirkin wrote: > On Thu, Jul 13, 2017 at 4:27 AM, Michel Dänzer <mic...@daenzer.net> wrote: >> On 18/04/17 07:07 PM, Michel Dänzer wrote: >>> From: Michel Dänzer <michel.daen...@amd.com> >>> >>> Signed-off-by: Michel Dänze

Re: [Nouveau] [PATCH xf86-video-amdgpu] Adapt to PixmapDirtyUpdateRec::src being a DrawablePtr

2017-07-13 Thread Michel Dänzer
On 18/04/17 07:07 PM, Michel Dänzer wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> > --- > > Chris / Ilia / Ben, this should be manageable for the intel/nouveau > drivers, right? Any feedback,

Re: [Nouveau] [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-21 Thread Michel Dänzer
On 21/06/17 05:14 PM, Daniel Vetter wrote: > On Wed, Jun 21, 2017 at 04:59:31PM +0900, Michel Dänzer wrote: >> On 21/06/17 04:38 PM, Daniel Vetter wrote: >>> On Tue, Jun 20, 2017 at 09:25:25PM +0200, Peter Rosin wrote: >>>> This makes the redundant fb helpers .load_

Re: [Nouveau] [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-21 Thread Michel Dänzer
be yet another bug, > but might be relevant for your use-case. Just try to run both an fbdev > application and some kms-native thing, and then SIGKILL the native kms > app. > > But since pre-existing not really required, and probably too much effort. I suspect something like

[Nouveau] [PATCH xserver] Make PixmapDirtyUpdateRec::src a DrawablePtr

2017-04-18 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> This allows making the master screen's pixmap_dirty_list entries explicitly reflect that we're now tracking the root window instead of the screen pixmap, in order to allow Present page flipping on master outputs while there are active slave o

[Nouveau] [PATCH xf86-video-amdgpu] Adapt to PixmapDirtyUpdateRec::src being a DrawablePtr

2017-04-18 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> Signed-off-by: Michel Dänzer <michel.daen...@amd.com> --- Chris / Ilia / Ben, this should be manageable for the intel/nouveau drivers, right? src/amdgpu_drv.h | 26 ++ src/amdgpu_kms.c | 18 +--

Re: [Nouveau] [PATCH 3/4] drm/amd/display: Switch to using atomic_helper for flip.

2017-01-18 Thread Michel Dänzer
On 19/01/17 07:18 AM, Grodzovsky, Andrey wrote: >> From: Michel Dänzer [mailto:mic...@daenzer.net] >> On 17/01/17 07:16 AM, Laurent Pinchart wrote: >>> On Monday 16 Jan 2017 10:44:57 Andrey Grodzovsky wrote: >>>> Change-Id: Iad3e0b9b3546e4e4dc79be9233daf4fe4d

Re: [Nouveau] [PATCH 3/4] drm/amd/display: Switch to using atomic_helper for flip.

2017-01-17 Thread Michel Dänzer
t; * 2. This commit is a page flip, and targets are > created. >> */ >> -if (!page_flip_needed(plane_state, old_plane_state, >> - true) || >> +if (!page_flip_needed(plane_state, o

Re: [Nouveau] 4.9-rc7 nouveau fails on arm64 64k page kernel but works with 4k

2016-12-07 Thread Michel Dänzer
oking at the trace I wonder - is the limitation in Nouveau or in TTM? Nouveau. Non-4K page sizes work fine with radeon (and presumably amdgpu). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [Nouveau] [PATCH] drm/nouveau: Fix pre-nv50 pageflip events

2015-11-01 Thread Michel Dänzer
* @crtc: the source CRTC of the vblank event Ye olde vblanke event? ;) (typo, same in the previous comment) The function name in this comment doesn't match the name of the function it describes. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

Re: [Nouveau] [Mesa-dev] [RFC PATCH 5/8] nv50: prevent NULL pointer dereference with pipe_query functions

2015-06-23 Thread Michel Dänzer
query object. Could the HUD code be fixed instead? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Nouveau mailing list Nouveau@lists.freedesktop.org

Re: [Nouveau] [PATCH 1/9] dri2: Fix can_exchange() to allow page-flipping on new servers.

2012-02-20 Thread Michel Dänzer
On Mon, 2012-02-20 at 05:59 +0100, Mario Kleiner wrote: On 02/16/2012 11:04 AM, Michel Dänzer wrote: On Don, 2012-02-16 at 00:45 +0100, Mario Kleiner wrote: can_exchange() fails on at least Xorg 1.12+. This fixes it in the same way it was fixed in the ati intel ddx. Signed-off

Re: [Nouveau] [PATCH 9/9] dri2: Fix corner case crash for swaplimit 1

2012-02-16 Thread Michel Dänzer
DRI2GetBuffersWithFormat() before nouveau_dri2_finish_swap() executes and it deletes pixmaps that would be needed by nouveau_dri2_finish_swap() -- Segfault -- Crash. Pixmaps are reference counted, so it should be possible to fix this via proper reference counting. -- Earthling Michel Dänzer

Re: [Nouveau] [PATCH 1/9] dri2: Fix can_exchange() to allow page-flipping on new servers.

2012-02-16 Thread Michel Dänzer
the depths don't match? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org

Re: [Nouveau] Why was old TTM removed from drm.git?

2009-06-25 Thread Michel Dänzer
and subject of that mail (or any others that were apparently lost)? I can't seem to find anything in the dri-devel moderation queue mails around the weekend, so apparently it was dropped before it reached mailman. Maybe some sf.net spam filter or something. -- Earthling Michel Dänzer