Re: [Nouveau] [Mesa-dev] [RFC 0/9] Add precise/invariant semantics to TGSI

2017-06-12 Thread Nicolai Hähnle
ut I found no other easy way to handle this. Maybe somebody of you has a better idea? Sent a suggestion, as well as comments on patches 4 & 5. Patches 1 & 2: Reviewed-by: Nicolai Hähnle Karol Herbst (9): tgsi: add precise flag to tgsi_instruction tgsi/dump: print _PRECISE mo

Re: [Nouveau] [Mesa-dev] [RFC 3/9] st/glsl_to_tgsi: handle precise modifier

2017-06-12 Thread Nicolai Hähnle
On 11.06.2017 20:42, Karol Herbst wrote: all subexpression inside an ir_assignment needs to be tagged as precise. Signed-off-by: Karol Herbst --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 80 -- 1 file changed, 65 insertions(+), 15 deletions(-) diff --git a/sr

Re: [Nouveau] [Mesa-dev] [RFC 4/9] tgsi: populate precise

2017-06-12 Thread Nicolai Hähnle
On 11.06.2017 20:42, Karol Herbst wrote: Only implemented for glsl->tgsi. Other converters just set precise to 0. Signed-off-by: Karol Herbst --- src/gallium/auxiliary/tgsi/tgsi_build.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_ureg.c| 14 +++--- src/gallium/auxiliary/tgsi

Re: [Nouveau] [Mesa-dev] [RFC 5/9] tgsi/text: parse _PRECISE modifier

2017-06-12 Thread Nicolai Hähnle
On 11.06.2017 20:42, Karol Herbst wrote: Signed-off-by: Karol Herbst --- src/gallium/auxiliary/tgsi/tgsi_text.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c b/src/gallium/auxiliary/tgsi/tgsi_text.c index 93a05568f

Re: [Nouveau] [Mesa-dev] [PATCH mesa 1/6] tgsi_build: Fix return of uninitialized memory in tgsi_*_instruction_memory

2016-03-19 Thread Nicolai Hähnle
: 3243b6fc97 ("tgsi: add Texture and Format to tgsi_instruction_memory") Cc: Nicolai Hähnle Signed-off-by: Hans de Goede Thanks. Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_build.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxi