Re: DisplayPort: handling of HPD events / link training

2024-07-16 Thread Thomas Zimmermann
Hi Am 16.07.24 um 18:35 schrieb Dmitry Baryshkov: On Tue, 16 Jul 2024 at 18:58, Thomas Zimmermann wrote: Hi Am 27.02.24 um 23:40 schrieb Dmitry Baryshkov: Hello, We are currently looking at checking and/or possibly redesigning the way the MSM DRM driver handles the HPD events and link

Re: DisplayPort: handling of HPD events / link training

2024-07-16 Thread Thomas Zimmermann
that bug me. It means that drivers might respond differently to similar devices. Or that there might be minor bugs here and there. -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew

Re: [PATCH v2 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-06 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/video

Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

2024-05-06 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/v

Re: [PATCH v1 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-03 Thread Thomas Zimmermann
Hi Am 03.05.24 um 00:26 schrieb Easwar Hariharan: On 5/2/2024 3:46 AM, Thomas Zimmermann wrote: Am 30.04.24 um 19:38 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to

Re: [PATCH v1 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-02 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/video

Re: [PATCH v1 11/12] fbdev/smscufx: Make I2C terminology more inclusive

2024-05-02 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/v

Re: [PATCH v1 02/12] drm/gma500: Make I2C terminology more inclusive

2024-05-02 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/gpu/

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 22:58 schrieb Dmitry Osipenko: On 2/27/24 13:14, Thomas Zimmermann wrote: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking in DRM's console emulation. Similar

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-28 Thread Thomas Zimmermann
Hi Am 27.02.24 um 19:14 schrieb Dmitry Osipenko: Hello, Thank you for the patches! On 2/27/24 13:14, Thomas Zimmermann wrote: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Thomas Zimmermann
. Am 27.02.24 um 11:14 schrieb Thomas Zimmermann: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking in DRM's console emulation. Similar changes for vmap and mmap have been posted at [1

[PATCH 13/13] drm/qxl: Do not pin buffer objects for vmap

2024-02-27 Thread Thomas Zimmermann
Pin and vmap are distinct operations. Do not perform a pin as part of the vmap call. This used to be necessary to keep the fbdev buffer in place while it is being updated. Fbdev emulation has meanwhile been fixed to lock the buffer correctly. Same for vunmap. Signed-off-by: Thomas Zimmermann

[PATCH 11/13] drm/client: Pin vmap'ed GEM buffers

2024-02-27 Thread Thomas Zimmermann
uses gem-dma. As DMA-backed GEM buffers do not move, this change is for correctness with little impact in practice. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 09/13] drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()

2024-02-27 Thread Thomas Zimmermann
drivers, as is already the case for vmap and vunmap. This affects gem-shmem, gem-vram, loongson, qxl and radeon. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem.c | 22 -- drivers/gpu/drm/drm_gem_vram_helper.c | 15 +-- drivers/gpu/drm

[PATCH 12/13] drm/gem-vram: Do not pin buffer objects for vmap

2024-02-27 Thread Thomas Zimmermann
the pin calls from the helper's vmap implementation in drm_gem_vram_vmap() and inline the call to drm_gem_vram_kmap_locked(). This gives a vmap helper that only maps the buffer object's memory pages without pinning or locking. Do a similar refactoring for vunmap. Signed-off-by: Thomas Zimmermann

[PATCH 10/13] drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()

2024-02-27 Thread Thomas Zimmermann
memory management could move the buffer object while the update is ongoing. The new vmap_local and vunmap_local helpers hold the buffer object's reservation lock during the buffer update. This prevents moving the buffer object on all memory managers. Signed-off-by: Thomas Zimmermann --- drivers

[PATCH 07/13] drm/qxl: Provide qxl_bo_{pin,unpin}_locked()

2024-02-27 Thread Thomas Zimmermann
Rename __qxl_bo_pin() to qxl_bo_pin_locked() and update all callers. The function will be helpful for implementing the GEM pin callback with correct semantics. Same for __qxl_bo_unpin(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_object.c | 25

[PATCH 05/13] drm/nouveau: Provide nouveau_bo_{pin,unpin}_locked()

2024-02-27 Thread Thomas Zimmermann
Implement pinning without locking in nouveau_bo_pin_locked(). Keep nouveau_bo_pin() for acquiring the buffer object's reservation lock. The new helper will be useful for implementing the GEM pin callback with correct semantics. Same for unpin. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[PATCH 08/13] drm/qxl: Acquire reservation lock in GEM pin/unpin callbacks

2024-02-27 Thread Thomas Zimmermann
. A follow-up patch will fix locking for all GEM code at once. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_prime.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl_prime.c index

[PATCH 06/13] drm/nouveau: Acquire reservation lock in GEM pin/unpin callbacks

2024-02-27 Thread Thomas Zimmermann
of the implementation. A follow-up patch will fix locking for all GEM code at once. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_prime.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm

[PATCH 04/13] drm/msm: Acquire reservation lock in GEM pin/unpin callback

2024-02-27 Thread Thomas Zimmermann
by pushing locking out of the implementation. A follow-up patch will fix locking for all GEM code at once. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_gem.c | 12 ++-- drivers/gpu/drm/msm/msm_gem.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c | 24

[PATCH 03/13] drm/msm: Provide msm_gem_get_pages_locked()

2024-02-27 Thread Thomas Zimmermann
Rename msm_gem_pin_pages_locked() to msm_gem_get_pages_locked(). The function doesn't pin any pages, but only acquires them. Renaming the function makes the old name available. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_gem.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 02/13] drm/gem-vram: Acquire reservation lock in GEM pin/unpin callbacks

2024-02-27 Thread Thomas Zimmermann
of the implementation. A follow-up patch will fix locking for all GEM code at once. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm

[PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Thomas Zimmermann
n o ffbdev-generic to to vmap_local helpers, that code can finally be removed. Tested with amdgpu, nouveau, radeon, simpledrm and vc4. [1] https://patchwork.freedesktop.org/series/106371/ [2] https://patchwork.freedesktop.org/series/116001/ [3] https://patchwork.freedesktop.org/series/8473

[PATCH 01/13] drm/gem-shmem: Acquire reservation lock in GEM pin/unpin callbacks

2024-02-27 Thread Thomas Zimmermann
by pushing locking out of the implementation. A follow-up patch will fix locking for all GEM code at once. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 6 -- include/drm/drm_gem_shmem_helper.h | 16 ++-- 2 files changed, 18 insertions(+), 4

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include

2024-02-26 Thread Thomas Zimmermann
Hi Am 26.02.24 um 13:33 schrieb Lee Jones: On Mon, 26 Feb 2024, Jani Nikula wrote: On Fri, 23 Feb 2024, Lee Jones wrote: On Wed, 21 Feb 2024, Thomas Zimmermann wrote: cc'ing backlight maintainers I cannot review/accept patches like this. Please submit a [RESEND]. I bounced the original

Re: [PATCH v3 1/9] backlight/corgi-lcd: Include

2024-02-21 Thread Thomas Zimmermann
cc'ing backlight maintainers Am 19.02.24 um 10:37 schrieb Thomas Zimmermann: Resolves the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/corgi_lcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH v3 7/9] fbdev: Do not include in header

2024-02-19 Thread Thomas Zimmermann
Forward declare struct page and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 90f348f14a490

[PATCH v3 9/9] fbdev: Clean up include statements in header file

2024-02-19 Thread Thomas Zimmermann
Include mutex.h, printk.h and types.h, remove several unnecessary include statements, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- include/linux/fb.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v3 8/9] fbdev: Clean up forward declarations in header file

2024-02-19 Thread Thomas Zimmermann
Add forward declarations for struct i2c_adapter and struct module, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- include/linux/fb.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include

[PATCH v3 3/9] staging/fbtft: Include

2024-02-19 Thread Thomas Zimmermann
Resolves the proxy include via , which does not require the backlight header. v3: * fix grammar in commit message Signed-off-by: Thomas Zimmermann Acked-by: Jani Nikula Acked-by: Helge Deller Acked-by: Greg Kroah-Hartman --- drivers/staging/fbtft/fb_ssd1351.c | 2 ++ 1 file changed

[PATCH v3 4/9] fbdev: Do not include in header

2024-02-19 Thread Thomas Zimmermann
Forward declare struct backlight_device and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index

[PATCH v3 2/9] drm/nouveau: Include

2024-02-19 Thread Thomas Zimmermann
Resolves the proxy include via , which does not require the backlight header. v3: * fix grammar in commit message Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v3 1/9] backlight/corgi-lcd: Include

2024-02-19 Thread Thomas Zimmermann
Resolves the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/corgi_lcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c index

[PATCH v3 6/9] fbdev: Do not include in header

2024-02-19 Thread Thomas Zimmermann
Forward declare struct notifier_block and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index

[PATCH v3 5/9] fbdev: Do not include in header

2024-02-19 Thread Thomas Zimmermann
Forward declare struct inode and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula Acked-by: Helge Deller --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index

[PATCH v3 0/9] fbdev: Clean up include dependencies in header

2024-02-19 Thread Thomas Zimmermann
of their source files. v3: * include backlight.h in corgi-lcd (kernel test robot) * grammar fixes in commit messages v2: * include backlight.h in fbtft (kernel test robot) Thomas Zimmermann (9): backlight/corgi-lcd: Include drm/nouveau: Include staging/fbtft: Include fbdev: Do

Re: [PATCH v2 0/8] fbdev: Clean up include dependencies in header

2024-02-19 Thread Thomas Zimmermann
A-b'd by Helge via email Acked-by: Helge Deller Am 13.02.24 um 09:42 schrieb Thomas Zimmermann: Remove unnecessary dependencies in the include statements of the header file . Several files throughout the kernel include the fbdev header, so reducing dependencies positively affects other

Re: [PATCH v2 2/8] staging/fbtft: Include

2024-02-14 Thread Thomas Zimmermann
Am 13.02.24 um 09:42 schrieb Thomas Zimmermann: Resolved the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann Acked by Jani via IRC Acked-by: Jani Nikula --- drivers/staging/fbtft/fb_ssd1351.c | 2 ++ 1 file changed, 2 insertions

[PATCH v2 5/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct notifier_block and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index f269ba5202809

[PATCH v2 3/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct backlight_device and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 2ce2f5c2fca9a

[PATCH v2 8/8] fbdev: Clean up include statements in header file

2024-02-13 Thread Thomas Zimmermann
Include mutex.h, printk.h and types.h, remove several unnecessary include statements, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux

[PATCH v2 7/8] fbdev: Clean up forward declarations in header file

2024-02-13 Thread Thomas Zimmermann
Add forward declarations for struct i2c_adapter and struct module, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/linux/fb.h b/include/linux

[PATCH v2 6/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct page and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 90f348f14a490..42155898374b1 100644

[PATCH v2 4/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct inode and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 7380d959c5d53..f269ba5202809 100644

[PATCH v2 2/8] staging/fbtft: Include

2024-02-13 Thread Thomas Zimmermann
Resolved the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann --- drivers/staging/fbtft/fb_ssd1351.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c index

[PATCH v2 1/8] drm/nouveau: Include

2024-02-13 Thread Thomas Zimmermann
Resolved the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm

[PATCH v2 0/8] fbdev: Clean up include dependencies in header

2024-02-13 Thread Thomas Zimmermann
: * include backlight.h in fbtft (kernel test robot) Thomas Zimmermann (8): drm/nouveau: Include staging/fbtft: Include fbdev: Do not include in header fbdev: Do not include in header fbdev: Do not include in header fbdev: Do not include in header fbdev: Clean up forward

[PATCH 3/7] fbdev: Do not include in header

2024-02-12 Thread Thomas Zimmermann
Forward declare struct inode and remove the include statement. Signed-off-by: Thomas Zimmermann --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 7380d959c5d53..f269ba5202809 100644 --- a/include/linux/fb.h

[PATCH 5/7] fbdev: Do not include in header

2024-02-12 Thread Thomas Zimmermann
Forward declare struct page and remove the include statement. Signed-off-by: Thomas Zimmermann --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 90f348f14a490..42155898374b1 100644 --- a/include/linux/fb.h

[PATCH 7/7] fbdev: Clean up include statements in header file

2024-02-12 Thread Thomas Zimmermann
Include mutex.h, printk.h and types.h, remove several unnecessary include statements, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann --- include/linux/fb.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/fb.h b/include/linux/fb.h

[PATCH 0/7] fbdev: Clean up include dependencies in header

2024-02-12 Thread Thomas Zimmermann
Remove unnecessary dependencies in the include statements of the header file . Several files throughout the kernel include the fbdev header, so reducing dependencies positively affects other subsystems as well. Also fix up nouveau, which needs backlight.h in one of its source files. Thomas

[PATCH 6/7] fbdev: Clean up forward declarations in header file

2024-02-12 Thread Thomas Zimmermann
Add forward declarations for struct i2c_adapter and struct module, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann --- include/linux/fb.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 42155898374b1

[PATCH 1/7] drm/nouveau: Include

2024-02-12 Thread Thomas Zimmermann
Resolved the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index

[PATCH 4/7] fbdev: Do not include in header

2024-02-12 Thread Thomas Zimmermann
Forward declare struct notifier_block and remove the include statement. Signed-off-by: Thomas Zimmermann --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index f269ba5202809..90f348f14a490 100644 --- a/include

[PATCH 2/7] fbdev: Do not include in header

2024-02-12 Thread Thomas Zimmermann
Forward declare struct backlight_device and remove the include statement. Signed-off-by: Thomas Zimmermann --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 2ce2f5c2fca9a..7380d959c5d53 100644 --- a/include

Re: [PATCH 3/5] drm/ttm: replace busy placement with flags v6

2024-01-17 Thread Thomas Zimmermann
König Signed-off-by: Somalapuram Amaranath For the VRAM helpers: Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 11 +--- drivers/gpu/drm/drm_gem_vram_helper.c | 2 - drivers/gpu/drm/i915/gem

Re: [Nouveau] [PATCH v3 00/16] drm: Convert to platform remove callback returning void

2023-11-21 Thread Thomas Zimmermann
into drm-misc-next. Best regards Thomas Best regards Uwe -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg

Re: [Nouveau] [PATCH v2] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Thomas Zimmermann
the drivers that are not maintained through drm-misc. Acked-by: Jani Nikula Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: Russell King Cc: Lucas Stach Cc: Christian Gmeiner Cc: Inki Dae Cc: Seung-W

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
f my patch. It hand the right of control back to the graphic developer. -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) OpenPGP

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
. So this is probably the second usage of my patch. It hand the right of control back to the graphic developer. -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 05:08 schrieb suijingfeng: Hi, On 2023/9/5 23:05, Thomas Zimmermann wrote: However, on modern Linux systems the primary display does not really exist. 'Primary' is the device that is available via VGA, VESA or EFI. I may miss the point, what do you means by choose

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 04:34 schrieb suijingfeng: On 2023/9/5 23:05, Thomas Zimmermann wrote: Hi Am 05.09.23 um 15:30 schrieb suijingfeng: Hi, On 2023/9/5 18:45, Thomas Zimmermann wrote: Hi Am 04.09.23 um 21:57 schrieb Sui Jingfeng: From: Sui Jingfeng On a machine with multiple GPUs

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Thomas Zimmermann
Hi Am 06.09.23 um 04:14 schrieb suijingfeng: Hi, On 2023/9/5 23:05, Thomas Zimmermann wrote: However, on modern Linux systems the primary display does not really exist. No, it do exist.  X server need to know which one is the primary GPU. The '*' character at the of (4@0:0:0) PCI device

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-05 Thread Thomas Zimmermann
Hi Am 05.09.23 um 15:30 schrieb suijingfeng: Hi, On 2023/9/5 18:45, Thomas Zimmermann wrote: Hi Am 04.09.23 um 21:57 schrieb Sui Jingfeng: From: Sui Jingfeng On a machine with multiple GPUs, a Linux user has no control over which one is primary at boot time. This series tries to solve

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-05 Thread Thomas Zimmermann
pci/vfio_pci_core.c | 2 +- include/linux/vgaarb.h| 8 ++- 14 files changed, 210 insertions(+), 19 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, And

Re: [Nouveau] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-05 Thread Thomas Zimmermann
43 -- drivers/vfio/pci/vfio_pci_core.c | 2 +- include/linux/vgaarb.h| 8 ++- 14 files changed, 210 insertions(+), 19 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germ

Re: [Nouveau] [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-23 Thread Thomas Zimmermann
following through with this anyway, I'm firmly in the camp the name should be "drm" and nothing else. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Ge

Re: [Nouveau] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-23 Thread Thomas Zimmermann
.h | 2 +- include/drm/drm_crtc.h| 4 +- 194 files changed, 1296 insertions(+), 1264 deletions(-) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90

Re: [Nouveau] [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-23 Thread Thomas Zimmermann
Hi Am 13.07.23 um 17:14 schrieb Tvrtko Ursulin: On 13/07/2023 16:09, Thomas Zimmermann wrote: Hi Am 13.07.23 um 16:41 schrieb Sean Paul: On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: hello Sean, On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: I'd really prefer

Re: [Nouveau] [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-23 Thread Thomas Zimmermann
| Uwe Kleine-König| Industrial Linux Solutions | https://www.pengutronix.de/ | -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien M

Re: [Nouveau] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-23 Thread Thomas Zimmermann
1296 insertions(+), 1264 deletions(-) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) OpenPGP_signature Description: OpenPGP digital signature

Re: [Nouveau] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-23 Thread Thomas Zimmermann
for example amdgpu_device_get_pcie_replay_count()). If folks insist on following through with this anyway, I'm firmly in the camp the name should be "drm" and nothing else. Up to now positive feedback is in the majority. Best regards Uwe -- Thomas Zimmermann Graphics Driver Developer

Re: [Nouveau] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-20 Thread Thomas Zimmermann
Hi, for the whole series: Reviewed-by: Thomas Zimmermann Please see my comment on the patches to tiny/. Let me know if you want me to merge this patchset into drm-misc-next. Best regards Thomas Am 07.05.23 um 18:25 schrieb Uwe Kleine-König: Hello, this patch series adapts the platform

[Nouveau] [PATCH v3 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-05-04 Thread Thomas Zimmermann
m fbdev helpers") Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Alex Deucher Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Laurent Pinchart Cc: Jani Nikula Cc: Dave Airlie Cc: Evan Quan Cc: Christian König

[Nouveau] [PATCH v2 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-05-04 Thread Thomas Zimmermann
m fbdev helpers") Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Alex Deucher Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Laurent Pinchart Cc: Jani Nikula Cc: Dave Airlie Cc: Evan Quan Cc: Christian König

Re: [Nouveau] [Intel-gfx] [PATCH v2 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-05-04 Thread Thomas Zimmermann
Hi Am 18.01.23 um 20:21 schrieb Rodrigo Vivi: On Thu, Jan 12, 2023 at 09:11:55PM +0100, Thomas Zimmermann wrote: Set the framebuffer info for drivers that support VGA switcheroo. Only affects the amdgpu and nouveau drivers, which use VGA switcheroo and generic fbdev emulation. For other

Re: [Nouveau] [PATCH v2 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose

2023-01-17 Thread Thomas Zimmermann
Hi Am 17.01.23 um 10:44 schrieb Lukas Wunner: On Thu, Jan 12, 2023 at 09:11:56PM +0100, Thomas Zimmermann wrote: Several lastclose helpers call vga_switcheroo_process_delayed_switch(). It's better to call the helper from drm_lastclose() after the kernel client's screen has been restored

Re: [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

2023-01-17 Thread Thomas Zimmermann
Hi Am 16.01.23 um 21:47 schrieb Sam Ravnborg: Hi Thomas. On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote: A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies. Where possible, remove

Re: [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

2023-01-17 Thread Thomas Zimmermann
Hi Am 16.01.23 um 19:37 schrieb Alex Deucher: On Mon, Jan 16, 2023 at 11:20 AM Jani Nikula wrote: On Mon, 16 Jan 2023, Thomas Zimmermann wrote: A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies. Where

[Nouveau] [PATCH 21/22] drm/vboxvideo: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 20/22] drm/udl: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 19/22] drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 18/22] drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 17/22] drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 16/22] drm/shmobile: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 11/22] drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 22/22] drm/crtc-helper: Remove most include statements from drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Remove most include statements from crm_crtc_helper.h and forward- declare the contained types in drm_crtc_helper.h. Only keep for the definition of 'bool'. Suggested-by: Sam Ravnborg Signed-off-by: Thomas Zimmermann --- include/drm/drm_crtc_helper.h | 14 +- 1 file changed, 9

[Nouveau] [PATCH 10/22] drm/ingenic: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 15/22] drm/rockchip: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 14/22] drm/radeon: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 09/22] drm/i2c/ch7006: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 08/22] drm/gma500: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 13/22] drm/nouveau: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 03/22] drm/amdgpu: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 12/22] drm/logicvc: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 06/22] drm/ast: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 02/22] drm: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
, includes for lower_32_bits(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_lease.c| 2 +- drivers/gpu/drm/drm_plane_helper.c | 1 - include/drm/drm_fixed.h| 1 + 4 files changed, 2 insertions(+), 3 deletions(-) diff --git

[Nouveau] [PATCH 07/22] drm/bridge: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

[Nouveau] [PATCH 05/22] drm/aspeed: Remove unnecessary include statements for drm_crtc_helper.h

2023-01-16 Thread Thomas Zimmermann
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann --- drivers/gpu

  1   2   3   4   5   6   7   8   >