Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-20 Thread Andi Shyti
Hi Sui, On Tue, Jun 06, 2023 at 06:27:05PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/6/6 10:06, Sui Jingfeng wrote: > > Originally, I also want to express the opinion. > > > Originally,  I want to express the same opinion as you told me. > > Because vga_iostate_to_str() function is taking u

Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-20 Thread Sui Jingfeng
Hi, On 2023/6/6 06:16, Andi Shyti wrote: Hi Sui, On Mon, Jun 05, 2023 at 04:58:30AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng To keep consistent with vga_iostate_to_str() function, the third argument of vga_str_to_iostate() function should be 'unsigned int *'. I think the real reason is

Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-20 Thread Sui Jingfeng
Hi, On 2023/6/7 03:49, Bjorn Helgaas wrote: Match the subject line style: $ git log --oneline drivers/pci/vgaarb.c f321c35feaee PCI/VGA: Replace full MIT license text with SPDX identifier d5109fe4d1ec PCI/VGA: Use unsigned format string to print lock counts 4e6c91847a7f PCI/VGA: Log

Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-20 Thread Andi Shyti
Hi Sui, On Mon, Jun 05, 2023 at 04:58:30AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > To keep consistent with vga_iostate_to_str() function, the third argument > of vga_str_to_iostate() function should be 'unsigned int *'. I think the real reason is not to keep consistent with vga_iost

Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-20 Thread Sui Jingfeng
Hi, On 2023/6/6 10:06, Sui Jingfeng wrote: Originally, I also want to express the opinion. Originally,  I want to express the same opinion as you told me. Because vga_iostate_to_str() function is taking unsigned int parameter. so, I think, using 'unsigned int *' type as the third parameter

Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-06 Thread Bjorn Helgaas
Match the subject line style: $ git log --oneline drivers/pci/vgaarb.c f321c35feaee PCI/VGA: Replace full MIT license text with SPDX identifier d5109fe4d1ec PCI/VGA: Use unsigned format string to print lock counts 4e6c91847a7f PCI/VGA: Log bridge control messages when adding devices dc59