Re: [Nouveau] [Mesa-dev] [PATCH mesa 1/6] tgsi_build: Fix return of uninitialized memory in tgsi_*_instruction_memory

[Nicolai Hähnle]

On 16.03.2016 04:23, Hans de Goede wrote:

tgsi_default_instruction_memory / tgsi_build_instruction_memory were
returning uninitialized memory for tgsi_instruction_memory.Texture and
tgsi_instruction_memory.Format. Note 0 means not set, and thus is a
correct default initializer for these.

Fixes: 3243b6fc97 ("tgsi: add Texture and Format to tgsi_instruction_memory")
Cc: Nicolai Hähnle <nicolai.haeh...@amd.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>

Thanks.

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com>

---
  src/gallium/auxiliary/tgsi/tgsi_build.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c 
b/src/gallium/auxiliary/tgsi/tgsi_build.c
index a3e659b..7e30bb6 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_build.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_build.c
@@ -781,6 +781,8 @@ tgsi_default_instruction_memory( void )
     struct tgsi_instruction_memory instruction_memory;

     instruction_memory.Qualifier = 0;
+   instruction_memory.Texture = 0;
+   instruction_memory.Format = 0;
     instruction_memory.Padding = 0;

     return instruction_memory;
@@ -796,6 +798,8 @@ tgsi_build_instruction_memory(
     struct tgsi_instruction_memory instruction_memory;

     instruction_memory.Qualifier = qualifier;
+   instruction_memory.Texture = 0;
+   instruction_memory.Format = 0;
     instruction_memory.Padding = 0;
     instruction->Memory = 1;

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau