Re: [Nouveau] [PATCH] Reflow logic to make it easier to follow

2010-07-30 Thread Francisco Jerez
Tomas Carnecky writes: > The control flow was: > > if (!y) { > ppix = ... > } > > if (y) { > ... > } else if (x) { > use ppix for something > } else { > use ppix for something > } > > Merge the if(!y) block with the two else branches. This avoids > a false-positive in the clang static ana

[Nouveau] [PATCH] Reflow logic to make it easier to follow

2010-07-29 Thread Tomas Carnecky
The control flow was: if (!y) { ppix = ... } if (y) { ... } else if (x) { use ppix for something } else { use ppix for something } Merge the if(!y) block with the two else branches. This avoids a false-positive in the clang static analyzer, it can't know that !y and x are mutually exclus