Re: [Nouveau] [PATCH] drm/nouveau/bios: use size provided by _ROM method

2012-10-21 Thread Lekensteyn
On Sunday 21 October 2012 14:20:05 Marcin Slusarz wrote: > BTW, _ROM method from https://lkml.org/lkml/2012/10/21/11 multiplies length > by 8, so maybe we can read 32kB in one batch? > > Marcin That holds for that specific model, but it is not standard (in ACPI). Ben Skeggs has a laptop (Lenovo?

Re: [Nouveau] [PATCH] drm/nouveau/bios: use size provided by _ROM method

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 12:53:15PM +0200, Lekensteyn wrote: > From: Peter Wu > > Since commit "drm/nouveau/bios: attempt to fetch entire acpi rom image in one > shot", the ACPI spec is broken in order to gain speed. In theory, since the > _ROM method is supposed to return 4 KiB only, the returned

[Nouveau] [PATCH] drm/nouveau/bios: use size provided by _ROM method

2012-10-21 Thread Lekensteyn
From: Peter Wu Since commit "drm/nouveau/bios: attempt to fetch entire acpi rom image in one shot", the ACPI spec is broken in order to gain speed. In theory, since the _ROM method is supposed to return 4 KiB only, the returned buffer size could be less than the requested length. This could lead