Re: [Nouveau] [PATCH] drm/nouveau/bl: Fix oops on driver unbind

2018-03-18 Thread Pierre Moreau
Hey Lukas, > Sorry Pierre, I missed this question and am seeing it only now on > saving the message away: No worries, and thank you for the great explanation! I’ll definitely make a mental note to try unloading Nouveau, whenever writing/testing similar patches. Thanks, Pierre signature.asc Des

Re: [Nouveau] [PATCH] drm/nouveau/bl: Fix oops on driver unbind

2018-03-17 Thread Lukas Wunner
On Mon, Feb 19, 2018 at 10:38:04AM +0100, Pierre Moreau wrote: > My bad; I did test suspend/resume, but not unbinding. Shouldn???t that > happen on shutdown as well, as the driver gets unloaded? I don???t remember > seeing that issue there though. Sorry Pierre, I missed this question and am seeing

Re: [Nouveau] [PATCH] drm/nouveau/bl: Fix oops on driver unbind

2018-03-15 Thread Ben Skeggs
On 14 March 2018 at 21:54, Lukas Wunner wrote: > On Mon, Feb 19, 2018 at 10:38:04AM +0100, Pierre Moreau wrote: >> On 2018-02-17 13:40, Lukas Wunner wrote: >> > Unbinding nouveau on a dual GPU MacBook Pro oopses because we iterate >> > over the bl_connectors list in nouveau_backlight_exit() but sk

Re: [Nouveau] [PATCH] drm/nouveau/bl: Fix oops on driver unbind

2018-03-14 Thread Lukas Wunner
On Mon, Feb 19, 2018 at 10:38:04AM +0100, Pierre Moreau wrote: > On 2018-02-17 13:40, Lukas Wunner wrote: > > Unbinding nouveau on a dual GPU MacBook Pro oopses because we iterate > > over the bl_connectors list in nouveau_backlight_exit() but skipped > > initializing it in nouveau_backlight_init()

Re: [Nouveau] [PATCH] drm/nouveau/bl: Fix oops on driver unbind

2018-02-19 Thread Pierre Moreau
My bad; I did test suspend/resume, but not unbinding. Shouldn’t that happen on shutdown as well, as the driver gets unloaded? I don’t remember seeing that issue there though. On 2018-02-17 — 13:40, Lukas Wunner wrote: > Unbinding nouveau on a dual GPU MacBook Pro oopses because we iterate > over t

[Nouveau] [PATCH] drm/nouveau/bl: Fix oops on driver unbind

2018-02-17 Thread Lukas Wunner
Unbinding nouveau on a dual GPU MacBook Pro oopses because we iterate over the bl_connectors list in nouveau_backlight_exit() but skipped initializing it in nouveau_backlight_init(). Stacktrace for posterity: BUG: unable to handle kernel NULL pointer dereference at 0010 IP: no