Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Michael Weirauch
2013/2/19 Marcin Slusarz : > This patch is only for 3.7 and 3.8 kernels. Nouveau/master contains refactored > fence code which will be submitted for 3.9. Then, nevertheless, nouveau/master - which apparently carries identical code - doesn't fix the issue (fdo#59168) for me. (Or I screw up big time

Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 10:09:12PM +0100, Michael Weirauch wrote: > 2013/2/19 Marcin Slusarz : > > Yay. It will probably fix > > https://bugs.freedesktop.org/show_bug.cgi?id=59168. > > (note: it doesn't apply on top of nouveau/master) > > Please correct me if I am wrong, but doesn't nv84_fence_[r

Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Michael Weirauch
2013/2/19 Marcin Slusarz : > Yay. It will probably fix https://bugs.freedesktop.org/show_bug.cgi?id=59168. > (note: it doesn't apply on top of nouveau/master) Please correct me if I am wrong, but doesn't nv84_fence_[resume,suspend] on current nouveau-3.8.0_rc7 (master) which is "used" by nvc0_fenc

Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 10:20:55AM +, Maarten Lankhorst wrote: > Everywhere else the constant is multiplied by 16/4, so it looks like > nvc0_fence_suspend/resume is buggy here. > > Signed-off-by: Maarten Lankhorst > Cc: sta...@vger.kernel.org [3.7+] Yay. It will probably fix https://bugs.fre

[Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Maarten Lankhorst
Everywhere else the constant is multiplied by 16/4, so it looks like nvc0_fence_suspend/resume is buggy here. Signed-off-by: Maarten Lankhorst Cc: sta...@vger.kernel.org [3.7+] --- diff --git a/drivers/gpu/drm/nouveau/nvc0_fence.c b/drivers/gpu/drm/nouveau/nvc0_fence.c index 85a0e78..4f46d8b 10