Re: [Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-17 Thread Marcin Ślusarz
17 paź 2012 06:33, "Ben Skeggs" napisał(a): > > On Tue, Oct 16, 2012 at 11:45:30PM +0200, Marcin Slusarz wrote: > > Signed-off-by: Marcin Slusarz > NACK on this one. I did ponder doing such a thing myself when I first > added the defines for the class names too, and decided against it as > this

Re: [Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-17 Thread Ben Skeggs
On Tue, Oct 16, 2012 at 11:45:30PM +0200, Marcin Slusarz wrote: > Signed-off-by: Marcin Slusarz NACK on this one. I did ponder doing such a thing myself when I first added the defines for the class names too, and decided against it as this will (at some point) become a user-facing header, and I w

[Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-16 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/core/include/core/class.h | 31 +++ 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/include/core/class.h b/drivers/gpu/drm/nouveau/core/include/core/class.h index 6180ae9..5b