Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-19 Thread Danilo Krummrich
On 9/16/23 16:24, Dan Carpenter wrote: On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: Hi Dan, On 9/15/23 14:59, Dan Carpenter wrote: The u_memcpya() function is supposed to return error pointers on error. Returning NULL will lead to an Oops. Fixes: 68132cc6d1bc

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-18 Thread Lyude Paul
Reviewed-by: Lyude Paul I assume you need me to push this to drm-misc? On Fri, 2023-09-15 at 15:59 +0300, Dan Carpenter wrote: > The u_memcpya() function is supposed to return error pointers on > error. Returning NULL will lead to an Oops. > > Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-16 Thread Danilo Krummrich
On 9/16/23 16:26, Dan Carpenter wrote: On Sat, Sep 16, 2023 at 05:24:04PM +0300, Dan Carpenter wrote: On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: Hi Dan, On 9/15/23 14:59, Dan Carpenter wrote: The u_memcpya() function is supposed to return error pointers on error.

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-16 Thread Dan Carpenter
On Sat, Sep 16, 2023 at 05:24:04PM +0300, Dan Carpenter wrote: > On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: > > Hi Dan, > > > > On 9/15/23 14:59, Dan Carpenter wrote: > > > The u_memcpya() function is supposed to return error pointers on > > > error. Returning NULL will

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-16 Thread Dan Carpenter
On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: > Hi Dan, > > On 9/15/23 14:59, Dan Carpenter wrote: > > The u_memcpya() function is supposed to return error pointers on > > error. Returning NULL will lead to an Oops. > > > > Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-15 Thread Danilo Krummrich
Hi Dan, On 9/15/23 14:59, Dan Carpenter wrote: The u_memcpya() function is supposed to return error pointers on error. Returning NULL will lead to an Oops. Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use vmemdup_user") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/nouveau_drv.h | 2

[Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-15 Thread Dan Carpenter
The u_memcpya() function is supposed to return error pointers on error. Returning NULL will lead to an Oops. Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use vmemdup_user") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/nouveau_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)