Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-28 Thread Arnd Bergmann
On Thu, May 28, 2020 at 7:37 AM Dave Airlie wrote: > > On Thu, 28 May 2020 at 00:36, Arnd Bergmann wrote: > > > > On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > > > > > Isn't this already fixed by > > > > > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Dave Airlie
On Thu, 28 May 2020 at 00:36, Arnd Bergmann wrote: > > On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > > > Isn't this already fixed by > > > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 > > Ok, I see that fixes the link error, but I when I crea

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > Isn't this already fixed by > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 Ok, I see that fixes the link error, but I when I created my fix, that did not seem like the correct solution because it

Re: [Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Ilia Mirkin
Isn't this already fixed by https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 On Wed, May 27, 2020 at 9:43 AM Arnd Bergmann wrote: > > Calling directly into the fbdev stack only works when the > fbdev layer is built into the kernel as well, or both are > lo

[Nouveau] [PATCH] nouveau: add fbdev dependency

2020-05-27 Thread Arnd Bergmann
Calling directly into the fbdev stack only works when the fbdev layer is built into the kernel as well, or both are loadable modules: drivers/gpu/drm/nouveau/nouveau_drm.o: in function `nouveau_drm_probe': nouveau_drm.c:(.text+0x1f90): undefined reference to `remove_conflicting_pci_framebuffers'