Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-05-18 Thread Linus Torvalds
On Mon, May 18, 2020 at 3:35 PM Steven Rostedt wrote: > > Linus, > > Are you OK with this patch? Yup, I don't care deeply either way, as long as we can get rid of the warning. Linus ___ Nouveau mailing list Nouveau@lists.freedesktop.org

Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-05-18 Thread Steven Rostedt
On Mon, 18 May 2020 11:52:47 -0700 Nick Desaulniers wrote: > On Mon, May 18, 2020 at 2:31 AM Nathan Chancellor > wrote: > > > > On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > > > When building with Clang + -Wtautological-compare and > > > CONFIG_CPUMASK_OFFSTACK unset: >

Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-05-18 Thread Nathan Chancellor
On Wed, Apr 08, 2020 at 01:53:23PM -0700, Nathan Chancellor wrote: > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > equal to a null pointer is always false [-Wtautological-pointer

Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-04-24 Thread Sedat Dilek
On Wed, Apr 8, 2020 at 11:36 PM Sedat Dilek wrote: [ ... ] > Feel free to add appropriate credits: > >Tested-by: Sedat Dilek > Re-tested with Linux v5.7-rc1 which shows this warning - with GCC v9.3 and LLVM/Clang v10.0.0 (and snapshot/pre-release of v10.0.1) on Debian/testing AMD64. - Sed

[Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-04-24 Thread Nathan Chancellor
When building with Clang + -Wtautological-compare and CONFIG_CPUMASK_OFFSTACK unset: arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' equal to a null pointer is always false [-Wtautological-pointer-compare] if (downed_cpus == NULL && ^~~

Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-04-24 Thread Sedat Dilek
On Wed, Apr 8, 2020 at 10:53 PM Nathan Chancellor wrote: > > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > Hi Nathan, thanks for the quick patch. I can confirm I have no CONFIG_CPUMASK_OFFSTACK set. Regards, - Sedat - > arch/x86/mm/mmio-mod.c:375:6:

Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-04-24 Thread Sedat Dilek
On Wed, Apr 8, 2020 at 11:12 PM Sedat Dilek wrote: > > On Wed, Apr 8, 2020 at 10:53 PM Nathan Chancellor > wrote: > > > > When building with Clang + -Wtautological-compare and > > CONFIG_CPUMASK_OFFSTACK unset: > > > > Hi Nathan, > > thanks for the quick patch. > > I can confirm I have no CONFIG_

Re: [Nouveau] [PATCH] x86: mmiotrace: Use cpumask_available for cpumask_var_t variables

2020-04-15 Thread Steven Rostedt
On Wed, 8 Apr 2020 13:53:23 -0700 Nathan Chancellor wrote: > When building with Clang + -Wtautological-compare and > CONFIG_CPUMASK_OFFSTACK unset: > > arch/x86/mm/mmio-mod.c:375:6: warning: comparison of array 'downed_cpus' > equal to a null pointer is always false [-Wtautological-pointer-comp