Re: [Nouveau] [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

2019-06-15 Thread Christoph Hellwig
On Fri, Jun 14, 2019 at 07:21:54PM -0700, John Hubbard wrote: > On 6/13/19 2:43 AM, Christoph Hellwig wrote: > > Keep the physical address allocation that hmm_add_device does with the > > rest of the resource code, and allow future reuse of it without the hmm > > wrapper. > > > > Signed-off-by: Ch

Re: [Nouveau] [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

2019-06-13 Thread Christoph Hellwig
On Thu, Jun 13, 2019 at 07:16:35PM +, Jason Gunthorpe wrote: > I wonder if IORES_DESC_DEVICE_PRIVATE_MEMORY should be a function > argument? No. The only reason to use this function is to allocate the fake physical address space for the device private memory case. If you'd deal with real res

Re: [Nouveau] [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

2019-06-13 Thread Jason Gunthorpe
On Thu, Jun 13, 2019 at 11:43:09AM +0200, Christoph Hellwig wrote: > Keep the physical address allocation that hmm_add_device does with the > rest of the resource code, and allow future reuse of it without the hmm > wrapper. > > Signed-off-by: Christoph Hellwig > include/linux/ioport.h | 2 ++ >

[Nouveau] [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

2019-06-13 Thread Christoph Hellwig
Keep the physical address allocation that hmm_add_device does with the rest of the resource code, and allow future reuse of it without the hmm wrapper. Signed-off-by: Christoph Hellwig --- include/linux/ioport.h | 2 ++ kernel/resource.c | 39 +++ mm/hmm