On 11/13/23 08:22, Christian König wrote:
Am 10.11.23 um 17:57 schrieb Danilo Krummrich:
On 11/10/23 09:50, Christian König wrote:
[SNIP]
Another issue Christian brought up is that something intended to be embeddable
(a base class) shouldn't really have its own refcount. I think that's a
Am 10.11.23 um 17:57 schrieb Danilo Krummrich:
On 11/10/23 09:50, Christian König wrote:
[SNIP]
Another issue Christian brought up is that something intended to
be embeddable (a base class) shouldn't really have its own
refcount. I think that's a valid point. If you at some point need
to
On 11/10/23 09:50, Christian König wrote:
Am 09.11.23 um 19:34 schrieb Danilo Krummrich:
On 11/9/23 17:03, Christian König wrote:
Am 09.11.23 um 16:50 schrieb Thomas Hellström:
[SNIP]
Did we get any resolution on this?
FWIW, my take on this is that it would be possible to get GPUVM to
On 11/10/23 11:52, Thomas Hellström wrote:
On 11/10/23 11:42, Christian König wrote:
Am 10.11.23 um 10:39 schrieb Thomas Hellström:
[SNIP]
I was thinking more of the general design of a base-class that needs to be
refcounted. Say a driver vm that inherits from gpu-vm, gem_object and yet
On 11/10/23 10:39, Thomas Hellström wrote:
On 11/10/23 09:50, Christian König wrote:
Am 09.11.23 um 19:34 schrieb Danilo Krummrich:
On 11/9/23 17:03, Christian König wrote:
Am 09.11.23 um 16:50 schrieb Thomas Hellström:
[SNIP]
Did we get any resolution on this?
FWIW, my take on this is
On 11/10/23 11:42, Christian König wrote:
Am 10.11.23 um 10:39 schrieb Thomas Hellström:
[SNIP]
I was thinking more of the general design of a base-class that needs
to be refcounted. Say a driver vm that inherits from gpu-vm,
gem_object and yet another base-class that supplies its own
Am 10.11.23 um 10:39 schrieb Thomas Hellström:
[SNIP]
I was thinking more of the general design of a base-class that needs
to be refcounted. Say a driver vm that inherits from gpu-vm,
gem_object and yet another base-class that supplies its own refcount.
What's the best-practice way to do
On 11/10/23 09:50, Christian König wrote:
Am 09.11.23 um 19:34 schrieb Danilo Krummrich:
On 11/9/23 17:03, Christian König wrote:
Am 09.11.23 um 16:50 schrieb Thomas Hellström:
[SNIP]
Did we get any resolution on this?
FWIW, my take on this is that it would be possible to get GPUVM to
Am 09.11.23 um 19:34 schrieb Danilo Krummrich:
On 11/9/23 17:03, Christian König wrote:
Am 09.11.23 um 16:50 schrieb Thomas Hellström:
[SNIP]
Did we get any resolution on this?
FWIW, my take on this is that it would be possible to get GPUVM to
work both with and without internal
On 11/9/23 17:03, Christian König wrote:
Am 09.11.23 um 16:50 schrieb Thomas Hellström:
[SNIP]
Did we get any resolution on this?
FWIW, my take on this is that it would be possible to get GPUVM to work both
with and without internal refcounting; If with, the driver needs a vm close to
Am 09.11.23 um 16:50 schrieb Thomas Hellström:
[SNIP]
Did we get any resolution on this?
FWIW, my take on this is that it would be possible to get GPUVM to
work both with and without internal refcounting; If with, the driver
needs a vm close to resolve cyclic references, if without that's
Danilo, Christian
On 11/6/23 17:42, Danilo Krummrich wrote:
On Mon, Nov 06, 2023 at 04:10:50PM +0100, Christian König wrote:
Am 06.11.23 um 15:11 schrieb Danilo Krummrich:
On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote:
Am 06.11.23 um 13:16 schrieb Danilo Krummrich:
[SNIP]
On Mon, Nov 06, 2023 at 04:10:50PM +0100, Christian König wrote:
> Am 06.11.23 um 15:11 schrieb Danilo Krummrich:
> > On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote:
> > > Am 06.11.23 um 13:16 schrieb Danilo Krummrich:
> > > > [SNIP]
> > > > This reference count just prevents that
Am 06.11.23 um 15:11 schrieb Danilo Krummrich:
On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote:
Am 06.11.23 um 13:16 schrieb Danilo Krummrich:
[SNIP]
This reference count just prevents that the VM is freed as long as other
ressources are attached to it that carry a VM pointer,
On Mon, Nov 06, 2023 at 02:05:13PM +0100, Christian König wrote:
> Am 06.11.23 um 13:16 schrieb Danilo Krummrich:
> > [SNIP]
> > This reference count just prevents that the VM is freed as long as other
> > ressources are attached to it that carry a VM pointer, such as mappings and
> > VM_BOs. The
Am 06.11.23 um 13:16 schrieb Danilo Krummrich:
[SNIP]
This reference count just prevents that the VM is freed as long as other
ressources are attached to it that carry a VM pointer, such as mappings and
VM_BOs. The motivation for that are VM_BOs. For mappings it's indeed a bit
paranoid, but it
On Mon, Nov 06, 2023 at 10:14:29AM +0100, Christian König wrote:
> Am 03.11.23 um 16:34 schrieb Danilo Krummrich:
> [SNIP]
> > >
> > > Especially we most likely don't want the VM to live longer than the
> > > application which originally used it. If you make the GPUVM an
> > > independent object
Am 03.11.23 um 16:34 schrieb Danilo Krummrich:
[SNIP]
Especially we most likely don't want the VM to live longer than the
application which originally used it. If you make the GPUVM an
independent object you actually open up driver abuse for the lifetime
of this.
Right, we don't want that.
On 11/3/23 15:04, Christian König wrote:
Am 03.11.23 um 14:14 schrieb Danilo Krummrich:
On Fri, Nov 03, 2023 at 08:18:35AM +0100, Christian König wrote:
Am 02.11.23 um 00:31 schrieb Danilo Krummrich:
Implement reference counting for struct drm_gpuvm.
From the design point of view what is
Am 03.11.23 um 14:14 schrieb Danilo Krummrich:
On Fri, Nov 03, 2023 at 08:18:35AM +0100, Christian König wrote:
Am 02.11.23 um 00:31 schrieb Danilo Krummrich:
Implement reference counting for struct drm_gpuvm.
From the design point of view what is that good for?
It was discussed in this
On Fri, Nov 03, 2023 at 08:18:35AM +0100, Christian König wrote:
> Am 02.11.23 um 00:31 schrieb Danilo Krummrich:
> > Implement reference counting for struct drm_gpuvm.
>
> From the design point of view what is that good for?
It was discussed in this thread [1].
Essentially, the idea is to make
Am 02.11.23 um 00:31 schrieb Danilo Krummrich:
Implement reference counting for struct drm_gpuvm.
From the design point of view what is that good for?
Background is that the most common use case I see is that this object is
embedded into something else and a reference count is then not
Hi Thomas,
thanks for your timely response on that!
On 11/2/23 18:09, Thomas Hellström wrote:
On Thu, 2023-11-02 at 00:31 +0100, Danilo Krummrich wrote:
Implement reference counting for struct drm_gpuvm.
Signed-off-by: Danilo Krummrich
---
drivers/gpu/drm/drm_gpuvm.c | 44
On Thu, 2023-11-02 at 18:32 +0100, Danilo Krummrich wrote:
> Hi Thomas,
>
> thanks for your timely response on that!
>
> On 11/2/23 18:09, Thomas Hellström wrote:
> > On Thu, 2023-11-02 at 00:31 +0100, Danilo Krummrich wrote:
> > > Implement reference counting for struct drm_gpuvm.
> > >
> > >
On Thu, 2023-11-02 at 00:31 +0100, Danilo Krummrich wrote:
> Implement reference counting for struct drm_gpuvm.
>
> Signed-off-by: Danilo Krummrich
> ---
> drivers/gpu/drm/drm_gpuvm.c | 44 +++-
> --
> drivers/gpu/drm/nouveau/nouveau_uvmm.c | 20 +---
>
On Thu, 2023-11-02 at 00:31 +0100, Danilo Krummrich wrote:
> Implement reference counting for struct drm_gpuvm.
>
> Signed-off-by: Danilo Krummrich
Will port the Xe series over to check that it works properly and get
back with review on this one.
> ---
> drivers/gpu/drm/drm_gpuvm.c
Hi Danilo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 3c6c7ca4508b6cb1a033ac954c50a1b2c97af883]
url:
https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-gpuvm-convert-WARN-to-drm_WARN-variants/20231102-073332
base:
27 matches
Mail list logo