Re: [Nouveau] [RFC PATCH 06/29] clk: Make pstate a pointer to nvkm_pstate

2017-10-08 Thread Karol Herbst
On Sun, Oct 8, 2017 at 1:47 PM, Pierre Moreau wrote: > The patch seems fine but I found it super confusing that sometimes `pstate` is > a pointer (for example `clk->pstate`), sometimes it is an int (for example > `args->v0.pstate`). > yeah I still plan to clean the names up when I find some time

Re: [Nouveau] [RFC PATCH 06/29] clk: Make pstate a pointer to nvkm_pstate

2017-10-08 Thread Pierre Moreau
The patch seems fine but I found it super confusing that sometimes `pstate` is a pointer (for example `clk->pstate`), sometimes it is an int (for example `args->v0.pstate`). On 2017-09-15 — 17:11, Karol Herbst wrote: > We will access the current cstate at least every second and this saves us > som

[Nouveau] [RFC PATCH 06/29] clk: Make pstate a pointer to nvkm_pstate

2017-09-15 Thread Karol Herbst
We will access the current cstate at least every second and this saves us some CPU cycles looking them up every second. v2: Rewording commit message. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/include/nvkm/subdev/clk.h | 4 +++- drm/nouveau/nvkm/engine/device/ctrl.c