Re: [Nouveau] [mesa v2 5/9] nouveau: fix screen creation failure paths

2015-12-06 Thread Ben Skeggs
On 12/07/2015 01:53 PM, Ilia Mirkin wrote: > On Sun, Dec 6, 2015 at 10:48 PM, Ben Skeggs wrote: >> On 12/07/2015 01:40 PM, Ilia Mirkin wrote: >>> This all seems very roundabout... Can't we do this in a somewhat >>> consistent way with the device being cleaned up in one place or >>> another but not

Re: [Nouveau] [mesa v2 5/9] nouveau: fix screen creation failure paths

2015-12-06 Thread Ilia Mirkin
On Sun, Dec 6, 2015 at 10:48 PM, Ben Skeggs wrote: > On 12/07/2015 01:40 PM, Ilia Mirkin wrote: >> This all seems very roundabout... Can't we do this in a somewhat >> consistent way with the device being cleaned up in one place or >> another but not both? > That would be lovely, but not possible.

Re: [Nouveau] [mesa v2 5/9] nouveau: fix screen creation failure paths

2015-12-06 Thread Ben Skeggs
On 12/07/2015 01:40 PM, Ilia Mirkin wrote: > This all seems very roundabout... Can't we do this in a somewhat > consistent way with the device being cleaned up in one place or > another but not both? That would be lovely, but not possible. It has to be cleaned up by the pipe screen destroy() funct

Re: [Nouveau] [mesa v2 5/9] nouveau: fix screen creation failure paths

2015-12-06 Thread Ilia Mirkin
This all seems very roundabout... Can't we do this in a somewhat consistent way with the device being cleaned up in one place or another but not both? On Thu, Nov 26, 2015 at 8:04 PM, Ben Skeggs wrote: > From: Ben Skeggs > > The winsys layer would attempt to cleanup the nouveau_device if screen

[Nouveau] [mesa v2 5/9] nouveau: fix screen creation failure paths

2015-11-26 Thread Ben Skeggs
From: Ben Skeggs The winsys layer would attempt to cleanup the nouveau_device if screen init failed, however, in most paths the pipe driver would have already destroyed it, resulting in accesses to freed memory etc. This commit fixes the problem by allowing the winsys to detect whether the pipe