Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Ben Skeggs
On Sun, Aug 19, 2012 at 11:02:00PM +0200, Marcin Slusarz wrote: Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less wasteful, but didn't take into account already existing off-by-one bugs :). So: - ib_max is the last entry, so we need to

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Marcin Slusarz
On Mon, Aug 20, 2012 at 04:33:24PM +1000, Ben Skeggs wrote: On Sun, Aug 19, 2012 at 11:02:00PM +0200, Marcin Slusarz wrote: Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less wasteful, but didn't take into account already existing

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Ben Skeggs
Am Dienstag, 21. August 2012 schrieb Marcin Slusarz : On Mon, Aug 20, 2012 at 04:33:24PM +1000, Ben Skeggs wrote: On Sun, Aug 19, 2012 at 11:02:00PM +0200, Marcin Slusarz wrote: Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Marcin Slusarz
On Tue, Aug 21, 2012 at 07:13:23AM +1000, Ben Skeggs wrote: Am Dienstag, 21. August 2012 schrieb Marcin Slusarz : On Mon, Aug 20, 2012 at 04:33:24PM +1000, Ben Skeggs wrote: On Sun, Aug 19, 2012 at 11:02:00PM +0200, Marcin Slusarz wrote: Commit drm/nouveau: port all

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Maarten Maathuis
On Mon, Aug 20, 2012 at 11:41 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: On Tue, Aug 21, 2012 at 07:13:23AM +1000, Ben Skeggs wrote: Am Dienstag, 21. August 2012 schrieb Marcin Slusarz : On Mon, Aug 20, 2012 at 04:33:24PM +1000, Ben Skeggs wrote: On Sun, Aug 19, 2012 at

[Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-19 Thread Marcin Slusarz
Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less wasteful, but didn't take into account already existing off-by-one bugs :). So: - ib_max is the last entry, so we need to +1 when calculating number of free entries - nv50_dma_wait already

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-19 Thread Maarten Maathuis
On Sun, Aug 19, 2012 at 11:02 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less wasteful, but didn't take into account already existing off-by-one bugs :). So: - ib_max is the last entry,