Re: [nox-dev] [PATCH] support passing the 64-bit cookie in send_flow_command from Python code

2010-12-12 Thread Romain Lenglet
Hi KK, I format my patches with git-format-patches, and send them using git send-email. Is there any issues with the formatting? Regards, -- Romain Lenglet On 12/13/10 14:57, kk yap wrote: Hi Romain, Thanks for all the patches. I really appreciate these. Personally, I tend to work purely

Re: [nox-dev] [PATCH] support passing the 64-bit cookie in send_flow_command from Python code

2010-12-12 Thread Romain Lenglet
Hi, This is an updated and tested version of this patch for the zaku branch. Do you see any problem with this patch? BR, -- Romain Lenglet On 12/13/10 14:42, romain.leng...@berabera.info wrote: From: Romain Lenglet The C++ implementation allowed passing the 64-bit opaque cookie with every flow

[nox-dev] [PATCH] support passing the 64-bit cookie in send_flow_command from Python code

2010-12-12 Thread romain . lenglet
From: Romain Lenglet The C++ implementation allowed passing the 64-bit opaque cookie with every flow command, but not the Python wrapper. --- src/nox/coreapps/pyrt/context.i |3 ++- src/nox/lib/core.py | 26 ++ 2 files changed, 20 insertions(+), 9

[nox-dev] [PATCH] support passing the 64-bit cookie in send_flow_command from Python code

2010-12-08 Thread romain . lenglet
From: Romain Lenglet The C++ implementation allowed passing the 64-bit opaque cookie with every flow command, but not the Python wrapper. --- src/nox/coreapps/pyrt/context.i |3 ++- src/nox/lib/core.py | 26 ++ 2 files changed, 20 insertions(+), 9

Re: [nox-dev] Matching on NW_TOS doesn't seem to work?

2010-11-21 Thread Romain Lenglet
gnore nw_tos and nw_dst (I'm too lazy to check that right now...). -- Romain Lenglet On Mon, Nov 22, 2010 at 5:59 AM, Aaron Rosen wrote: > Hi Murphy, > > Ok, looking at the Match values in wireshark I do not see a packet that is > applying my first self.install_datapath_flow(); b

Re: [nox-dev] [PATCH] support setting the binding IP address of TCP sockets for passive interfaces

2010-11-10 Thread Romain Lenglet
have no excuse for taking so long to re-submit that patch... ;( BR, -- Romain Lenglet On 11/10/10 18:21, romain.leng...@berabera.info wrote: From: Romain Lenglet Modify the nox_core command line arguments to accept the socket bind address for the ptcp: and pssl: interfaces. This is particularly

[nox-dev] [PATCH] support setting the binding IP address of TCP sockets for passive interfaces

2010-11-10 Thread romain . lenglet
From: Romain Lenglet Modify the nox_core command line arguments to accept the socket bind address for the ptcp: and pssl: interfaces. This is particularly important for the ptcp: method, as it can help improving security and performance in some cases. For instance, if a controller connects

Re: [nox-dev] [PATCH] set the nw_tos field for a flow in extract_flow()

2010-11-10 Thread Romain Lenglet
Hi, This patch is against the zaku branch. This bug also exists in the openflow-1.0 branch. I didn't check if it exists in the destiny branch. On 11/10/10 17:02, romain.leng...@berabera.info wrote: From: Romain Lenglet --- src/nox/lib/util.py |2 ++ 1 files changed, 2 insertions(

[nox-dev] [PATCH] set the nw_tos field for a flow in extract_flow()

2010-11-10 Thread romain . lenglet
From: Romain Lenglet --- src/nox/lib/util.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/nox/lib/util.py b/src/nox/lib/util.py index 076d419..bd0ee5a 100644 --- a/src/nox/lib/util.py +++ b/src/nox/lib/util.py @@ -387,6 +387,7 @@ def extract_flow(ethernet

Re: [nox-dev] NOX packaging issues

2010-08-06 Thread Romain Lenglet
ve. If I can have it now with the above, I will take it. > > Regards > KK Thanks for your comments, Best regards, -- Romain Lenglet ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org

Re: [nox-dev] NOX packaging issues

2010-08-06 Thread Romain Lenglet
ecify: switch.xml, topology.xml, etc. > Besides that, this sounds really good, and I think we could put a lot of > these improvements into the destiny branch (by the way, make dist in destiny > is somewhat improved over master already in that it actually does at least > sort of

[nox-dev] NOX packaging issues

2010-08-06 Thread Romain Lenglet
subdirectories. That one is not too bad, but part of the files in src/nox/ are handled by src/Makefile.am, and the rest is handled by src/nox/Makefile.am, which is confusing. Why not just have one Makefile.am per directory, as usual, and let each Makefile.am handle all the files in its directory, and

Re: [nox-dev] [PATCH] Add support for setting the TCP binding address.

2010-08-05 Thread Romain Lenglet
This patch is based on the openflow-1.0 branch. On 8/6/10 12:24, romain.leng...@berabera.info wrote: From: Romain Lenglet Modify the nox_core command line arguments to accept the socket bind address for the ptcp: and pssl: connection methods. This is particularly important for the ptcp: method

[nox-dev] [PATCH] Add support for setting the TCP binding address.

2010-08-05 Thread romain . lenglet
From: Romain Lenglet Modify the nox_core command line arguments to accept the socket bind address for the ptcp: and pssl: connection methods. This is particularly important for the ptcp: method, as it can help improving security and performance in some cases. For instance, if a controller

Re: [nox-dev] [PATCH] Correctly set the NW_TOS wildcard bit.

2010-08-05 Thread Romain Lenglet
This patch is based on the openflow-1.0 branch. On 8/6/10 12:18, romain.leng...@berabera.info wrote: From: Romain Lenglet Set the OFPFW_NW_TOS bit in the wildcards of a flow definition when no nw_tos attribute is specified, so it doesn't always set nw_tos=0 for the flow in that case. ---

[nox-dev] [PATCH] Correctly set the NW_TOS wildcard bit.

2010-08-05 Thread romain . lenglet
From: Romain Lenglet Set the OFPFW_NW_TOS bit in the wildcards of a flow definition when no nw_tos attribute is specified, so it doesn't always set nw_tos=0 for the flow in that case. --- src/nox/lib/core.py |1 + src/nox/lib/util.py |6 ++ 2 files changed, 7 insertions(