Re: [nox-dev] Contributing to Nox

Woops, I introduced a bug. I was converting 'reason' to host byte order, but it's only 8 bits. This causes it to always be 0 since it turns into a short before ntohs(). I attached the fix, sorry about that. -Derek On 01/13/2011 02:55 PM, kk yap wrote: Thanks. I pushed this. Regards KK On 1

Re: [nox-dev] Contributing to Nox

Thanks. I pushed this. Regards KK On 12 January 2011 21:40, Derek Cormier wrote: > Thanks! I'm glad my patches are decent. > > I've attached another one for destiny: > > In a Flow_removed_event, the fields are taken from an ofp_flow_removed > message, > but a couple of fields were missing (reas

Re: [nox-dev] Contributing to Nox

Thanks! I'm glad my patches are decent. I've attached another one for destiny: In a Flow_removed_event, the fields are taken from an ofp_flow_removed message, but a couple of fields were missing (reason and priority). I added these to the event struct and changed python's flow removed callbac

Re: [nox-dev] Contributing to Nox

Hi All, With Derek's patch, the documentation for destiny branch is more useful for those using Python. Consequently, I have pushed the doxygen documentation for destiny (which include Derek's patch) to replace the one previously generated from zaku. FYI. Regards KK On 11 January 2011 11:43, k

Re: [nox-dev] Contributing to Nox

Hi Derek, Thanks. Great patches as usual. I have pushed them to the destiny branch. Martin and Murphy, I believe I have pushed most (if not all) of Derek's patches at this moment. If anything else is missing, let me know. Thanks. Regards KK On 11 January 2011 07:23, Martin Casado wrote: >

Re: [nox-dev] Contributing to Nox

Derek, Thanks for the patches, these are very helpful. One of us will take a look shortly. .martin Hello, Here are two patches for destiny for the Python API. patch 1: - in pyrt.cc, add datapath id to the dictionaries created by Flow_removed_event and Error_event patch2: - add lots of

Re: [nox-dev] Contributing to Nox

Hello, Here are two patches for destiny for the Python API. patch 1: - in pyrt.cc, add datapath id to the dictionaries created by Flow_removed_event and Error_event patch2: - add lots of doxygen doc strings to core.api - add callback generators for flow mod and flow removed events - change th

Re: [nox-dev] Contributing to Nox

Here's a couple more patches for destiny. 'barrier-reply.tar.gz' - make barrier reply events available to the Python API. 'flow-stats-in.tar.gz' - add a convenience method in component to register for flow stats in events. -Derek On 12/28/2010 01:30 AM, Martin Casado wrote: Thanks KK.

Re: [nox-dev] Contributing to Nox

Thanks KK. I pushed a few edits as well. Hi, I have done that for destiny and pushed the file. Martin, you should probably check the list again. If I have missed you out (since I only exploited git log), do let me know. Regards KK ___ nox-d

Re: [nox-dev] Contributing to Nox

Hi, I have done that for destiny and pushed the file. Martin, you should probably check the list again. If I have missed you out (since I only exploited git log), do let me know. Regards KK On 27 December 2010 08:00, Martin Casado wrote: > On an off (but related) topic, we should maintain a

Re: [nox-dev] Contributing to Nox

On an off (but related) topic, we should maintain an authors file for nox. There have been many good contributions from the community. KK, mind creating one? Hi Derek, Please post on this mailing list. Thanks. Regards KK On 26 December 2010 22:07, Derek Cormier

Re: [nox-dev] Contributing to Nox

Hi Derek, Please post on this mailing list. Thanks. Regards KK On 26 December 2010 22:07, Derek Cormier wrote: > Great. Should I post any future changes here on the Nox board or send them > to a developer like yourself? > > -Derek > > > On 12/27/2010 02:54 PM, kk yap wrote: > > Hi Derek, > >

Re: [nox-dev] Contributing to Nox

Great. Should I post any future changes here on the Nox board or send them to a developer like yourself? -Derek On 12/27/2010 02:54 PM, kk yap wrote: Hi Derek, Thanks. I pushed this to destiny (unstable). Regards KK On 26 December 2010 16:56, Derek Cormier

Re: [nox-dev] Contributing to Nox

Hi Derek, Thanks. I pushed this to destiny (unstable). Regards KK On 26 December 2010 16:56, Derek Cormier wrote: > Woops! I'm not sure how it happened but I somehow messed up the patch > file. Please use this attached one instead. > > -Derek > > > On 12/27/2010 09:48 AM, Derek Cormier wrote:

Re: [nox-dev] Contributing to Nox

Woops! I'm not sure how it happened but I somehow messed up the patch file. Please use this attached one instead. -Derek On 12/27/2010 09:48 AM, Derek Cormier wrote: Hi KK, I've attached the patch. Sorry for taking so long to reply, I was away for the holidays. The patch is for destiny. I ha

Re: [nox-dev] Contributing to Nox

Hi KK, I've attached the patch. Sorry for taking so long to reply, I was away for the holidays. The patch is for destiny. I have seen Murphy's patch, and this patch is based off of it. Murphy added the ability to use the component's register_handler method for error events, and mine just adds

Re: [nox-dev] Contributing to Nox

Thanks Alec. That's a useful feature I did not know about. Appreciate the advice. Hi Derek, Is this patch against destiny? We tend to patch the unstable branch (destiny), so if I can have a patch against destiny, that would be best. Also, have you seen Murphy's patch in the destiny branch? Re

Re: [nox-dev] Contributing to Nox

Hi Derek, Many thanks for the patch. Do you mind sending me the patch zipped or tarballed? Sorry Gmail reformats things a little, so the git-format-patch output is distorted. Regards KK On 21 December 2010 23:38, Derek Cormier wrote: > Hello, > > I would like to start contributing to the Nox