Re: [Numpy-discussion] Deprecate unused but exposed C-API functions

2020-01-24 Thread Sebastian Berg
On Fri, 2020-01-24 at 17:56 -0700, Charles R Harris wrote: > > > On Fri, Jan 24, 2020 at 11:29 AM Sebastian Berg < > sebast...@sipsolutions.net> wrote: > > Hi all, > > > > > > My idea is to add the deprecation warning now, and if nobody > > notices it > > remove them as soon as 1.19 is release

Re: [Numpy-discussion] Deprecate unused but exposed C-API functions

2020-01-24 Thread Charles R Harris
On Fri, Jan 24, 2020 at 11:29 AM Sebastian Berg wrote: > Hi all, > > I would like to deprecate three C-API functions (more may come later) > in https://github.com/numpy/numpy/pull/15427 > > The functions are: > * PyArray_GetArrayParamsFromObject > * PyUfunc_GenericCall > * PyUFunc_SetUsesAr

[Numpy-discussion] Deprecate unused but exposed C-API functions

2020-01-24 Thread Sebastian Berg
Hi all, I would like to deprecate three C-API functions (more may come later) in https://github.com/numpy/numpy/pull/15427 The functions are: * PyArray_GetArrayParamsFromObject * PyUfunc_GenericCall * PyUFunc_SetUsesArraysAsData I could not find downstream usage for any of these and they s

Re: [Numpy-discussion] what to clean up, what to leave as is

2020-01-24 Thread Sebastian Berg
On Fri, 2020-01-24 at 10:57 -0700, Charles R Harris wrote: > > > On Fri, Jan 24, 2020 at 10:42 AM Kevin Sheppard < > kevin.k.shepp...@gmail.com> wrote: > > I think some types of clean-ups, for example, imports, are pretty > > low cost, low risk and don't have much bearing on and it might be > > b

Re: [Numpy-discussion] what to clean up, what to leave as is

2020-01-24 Thread Charles R Harris
On Fri, Jan 24, 2020 at 10:42 AM Kevin Sheppard wrote: > I think some types of clean-ups, for example, imports, are pretty low > cost, low risk and don't have much bearing on and it might be best to do > them all at once. > > f-strings are also pretty simple but can be abused to the detriment of

Re: [Numpy-discussion] what to clean up, what to leave as is

2020-01-24 Thread Kevin Sheppard
I think some types of clean-ups, for example, imports, are pretty low cost, low risk and don't have much bearing on and it might be best to do them all at once. f-strings are also pretty simple but can be abused to the detriment of code around (for example, moving a string defined in a variable ou

Re: [Numpy-discussion] what to clean up, what to leave as is

2020-01-24 Thread Charles R Harris
On Fri, Jan 24, 2020 at 9:46 AM Ralf Gommers wrote: > Hi all, > > It's great to see that people are jumping at the chance to clean up Python > 2 support. I would however caution about overdoing it on other cleanups. As > a reminder, we normally do not want pure style PRs (e.g. PEP8 cleanups), > b

[Numpy-discussion] what to clean up, what to leave as is

2020-01-24 Thread Ralf Gommers
Hi all, It's great to see that people are jumping at the chance to clean up Python 2 support. I would however caution about overdoing it on other cleanups. As a reminder, we normally do not want pure style PRs (e.g. PEP8 cleanups), because they make the code history (git blame, commits on particul