Re: [Numpy-discussion] EHN: Discusions about 'add numpy.topk'

Since this going into the top namespace, I'd also vote against the matlab-y "topk" name. And even matlab didn't do what I would expect and went with maxk https://nl.mathworks.com/help/matlab/ref/maxk.html I think "max_k" is a good generalization of the regular "max". Even when auto-completing, th

Re: [Numpy-discussion] EHN: Discusions about 'add numpy.topk'

On Sat, May 29, 2021 at 3:35 PM Daniele Nicolodi wrote: > What does k stand for here? As someone that never encountered this > function before I find both names equally confusing. If I understand > what the function is supposed to be doing, I think largest() would be > much more descriptive. > `

Re: [Numpy-discussion] EHN: Discusions about 'add numpy.topk'

On 29/05/2021 18:33, David Menéndez Hurtado wrote: > > > On Sat, 29 May 2021, 4:29 pm Ralf Gommers, > wrote: > > > > On Fri, May 28, 2021 at 4:58 PM > wrote: > > Hi all, > > Finding topk elements is wid

Re: [Numpy-discussion] EHN: Discusions about 'add numpy.topk'

On Sat, 29 May 2021, 4:29 pm Ralf Gommers, wrote: > > > On Fri, May 28, 2021 at 4:58 PM wrote: > >> Hi all, >> >> Finding topk elements is widely used in several fields, but missed in >> NumPy. >> I implement this functionality named as numpy.topk using core numpy >> functions and open a PR: >>

Re: [Numpy-discussion] EHN: Discusions about 'add numpy.topk'

On Fri, May 28, 2021 at 4:58 PM wrote: > Hi all, > > Finding topk elements is widely used in several fields, but missed in > NumPy. > I implement this functionality named as numpy.topk using core numpy > functions and open a PR: > > https://github.com/numpy/numpy/pull/19117 > > Any discussion ar