[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Stefan van der Walt
On Sun, Nov 14, 2021, at 15:26, Juan Nunez-Iglesias wrote: > Oh, and yes, yapf does allow formatting only the diff. I agree that > reformatting the entire code base is problematic. That's a good point: it's possible to make these changes incrementally. There's something called yapf-diff. It's in

[Numpy-discussion] Re: new time for community meetings

2021-11-14 Thread Inessa Pawson
Thanks to everyone who participated in the poll. Starting November 24th, bi-weekly NumPy community meetings will be held at 7 pm GMT. On Wed, Nov 10, 2021 at 9:10 PM Inessa Pawson wrote: > It’s that time of the year again when most of us have to adjust our > clocks. For some of us the fun doesn’

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Neal Becker
I've also used uncrustify for c/c++. Of course this plays hell with revision control. On Sun, Nov 14, 2021 at 6:29 PM Juan Nunez-Iglesias wrote: > > > > On 15 Nov 2021, at 8:23 am, Stefan van der Walt wrote: > > On Sun, Nov 14, 2021, at 09:13, Charles R Harris wrote: > > The black formatter is

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Juan Nunez-Iglesias
> On 15 Nov 2021, at 8:23 am, Stefan van der Walt wrote: > > On Sun, Nov 14, 2021, at 09:13, Charles R Harris wrote: >> The black formatter is much improved in its latest version and I think good >> enough to start using. The main drawbacks that I see are: >> all operators, including '*' and '

[Numpy-discussion] Re: Revert the return of a single NaN for `np.unique` with floating point numbers?

2021-11-14 Thread Ralf Gommers
An update on this: after discussion in the community meeting the preferred direction is to add an `equal_nans` keyword and support both behaviors. Given that we won't get to this, I proposed on https://github.com/numpy/numpy/issues/20326 to make the default False, i.e. the same as for 1.21.x Cheer

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Stefan van der Walt
On Sun, Nov 14, 2021, at 09:13, Charles R Harris wrote: > The black formatter is much improved in its latest version and I think good > enough to start using. The main drawbacks that I see are: > * all operators, including '*' and '/', get spaces around them, > * very long strings are not broke

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Oscar Benjamin
On Sun, 14 Nov 2021 at 19:51, Jeff Reback wrote: > > in pandas we did a one time conversion to using black (a while ago) for > python (and recently added a cython formatter); we do also have automatic > c/cpp linters as well > > we have precommit rules to enforce this (and runs on ci) > > since

[Numpy-discussion] Re: win32 wheels for Python 3.10

2021-11-14 Thread Ralf Gommers
On Sun, Nov 14, 2021 at 9:05 PM Charles R Harris wrote: > > > On Sun, Nov 14, 2021 at 11:49 AM Ralf Gommers > wrote: > >> >> >> On Wed, Nov 10, 2021 at 2:36 PM Aivar Annamaa >> wrote: >> >>> Has it been decided to stop publishing win32 wheels for Python 3.10? >>> Numpy 1.21.4 currently misses w

[Numpy-discussion] Re: win32 wheels for Python 3.10

2021-11-14 Thread Charles R Harris
On Sun, Nov 14, 2021 at 11:49 AM Ralf Gommers wrote: > > > On Wed, Nov 10, 2021 at 2:36 PM Aivar Annamaa > wrote: > >> Has it been decided to stop publishing win32 wheels for Python 3.10? >> Numpy 1.21.4 currently misses win32 wheel for Python 3.10 on PyPI. Is this >> temporary? >> >> I'm confus

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Jeff Reback
in pandas we did a one time conversion to using black (a while ago) for python (and recently added a cython formatter); we do also have automatic c/cpp linters as well we have precommit rules to enforce this (and runs on ci) since then we don’t have discussions about formatting anymore :) woul

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Charles R Harris
On Sun, Nov 14, 2021 at 11:40 AM Ralf Gommers wrote: > > > On Sun, Nov 14, 2021 at 6:14 PM Charles R Harris < > charlesr.har...@gmail.com> wrote: > >> Hi All, >> >> This post is for discussing the automatic code formatters for C/C++/*.py >> that are now available. The current options, as I see th

[Numpy-discussion] Re: win32 wheels for Python 3.10

2021-11-14 Thread Ralf Gommers
On Wed, Nov 10, 2021 at 2:36 PM Aivar Annamaa wrote: > Has it been decided to stop publishing win32 wheels for Python 3.10? Numpy > 1.21.4 currently misses win32 wheel for Python 3.10 on PyPI. Is this > temporary? > > I'm confused, because > https://www.mail-archive.com/numpy-discussion@python.or

[Numpy-discussion] Re: Code formatters

2021-11-14 Thread Ralf Gommers
On Sun, Nov 14, 2021 at 6:14 PM Charles R Harris wrote: > Hi All, > > This post is for discussing the automatic code formatters for C/C++/*.py > that are now available. The current options, as I see them, are > clang-format (C/C++) and black (*.py, *.pyi, etc). Neither is perfect to my > eye, but

[Numpy-discussion] Code formatters

2021-11-14 Thread Charles R Harris
Hi All, This post is for discussing the automatic code formatters for C/C++/*.py that are now available. The current options, as I see them, are clang-format (C/C++) and black (*.py, *.pyi, etc). Neither is perfect to my eye, but I think they are good enough at this point and would reduce amount o