[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-11 Thread Robert Kern
On Wed, Oct 11, 2023 at 11:50 PM Aaron Meurer wrote: > Is there a way to make pickle not depend on the specific submodule > that a class is defined in? No. `Unpickler` somehow has to locate the class/reconstruction function. It will have to use the name given by the `__reduce_ex__` during pickl

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-11 Thread Aaron Meurer
Is there a way to make pickle not depend on the specific submodule that a class is defined in? Wouldn't this happen again if you ever decided to rename _core. The underscores in numpy._core._reconstruct don't actually do anything here in terms of making the interface not public, and if anything, a

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-11 Thread Nathan
On Wed, Oct 11, 2023 at 4:24 PM Mateusz Sokol wrote: > Hi! Thank you for all your feedback this week! > > We have made a decision to take a less disruptive option that we > considered and that came up in this discussion. > > We back out of the `NumpyUnpickler` class solution for reading pickles >

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-11 Thread Mateusz Sokol
Hi! Thank you for all your feedback this week! We have made a decision to take a less disruptive option that we considered and that came up in this discussion. We back out of the `NumpyUnpickler` class solution for reading pickles across major NumPy versions. Instead, we will retain `numpy.core`

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-11 Thread Matthew Brett
Hi, On Wed, Oct 11, 2023 at 9:17 AM Peter Cock via NumPy-Discussion wrote: > > > > On Tue, Oct 10, 2023 at 6:32 PM Matthew Brett wrote: >> >> Hi, >> >> >> On Tue, 10 Oct 2023 at 00:55, Andrew Nelson wrote: >> > >> > >> > On Mon, 9 Oct 2023 at 23:50, Matthew Brett wrote: >> >> >> >> Hi, >> >> >

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-11 Thread Peter Cock via NumPy-Discussion
On Tue, Oct 10, 2023 at 6:32 PM Matthew Brett wrote: > Hi, > > > On Tue, 10 Oct 2023 at 00:55, Andrew Nelson wrote: > > > > > > On Mon, 9 Oct 2023 at 23:50, Matthew Brett > wrote: > >> > >> Hi, > >> > >> On Mon, Oct 9, 2023 at 11:49 AM Andrew Nelson > wrote: > >> Could you say more about why y