Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-28 Thread josef . pktd
On Wed, Jun 28, 2017 at 10:48 AM, Marten van Kerkwijk < m.h.vankerkw...@gmail.com> wrote: > My two ¢: keep things as they are. There is just two much code that > uses the C definition of bools, 0=False, 1=True. Coupled with casting > every outcome that is unequal to 0 as True, * as AND, + as OR, a

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-28 Thread Marten van Kerkwijk
About visibility of deprecations: this is *very* tricky - if we make it more visible, every user is going to see deprecation warnings all the time, about things they can do nothing about, because they occur inside other packages. I think in the end the only choice is to have automated testing that

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-28 Thread Nathan Goldbaum
Just as a comment: It would be really nice if NumPy could slow down the pace of deprecations, or at least make the warnings about deprecations more visible. It seems like every release breaks some subset of our test suite (we only had one or two cases of using the binary - operator on boolean array

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-28 Thread Marten van Kerkwijk
My two ¢: keep things as they are. There is just two much code that uses the C definition of bools, 0=False, 1=True. Coupled with casting every outcome that is unequal to 0 as True, * as AND, + as OR, and - as XOR makes sense (and -True would indeed be True, but I'm quite happy to have that one rem

Re: [Numpy-discussion] : Boolean binary '-' operator

2017-06-27 Thread Alan Isaac
On 6/27/2017 5:35 PM, Nathaniel Smith wrote: I remember... The major issue here is that some people want dot(a, b) on Boolean matrices to use these semantics, right? Yes; this has worked in the past, and loss of this functionality is unexpected. That said, I haven't used this outside of a tea

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-27 Thread Eric Wieser
It seems to me that after a healthy post-deprecation cycle, and if we choose to keep the Z/2 meaning of __sub__, it might be worth reintroducing __neg__ as a no-op? AFAICT, this is consistent with the Z/2 interpretation? Eric On Wed, 28 Jun 2017 at 00:08 Nathaniel Smith wrote: > On Tue, Jun 27,

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-27 Thread Nathaniel Smith
On Tue, Jun 27, 2017 at 3:09 PM, Robert Kern wrote: > On Tue, Jun 27, 2017 at 3:01 PM, Benjamin Root wrote: >> >> Forgive my ignorance, but what is "Z/2"? > > https://groupprops.subwiki.org/wiki/Cyclic_group:Z2 > https://en.wikipedia.org/wiki/Cyclic_group This might be a slightly better link? ht

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-27 Thread Robert Kern
On Tue, Jun 27, 2017 at 3:01 PM, Benjamin Root wrote: > > Forgive my ignorance, but what is "Z/2"? https://groupprops.subwiki.org/wiki/Cyclic_group:Z2 https://en.wikipedia.org/wiki/Cyclic_group -- Robert Kern ___ NumPy-Discussion mailing list NumPy-Dis

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-27 Thread Benjamin Root
Forgive my ignorance, but what is "Z/2"? On Tue, Jun 27, 2017 at 5:35 PM, Nathaniel Smith wrote: > On Jun 26, 2017 6:56 PM, "Charles R Harris" > wrote: > > >> On 27 Jun 2017, 9:25 AM +1000, Nathaniel Smith , wrote: >> > I guess my preference would be: >> 1) deprecate + >> 2) move binary - back

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-27 Thread Nathaniel Smith
On Jun 26, 2017 6:56 PM, "Charles R Harris" wrote: > On 27 Jun 2017, 9:25 AM +1000, Nathaniel Smith , wrote: > I guess my preference would be: > 1) deprecate + > 2) move binary - back to deprecated-but-not-an-error > 3) fix np.diff to use logical_xor when the inputs are boolean, since > that see

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-26 Thread Charles R Harris
On Mon, Jun 26, 2017 at 6:14 PM, Juan Nunez-Iglesias wrote: > OMG deprecating + would be a nightmare. I can’t even begin to count the > number of times I’ve used e.g. np.sum(arr == num)… Originally with a dtype > cast but generally I’ve removed it because it worked. > > … But I just saw the behav

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-26 Thread Juan Nunez-Iglesias
OMG deprecating + would be a nightmare. I can’t even begin to count the number of times I’ve used e.g. np.sum(arr == num)… Originally with a dtype cast but generally I’ve removed it because it worked. … But I just saw the behaviour of `sum` is different from that of adding arrays together (wher

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-26 Thread Nathaniel Smith
On Sun, Jun 25, 2017 at 9:45 AM, Stefan van der Walt wrote: > Hi Chuck > > On Sun, Jun 25, 2017, at 09:32, Charles R Harris wrote: > >> The boolean binary '-' operator was deprecated back in NumPy 1.9 and changed >> to an error in 1.13. This caused a number of failures in downstream >> projects. T

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-26 Thread Sebastian Berg
On Sun, 2017-06-25 at 18:59 +0200, Julian Taylor wrote: > On 25.06.2017 18:45, Stefan van der Walt wrote: > > Hi Chuck > > > > On Sun, Jun 25, 2017, at 09:32, Charles R Harris wrote: > > > The boolean binary '-' operator was deprecated back in NumPy 1.9 > > > and > > > changed to an error in 1.13.

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-25 Thread Julian Taylor
On 25.06.2017 18:45, Stefan van der Walt wrote: > Hi Chuck > > On Sun, Jun 25, 2017, at 09:32, Charles R Harris wrote: >> The boolean binary '-' operator was deprecated back in NumPy 1.9 and >> changed to an error in 1.13. This caused a number of failures in >> downstream projects. The choices now

Re: [Numpy-discussion] Boolean binary '-' operator

2017-06-25 Thread Stefan van der Walt
Hi Chuck On Sun, Jun 25, 2017, at 09:32, Charles R Harris wrote: > The boolean binary '-' operator was deprecated back in NumPy 1.9 and > changed to an error in 1.13. This caused a number of failures in > downstream projects. The choices now are to continue the deprecation > for another couple of

[Numpy-discussion] Boolean binary '-' operator

2017-06-25 Thread Charles R Harris
Hi All, The boolean binary '-' operator was deprecated back in NumPy 1.9 and changed to an error in 1.13. This caused a number of failures in downstream projects. The choices now are to continue the deprecation for another couple of releases, or simply give up on the change. For booleans, `a - b`