Re: [Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Eric Wieser
gt; > *From: *NumPy-Discussion gmail@python.org> on behalf of Benjamin Root > *Reply-To: *Discussion of Numerical Python > *Date: *Tuesday, April 6, 2021 at 2:58 PM > *To: *Discussion of Numerical Python > *Subject: *Re: [Numpy-discussion] MAINT: Use of except-pass block

Re: [Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Michael Dubravski
Python Subject: Re: [Numpy-discussion] MAINT: Use of except-pass blocks In both of those situations, the `pass` aspect makes sense, although they probably should specify a better exception class to catch. The first one, with the copyto() has a comment that explains what is goingon. The second

Re: [Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Benjamin Root
In both of those situations, the `pass` aspect makes sense, although they probably should specify a better exception class to catch. The first one, with the copyto() has a comment that explains what is goingon. The second one, dealing with adding to the docstring, is needed because one can run pyth

[Numpy-discussion] MAINT: Use of except-pass blocks

2021-04-06 Thread Michael Dubravski
Hello everyone, There are multiple instances of except-pass blocks within the codebase that to my knowledge are bad practices (Referencing This StackOverflow Article. For example in numpy/ma/core.py there is an except-pass block that catches all exceptions thrown. Another example of this can